Change in vdsm[master]: net: reconfigure bond detached from bridges

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63723/4/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 351: if (backing_device is not None and
Line 352: os.path.exists(NET_PATH + '/' + backing_device.name)):
Line 353: configurator.removeQoS(net_ent)
Line 354: 
Line 355: # TODOL remove BRIDGE line
What is this?
Line 356: 
Line 357: 
Line 358: def _validateDelNetwork(network, vlan, bonding, nics, 
bridge_should_be_clean,
Line 359: _netinfo):


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 4:

could you add a functional test for the user scenario

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 4:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 3:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 2:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
> When bonds_setup takes place, some networks are not there and we are not ab
If you put it like that:
bonds_setup creates bonds attached to networks?
I guess this is not true for new bonds, but may be true for edited ones (is 
it?).
add_missing_networks edits the bonds and specify if they are slaves of a bridge 
(or a vlan).

So it looks like we must have it after add_missing_networks and bonds_setup.
After bonds_setup because the non-vlan network could have been removed in 
remove_networks and nothing added at add_missing.
After add_missing because...

Lets call it 'bonds_post_setup' to be less specific in this abstraction level.
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
> I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a
When bonds_setup takes place, some networks are not there and we are not able 
to tell if the bond is to be detached from bridge or not.

Well maybe we are! Do you think it would be better to pass networks to 
bonds_setup as well and check if used bridge-network is to be changed?
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 665: 'Reconfigurating bond %s that were detached from 
bridge', bond)
Line 666: configurator.configureBond(bond)
Line 667: 
Line 668: 
Line 669: def _ifcfg_attached_to_bridge(iface_name):
Should be implemented through the configurator API, it is ifcfg specific.
Line 670: path = NET_CONF_PREF + iface_name
Line 671: if os.path.isfile(path):
Line 672: with open(path) as f:
Line 673: for line in f.readlines():


https://gerrit.ovirt.org/#/c/63723/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 137: 
Line 138: legacy_switch.add_missing_networks(configurator, networks,
Line 139:bondings, _netinfo)
Line 140: 
Line 141: legacy_switch.reconfigure_unbridged_bonds(configurator, 
_netinfo)
I think it belongs at the tail of legacy_switch.bonds_setup, no? Is there a 
reason why it needs to be exposed at this abstraction level?
Line 142: 
Line 143: connectivity.check(options)
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond detached from bridges

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: reconfigure bond detached from bridges
..


Patch Set 1:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org