Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Mark Wu has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: (1 comment) File vdsm/netmodels.py Line 389: to bonding in the same order that initscripts does it. Then it can Line 390: obtain the same master mac address by iproute2 as ifcfg. Line 391: Line 392: Line 393: nics_list = [] Good catch! I will fix it in next patch. Line 394: nics_rexp = re.compile(^(\D*)(\d*)(.*)$) Line 395: Line 396: for nic_name in nics: Line 397: nic_sre = nics_rexp.match(nic_name) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/658/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3943/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 4: Verified+1 Code-Review+2 Copying v+1 from PS 3. -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: Sort bond's slave when objectivizing .. netconf: Sort bond's slave when objectivizing To make iproute2 configurator pass testBondHwAddress, we need keep the bond's slaves sorted. Otherwise bond's hwaddr will vary with the order of enslaving. This work is done by initscript for ifcfg configurator. The patch restores the nicSort function to get the same order of initscript does. Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/19591 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M tests/netmodelsTests.py M vdsm/netmodels.py 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Code-Review+1 Looks good to me, but should be kept out until we leave our current bugfix-only phase. -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Code-Review-1 (1 comment) I hate to -1 on such a technicality when it is recovered code, but I'd like to keep netmodels as compliant to the style guidelines as possible. File vdsm/netmodels.py Line 389: to bonding in the same order that initscripts does it. Then it can Line 390: obtain the same master mac address by iproute2 as ifcfg. Line 391: Line 392: Line 393: nics_list = [] variable name convention is camelCase. Thus, it should be nicsList, nicsRexp, nicSre Line 394: nics_rexp = re.compile(^(\D*)(\d*)(.*)$) Line 395: Line 396: for nic_name in nics: Line 397: nic_sre = nics_rexp.match(nic_name) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Mark Wu has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 1: Code-Review-1 I guess configureBond of iproute2.py could do it as well, but I don't really mind doing it here as the sorting cost of the amount of nics that are typically enslaved to a bond is rather small. However, I'd like a comment above the line that explains the reason for the sorting, e.g., Sorting nics in order to have a deterministic slave list for the same slaves. -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Mark Wu has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 1: Toni, thanks for the quick response! Actually I thought fixing in iproute2, but we need sort the nic object both in configureBond and editBonding. So I think bond's objectivize is a better place to fix it. I will add a comments as you suggested. -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4571/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 2: Code-Review+1 Thanks! -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 2: Code-Review-1 (2 comments) Commit Message Line 8: Line 9: To make iproute2 configurator pass testBondHwAddress, we need keep Line 10: the bond's slaves sorted. Otherwise bond's hwaddr will vary with the Line 11: order of enslaving. This work is done by initscript for ifcfg Line 12: configurator. Do we mind that the slave order would depend on the configurator identity? ifcfg uses a more complex storting function, which we used to imitate in vdsm. grep for 'def nicSort'. Line 13: Line 14: Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae File vdsm/netmodels.py Line 234: def objectivize(cls, name, configurator, options, nics, mtu, _netinfo, Line 235: destroyOnMasterRemoval=None): Line 236: if name and nics: # New bonding or edit bonding. Line 237: Line 238: Sorting nics in order to have a deterministic slave list for the why is it a string instead of a plain comment? Line 239: same slaves Line 240: Line 241: slaves = cls._objectivizeSlaves(name, configurator, sorted(nics), Line 242: mtu, _netinfo) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Mark Wu has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4650/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4574/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
