Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


numa: Don't crash on hotplugged CPUs when retrieving NUMA info

getVmNumaNodeRuntimeInfo maps virtual (from Engine) nodes to physical
nodes by matching nodes and CPUs from the libvirt runtime and from the
Engine NUMA mapping.  CPUs that are not pinned to any node in the Engine
NUMA mapping (such as hotplugged CPUs) are irrelevant.  However the
matching cycle still looks for them in the Engine NUMA mapping
dictionary, resulting in KeyError.

This patch fixes the KeyError by simply skipping the CPUs not present in
the Engine NUMA mapping.

Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/65562
Reviewed-by: Martin Polednik 
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/numa.py
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[fromani]

Francesco Romani has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 3: Code-Review+2

a test would be a great addition to help this bug not resurface.
I'm ok if you add in a followup patch

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py
File lib/vdsm/numa.py:

PS2, Line 274: virt
> just noticed - to any *virtual* numa node
Right, thanks, done.


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py
File lib/vdsm/numa.py:

PS2, Line 274: NUMA
just noticed - to any *virtual* numa node


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/65562/1/lib/vdsm/numa.py
File lib/vdsm/numa.py:

PS1, Line 265: # hotplugged CPU
> Hotplugged CPU or a bug - maybe the comment could give slightly more idea o
Done


PS1, Line 266:  continue
> What about log message of warn/info/debug level that something fishy is goi
Done


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 1:

(2 comments)

Missing some description of behavior what is happening within engine.

https://gerrit.ovirt.org/#/c/65562/1/lib/vdsm/numa.py
File lib/vdsm/numa.py:

PS1, Line 265: # hotplugged CPU
Hotplugged CPU or a bug - maybe the comment could give slightly more idea of 
what is going on (we have a list of cpus in a numa, node, one of them is 
missing...) -- to help us understand the code next time we have to open it.


PS1, Line 266:  continue
What about log message of warn/info/debug level that something fishy is going 
on?


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..

numa: Don't crash on hotplugged CPUs when retrieving NUMA info

getVmNumaNodeRuntimeInfo maps virtual (from Engine) nodes to physical
nodes by matching nodes and CPUs from the libvirt runtime and from the
Engine NUMA mapping.  CPUs that are not pinned to any node in the Engine
NUMA mapping (such as hotplugged CPUs) are irrelevant.  However the
matching cycle still looks for them in the Engine NUMA mapping
dictionary, resulting in KeyError.

This patch fixes the KeyError by simply skipping the CPUs not present in
the Engine NUMA mapping.

Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Signed-off-by: Milan Zamazal 
---
M lib/vdsm/numa.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/65562/1

diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index 7a31a99..15a8c73 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -260,7 +260,10 @@
 vcpu_to_vnode = _get_mapping_vcpu_to_vnode(vm)
 
 for vcpu_id, pcpu_id in vcpu_to_pcpu.iteritems():
-vnode_index = str(vcpu_to_vnode[vcpu_id])
+try:
+vnode_index = str(vcpu_to_vnode[vcpu_id])
+except KeyError:# hotplugged CPU
+continue
 vm_numa_placement[vnode_index].add(pcpu_to_pnode[pcpu_id])
 vm_numa_placement[vnode_index].update(
 vcpu_to_pnode.get(vcpu_id, ()))


-- 
To view, visit https://gerrit.ovirt.org/65562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org