Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-05 Thread danken 
Dan Kenigsberg has abandoned this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Abandoned

Thanks, but I've already taken Piotr's patch fixing this regression.

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-03 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1:

I take back the first part - my testing was done on jsonrpc.

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-03 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1: Code-Review-1

For some reason, it's working fine for me. Have you done anything specific in 
your setup that leads to the failure?

As for the patch itself, I'm fine with it but in caps.py - it is not in any way 
related to numa. caps.py will soon enough be more or less a collection of 
formatting scripts that form the getVdsCaps output.

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-02 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1: Code-Review+1

oops! surely we need this conversion, not sure if it is best done here or in 
caps.py, just before to return the full response to be sent on wire. Martin, 
the choice is yours, I'm ok both ways.

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-02 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1: Verified+1

The exception is now fixed.

Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 2995, in 
code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClient.py", line 550, in do_getCap
return self.ExecAndExit(self.s.getVdsCapabilities())
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1240, in __call__
return self.__send(self.__name, args)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1599, in __request
verbose=self.__verbose
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1280, in request
return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1313, in single_request
return self.parse_response(response)
  File "/usr/lib/python2.7/site-packages/vdsm/vdscli.py", line 43, in 
wrapped_parse_response
return old_parse_response(*args, **kwargs)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1490, in parse_response
return u.close()
  File "/usr/lib64/python2.7/xmlrpclib.py", line 799, in close
raise Fault(**self._stack[0])
Fault: :cannot marshal  objects">

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-02 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: numa: work around defaultdict marshalling for xmlrpc

2016-03-02 Thread osvoboda 
Ondřej Svoboda has uploaded a new change for review.

Change subject: numa: work around defaultdict marshalling for xmlrpc
..

numa: work around defaultdict marshalling for xmlrpc

vdsClient -s 0 getVdsCaps would now fail with
cannot marshal  objects

Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/numa.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/54283/1

diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index c196e0b..6a215d0 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -98,7 +98,7 @@
 'onlineCpus': online_cpus,
 }
 
-return NumaTopology(topology, distances, cpu_topology)
+return NumaTopology(dict(topology), dict(distances), cpu_topology)
 
 
 def memory_by_cell(index):


-- 
To view, visit https://gerrit.ovirt.org/54283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83c85fa396cebbc93b1eb625132b218aee1119a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches