Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 13: * #1299480::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
Francesco Romani has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 13: Code-Review-1 need to properly understand why this is returned. Otherwise this may hide some bugs. -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 13: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 12: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 11: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 10: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 9: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 8: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 7: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 6: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 5: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
Dan Kenigsberg has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53056/4/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 302: except libvirt.libvirtError as e: Line 303: if e.get_error_code() in ( Line 304: # race on shutdown/migration completion Line 305: libvirt.VIR_ERR_NO_DOMAIN, Line 306: # TODO: sometimes libvirt raises this on please open the bug to track this mystery, and put its url here. Line 307: # shutdown/migration completion Line 308: libvirt.VIR_ERR_OPERATION_UNSUPPORTED, Line 309: ): Line 310: # known benign cases: migration in progress or completed -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 4: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 3: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
Francesco Romani has uploaded a new change for review. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED libvirt sometimes raises it after migrations. Need to investigate why it happens. Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Signed-off-by: Francesco Romani--- M tests/periodicTests.py M vdsm/virt/periodic.py 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/53056/1 diff --git a/tests/periodicTests.py b/tests/periodicTests.py index b971810..d742dd7 100644 --- a/tests/periodicTests.py +++ b/tests/periodicTests.py @@ -248,6 +248,8 @@ # errcode, migrating, last_status [libvirt.VIR_ERR_NO_DOMAIN, True, vmstatus.UP], [libvirt.VIR_ERR_NO_DOMAIN, False, vmstatus.DOWN], +[libvirt.VIR_ERR_OPERATION_UNSUPPORTED, True, vmstatus.UP], +[libvirt.VIR_ERR_OPERATION_UNSUPPORTED, False, vmstatus.DOWN], ]) def test_swallow_exceptions(self, errcode, migrating, last_status): diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py index 6ce8693..1b41d1c 100644 --- a/vdsm/virt/periodic.py +++ b/vdsm/virt/periodic.py @@ -304,6 +304,9 @@ if e.get_error_code() in ( # race on shutdown/migration completion libvirt.VIR_ERR_NO_DOMAIN, +# TODO: sometimes libvirt raises this on +# shutdown/migration completion +libvirt.VIR_ERR_OPERATION_UNSUPPORTED, ): # known benign cases: migration in progress or completed if migrating or self._vm.lastStatus == vmstatus.DOWN: -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco RomaniGerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches