Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-10-09 Thread ahadas 
Arik Hadas has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 2:

(1 comment)


Commit Message
Line 9: By using libvirt's VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag we minimize the
Line 10: time the VM is switched to paused state while creating live snapshot
Line 11: with RAM. Without this flag the VM is switched to pause state for the
Line 12: whole process of dumping the memory, and with this flag the VM is
Line 13: switched to pause state only for a short time.
yes, I was aware to the tradeoff between the size of the memory dump image and 
the downtime of the guest. imo it is preferable to minimize the downtime of the 
guest, even if it means we're using more space in the storage, as the ram 
snapshot feature is much less attractive when the vm is paused for the whole 
memory dump process.

But on second thought, it might be problematic in case of block based storage, 
as in this case the volume we create for the memory dump is raw+preallocated, 
and if the actual size of the memory data is more than we allocated, the 
operation will probably fail I guess..

So I'll abandon this patch for now and later on I'll check if we can change the 
memory dump volume to be always cow (it seems there is no reason to allocate it 
as raw..) and then we would be able to use this flag as the volume size could 
grow as needed (we should also verify with libvirt that they report some kind 
of error if the memory dump is not converging btw).
Line 14: 
Line 15: Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-10-08 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4755/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4831/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3946/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-10-08 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-10-08 Thread fsimonce 
Federico Simoncelli has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-17 Thread ahadas 
Arik Hadas has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-17 Thread michal . skrivanek 
Michal Skrivanek has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 1:

(1 comment)


File vdsm/vm.py
Line 3673: else:
Line 3674: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
Line 3675: 
Line 3676: if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 3677: snapFlags |= 
libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
I wonder whether we should use this for mem snapshot as well...
Line 3678: 
Line 3679: snapxml = snap.toprettyxml()
Line 3680: self.log.debug(snapxml)
Line 3681: 


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-17 Thread ahadas 
Arik Hadas has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 1:

(1 comment)


File vdsm/vm.py
Line 3673: else:
Line 3674: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
Line 3675: 
Line 3676: if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 3677: snapFlags |= 
libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
do you mean hibernation?
Line 3678: 
Line 3679: snapxml = snap.toprettyxml()
Line 3680: self.log.debug(snapxml)
Line 3681: 


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-17 Thread michal . skrivanek 
Michal Skrivanek has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 1:

(1 comment)


File vdsm/vm.py
Line 3673: else:
Line 3674: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
Line 3675: 
Line 3676: if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 3677: snapFlags |= 
libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
i mean RAM snapshot as well. it makes sense to freeze FS to converge 
quicker...we are supposedly supporting qemu-ga even though we don't deploy it 
yet.
Line 3678: 
Line 3679: snapxml = snap.toprettyxml()
Line 3680: self.log.debug(snapxml)
Line 3681: 


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-16 Thread ahadas 
Arik Hadas has uploaded a new change for review.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..

reduce the time VM is paused in snapshot with RAM creation

By using libvirt's VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag we minimize the
time the VM is switched to paused state while creating live snapshot
with RAM. Without this flag the VM is switched to pause state for the
whole process of dumping the memory, and with this flag the VM is
switched to pause state only for a short time.

Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Signed-off-by: Arik Hadas aha...@redhat.com
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/19296/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 92d274e..6dece1f 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3668,6 +3668,8 @@
 memoryVol = memoryParams['dst']
 memoryVolPath = self.cif.prepareVolumePath(memoryVol)
 snap.appendChild(_memorySnapshot(memoryVolPath))
+
+snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_LIVE
 else:
 snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
 


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

2013-09-16 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4485/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4404/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3588/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches