Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has abandoned this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Abandoned Not needed after libvirt eventloop fix was merged. Cleaning up imports in remoteFileHandler should be done elsewhere. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: I do not quite understand what is the charter of the new host.py module. Does it have any definition beyond the part of caps which oop needs? In the current form, your definition is precise :-) Its name is too general, too. The motivation for the name is simply: import host if host.isOvirtNode(): I'd like to understand the planned boundary between host.py and caps.py. In the final form, host can include anything which is related to host info, while caps can be responsible for building a capabilities response from host and libvirtconnection modules. But in this form, host will include lot of stuff that remoteFileHandler does not need. This is way I abandoned this patch. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Saggi Mizrahi has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Code-Review+1 This is not a problem in remoteFileHandler so I wouldn't label it as such. It's a problem with having a misc module. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: The commit message is totally wrong now, and I'm not sure this it the best way to avoid the unneeded imports. This is here only because Yaniv wanted it back. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Dan Kenigsberg has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: I am a bit reluctant about the patch in its current form. It is important to keep the helper processes lean, but I do not quite understand what is the charter of the new host.py module. Does it have any definition beyond the part of caps which oop needs? Its name is too general, too. I feel uncomfortable saying this, given the extraordinary outcome of my ae7fbc6d4f2. Still, I'd like to understand the planned boundary between host.py and caps.py. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Yaniv Bronhaim has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: just upload the debian part also and verify. thanks -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has abandoned this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Abandoned libvirtconnection dependency is not harmful any more after http://gerrit.ovirt.org/22322 was merged. The issue of of importing random unneeded modules in remoteFileHandler remain, but this change does is not enough to for resolve this issue. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Yaniv Bronhaim has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: This patch is useful imo, just no need to relate it to the bug or to the libvirtconnection dependency . The host.py is nice to have to decrease each external process size, I'd suggest to reopen this patch -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has restored this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Restored Yaniv wants this. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Correct commit message - it is not libvirt but us creating that thread in libvirtconnection. Creating a thread on import is horrible idea that will be fixed in another patch. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6150/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/127/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Vinzenz Feenstra has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Verified+1 Code-Review+1 Verified on both el6 hosts where the issue was originally induced. After using this patch the issue no longer occurs -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: The event loop implicit start is handled by http://gerrit.ovirt.org/#/c/22322/. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Yaniv Bronhaim has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2: -Code-Review
(1 comment)
you forgot the debian folder .. please update
File vdsm.spec.in
Line 852: %{_datadir}/%{vdsm_name}/dmidecodeUtil.py*
Line 853: %{_datadir}/%{vdsm_name}/API.py*
Line 854: %{_datadir}/%{vdsm_name}/hooking.py*
Line 855: %{_datadir}/%{vdsm_name}/hooks.py*
Line 856: %{_datadir}/%{vdsm_name}/host.py*
add also to debian/vdsm.install
Line 857: %{_datadir}/%{vdsm_name}/lsblk.py*
Line 858: %{_datadir}/%{vdsm_name}/md_utils.py*
Line 859: %{_datadir}/%{vdsm_name}/mk_sysprep_floppy
Line 860: %{_datadir}/%{vdsm_name}/parted_utils.py*
--
To view, visit http://gerrit.ovirt.org/22316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 852: %{_datadir}/%{vdsm_name}/dmidecodeUtil.py*
Line 853: %{_datadir}/%{vdsm_name}/API.py*
Line 854: %{_datadir}/%{vdsm_name}/hooking.py*
Line 855: %{_datadir}/%{vdsm_name}/hooks.py*
Line 856: %{_datadir}/%{vdsm_name}/host.py*
Will do
Line 857: %{_datadir}/%{vdsm_name}/lsblk.py*
Line 858: %{_datadir}/%{vdsm_name}/md_utils.py*
Line 859: %{_datadir}/%{vdsm_name}/mk_sysprep_floppy
Line 860: %{_datadir}/%{vdsm_name}/parted_utils.py*
--
To view, visit http://gerrit.ovirt.org/22316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Allon Mureinik has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Code-Review+1 +1, except for Yaniv's comment on debian. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 852: %{_datadir}/%{vdsm_name}/dmidecodeUtil.py*
Line 853: %{_datadir}/%{vdsm_name}/API.py*
Line 854: %{_datadir}/%{vdsm_name}/hooking.py*
Line 855: %{_datadir}/%{vdsm_name}/hooks.py*
Line 856: %{_datadir}/%{vdsm_name}/host.py*
Done
Line 857: %{_datadir}/%{vdsm_name}/lsblk.py*
Line 858: %{_datadir}/%{vdsm_name}/md_utils.py*
Line 859: %{_datadir}/%{vdsm_name}/mk_sysprep_floppy
Line 860: %{_datadir}/%{vdsm_name}/parted_utils.py*
--
To view, visit http://gerrit.ovirt.org/22316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Dan Kenigsberg has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Do we still need this patch, given http://gerrit.ovirt.org/#/c/22322/ ? I am not sure about the charter of the new host module. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: We need this patch because we don't want import unused code in remoteFileHandler process. The host module can take more code from caps and other modules (e.g. vdsm.utils.getHostUUID). I added only isOvirtNode and code it needs because I wanted a smaller and quicker fix. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has uploaded a new change for review.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
remoteFileHandler: Remove harmful libvirt dependency
Commit ae7fbc6d4f2 added caps.isOvirtNode function, which was imported
into storage.misc, used by storage.remoteFileHandler. Since libvirt is
imported into caps, this caused libvirt to be imported into every out of
process remoteFileHandler.
Turns out that importing libvirt create a hidden libvirt event loop
thread, which seems to be quite busy, consuming about 50% cpu time,
and overloading the host.
This patch moves isOvirtNode and related functions to new host module,
and import this module instead of caps.
Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/caps.py
M vdsm/clientIF.py
A vdsm/host.py
M vdsm/storage/misc.py
7 files changed, 70 insertions(+), 37 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/22316/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0bd4202..9f831a2 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -853,6 +853,7 @@
%{_datadir}/%{vdsm_name}/API.py*
%{_datadir}/%{vdsm_name}/hooking.py*
%{_datadir}/%{vdsm_name}/hooks.py*
+%{_datadir}/%{vdsm_name}/host.py*
%{_datadir}/%{vdsm_name}/lsblk.py*
%{_datadir}/%{vdsm_name}/md_utils.py*
%{_datadir}/%{vdsm_name}/mk_sysprep_floppy
diff --git a/vdsm/API.py b/vdsm/API.py
index 44d5817..3c5238e 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -38,6 +38,7 @@
from netconf import RollbackIncomplete
from vdsm import netinfo
from vdsm import constants
+import host
import storage.misc
import storage.clusterlock
import storage.volume
@@ -226,7 +227,7 @@
vmParams['vmId'])
vmParams['volatileFloppy'] = True
-if caps.osversion()['name'] == caps.OSName.UNKNOWN:
+if caps.osversion()['name'] == host.OSName.UNKNOWN:
return {'status': {'code': errCode['createErr']
['status']['code'],
'message': 'Unknown host operating system'}}
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 1044f66..b22e17f 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -35,6 +35,7 @@
guestIF.py \
hooking.py \
hooks.py \
+ host.py \
kaxmlrpclib.py \
ksm.py \
logUtils.py \
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 3839134..9a81dc5 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -27,7 +27,6 @@
import logging
import time
import linecache
-import glob
import libvirt
import rpm
@@ -37,6 +36,7 @@
import dsaversion
from vdsm import netinfo
import hooks
+from host import getOSName, OSName
from vdsm import utils
import storage.hba
@@ -55,14 +55,6 @@
except ImportError:
_glusterEnabled = False
-
-class OSName:
-UNKNOWN = 'unknown'
-OVIRT = 'oVirt Node'
-RHEL = 'RHEL'
-FEDORA = 'Fedora'
-RHEVH = 'RHEV Hypervisor'
-DEBIAN = 'Debian'
RNG_SOURCES = {'random': '/dev/random',
'hwrng': '/dev/hwrng'}
@@ -269,26 +261,10 @@
@utils.memoized
-def getos():
-if os.path.exists('/etc/rhev-hypervisor-release'):
-return OSName.RHEVH
-elif glob.glob('/etc/ovirt-node-*-release'):
-return OSName.OVIRT
-elif os.path.exists('/etc/fedora-release'):
-return OSName.FEDORA
-elif os.path.exists('/etc/redhat-release'):
-return OSName.RHEL
-elif os.path.exists('/etc/debian_version'):
-return OSName.DEBIAN
-else:
-return OSName.UNKNOWN
-
-
-@utils.memoized
def osversion():
version = release = ''
-osname = getos()
+osname = getOSName()
try:
if osname == OSName.RHEVH or osname == OSName.OVIRT:
d = _parseKeyVal(file('/etc/default/version'))
@@ -383,7 +359,9 @@
pkgs = {'kernel': kernelDict()}
-if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL):
+osname = getOSName()
+
+if osname in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL):
KEY_PACKAGES = {'qemu-kvm': ('qemu-kvm', 'qemu-kvm-rhev'),
'qemu-img': ('qemu-img', 'qemu-img-rhev'),
'vdsm': ('vdsm',),
@@ -414,7 +392,7 @@
except:
logging.error('', exc_info=True)
-elif getos() == OSName.DEBIAN and python_apt:
+elif osname == OSName.DEBIAN and python_apt:
KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm', 'qemu-img': 'qemu-utils',
'vdsm': 'vdsmd', 'spice-server': 'libspice-server1',
'libvirt': 'libvirt0', 'mom': 'mom'}
@@ -434,7 +412,3 @@
logging.error('', exc_info=True)
return pkgs
-
-
-def isOvirtNode():
-return getos() in (OSName.RHEVH,
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 1: Vinzenz - can you verify that this fix the issue on your host? -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5259/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/126/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Dan Kenigsberg has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 1: Code-Review+1 Oh dear. Creating a thread on import is quite bad. We should also understand why the event loop is so wasteful. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
