Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: schema: fixing type of default values
..


schema: fixing type of default values


Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Signed-off-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/65113
Continuous-Integration: Jenkins CI
Reviewed-by: Andrej Krejcir 
Reviewed-by: Nir Soffer 
---
M lib/api/vdsm-api.yml
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Andrej Krejcir: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir 
Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 2119
Line 2120
Line 2121
Line 2122
Line 2123
> Lets simplify, we will take this patch, and Andrej will send a patch for th
Ok


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir 
Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 2119
Line 2120
Line 2121
Line 2122
Line 2123
> Andrej, it would be great if you can take over this fixup patch, and make t
Lets simplify, we will take this patch, and Andrej will send a patch for the 
description.


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS1, Line 2123: 
> This note could be in the description instead, so user knows about the mean
Andrej, it would be great if you can take over this fixup patch, and make this 
change yourself, as well as improve the its commit message as requested by Nir.


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir 
Andrej Krejcir has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS1, Line 2123: 
This note could be in the description instead, so user knows about the meaning 
of 0.


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-05 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65113/1//COMMIT_MSG
Commit Message:

Line 4: Commit: Piotr Kliczewski 
Line 5: CommitDate: 2016-10-05 12:58:23 +0200
Line 6: 
Line 7: schema: fixing type of default values
Line 8: 
Can you add reference to the commit that added these errors?

I like this format when mentioning other commits:

commit d5ccb59df699 (Fix API schema to align with runtime schema)
Line 9: 
Line 10: Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-05 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1: Code-Review+1

Looks good, but we need ack from the SLA team.

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-05 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-05 Thread piotr . kliczewski 
Piotr Kliczewski has uploaded a new change for review.

Change subject: schema: fixing type of default values
..

schema: fixing type of default values


Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Signed-off-by: Piotr Kliczewski 
---
M lib/api/vdsm-api.yml
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/65113/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 776b592..9ebac7a 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -2120,35 +2120,35 @@
 description: I/O tune parameters for the VM disk device.
 name: VmDiskDeviceIoTuneParams
 properties:
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Total throughput limit in bytes per
 second.
 name: total_bytes_sec
 type: uint
 
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Read throughput limit in bytes per
 second.
 name: read_bytes_sec
 type: uint
 
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Write throughput limit in bytes per
 second.
 name: write_bytes_sec
 type: uint
 
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Total I/O operations limit per second.
 name: total_iops_sec
 type: uint
 
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Read I/O operations limit per second.
 name: read_iops_sec
 type: uint
 
--   defaultvalue: 0 - means unlimited
+-   defaultvalue: 0
 description: Write I/O operations limit per second.
 name: write_iops_sec
 type: uint


-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: schema: fixing type of default values
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org