Change in vdsm[master]: sos: collect 'nodectl info' output

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: sos: collect 'nodectl info' output
..


sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63765
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 2:

* #1372093::Update tracker: OK
* Set MODIFIED::bug 1372093#1372093IGNORE, not all related patches are 
closed, check 63775

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Verified+1

[root@rhevh-25 sos]# ll 
sosreport-rhevh-25.gsslab.rdu2.redhat.com-20160921153154/sos_commands/vdsm/
total 84
-rw-r--r--. 1 root root 2610 Sep 21 15:31 fdisk_-l
-rw-r--r--. 1 root root   27 Sep 21 15:31 iscsiadm_-m_node
-rw-r--r--. 1 root root   30 Sep 21 15:31 iscsiadm_-m_session
-rw-r--r--. 1 root root   65 Sep 21 15:31 ls_-ldZ_.etc.vdsm
-rw-r--r--. 1 root root8 Sep 21 15:31 ls_-l_.var.log.core
-rw-r--r--. 1 root root 1971 Sep 21 15:31 lvm_lvs_-v_-o_tags
-rw-r--r--. 1 root root 1322 Sep 21 15:31 lvm_pvs_-v_-o_all
-rw-r--r--. 1 root root  526 Sep 21 15:31 lvm_vgs_-v_-o_tags
-rw-r--r--. 1 root root 1162 Sep 21 15:31 nodectl_info
-rw-r--r--. 1 root root 1207 Sep 21 15:31 service_vdsmd_status
-rw-r--r--. 1 root root   27 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.bin.ls_-lR_.rhev.data-center
-rw-r--r--. 1 root root   42 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.usr.bin.tree_-l_.rhev.data-center
-rw-r--r--. 1 root root  537 Sep 21 15:31 
su_vdsm_-s_.usr.bin.python_.usr.share.vdsm.dumpStorageTable.pyc
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksInfo
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksStatuses
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllVmStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getDeviceList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsCapabilities
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVGList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_list

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63765/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 131: self.collectExtOutput("/sbin/fdisk -l")
Line 132: self.collectExtOutput("/usr/bin/iostat")
Line 133: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 134: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 135: self.collectExtOutput("/usr/sbin/nodectl info")
> I don't have /usr/sbin/nodectl over my f24 and centos7 .. should we run it 
it runs only over rhv-h. sos report ignores the command if it doesn't exist.
Line 136: 
Line 137: with closing(_connectToVdsm()) as cli:
Line 138: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 139: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63765/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 131: self.collectExtOutput("/sbin/fdisk -l")
Line 132: self.collectExtOutput("/usr/bin/iostat")
Line 133: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 134: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 135: self.collectExtOutput("/usr/sbin/nodectl info")
I don't have /usr/sbin/nodectl over my f24 and centos7 .. should we run it only 
over rhv-h?
Line 136: 
Line 137: with closing(_connectToVdsm()) as cli:
Line 138: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 139: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1:

* #1372093::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372093::OK, public bug
* Check Product::#1372093::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: collect 'nodectl info' output
..

sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/63765/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index dd3ae91..cc73faf 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -132,6 +132,7 @@
 self.collectExtOutput("/usr/bin/iostat")
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
+self.collectExtOutput("/usr/sbin/nodectl info")
 
 with closing(_connectToVdsm()) as cli:
 self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org