Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


sos: remove jsonrpcvdscli.connect parameters

patch https://gerrit.ovirt.org/#/c/62730/ added default value to
requestQueue parameter in jsonrpcvdscli.connect() function.
This patch removes the creation of requestQueue parameter when
connecting to jsonrpcvdscli

Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63728
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Nir Soffer 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1:

ping

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..

sos: remove jsonrpcvdscli.connect parameters

patch https://gerrit.ovirt.org/#/c/62730/ added default value to
requestQueue parameter in jsonrpcvdscli.connect() function.
This patch removes the creation of requestQueue parameter when
connecting to jsonrpcvdscli

Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/63728/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 5939d58..3a55ef9 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -53,12 +53,6 @@
 search = os.path.join(search, name)
 return module
 
-def _connectToVdsm():
-requestQueues = config.get("addresses", "request_queues")
-requestQueue = requestQueues.split(",")[0]
-return jsonrpcvdscli.connect(requestQueue=requestQueue)
-
-config = _importVdsmPylibModule("vdsm.config").config
 jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
 
 
@@ -133,7 +127,7 @@
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
 
-with closing(_connectToVdsm()) as cli:
+with closing(jsonrpcvdscli.connect()) as cli:
 self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
 self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
 self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")


-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org