Change in vdsm[master]: sourcerouting: make thread daemonic
Antoni Segura Puimedon has uploaded a new change for review. Change subject: sourcerouting: make thread daemonic .. sourcerouting: make thread daemonic The Python interpreter waits for non daemonic threads. The sourceRouteThread shouldn't keep the process waiting. Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M vdsm/supervdsmServer 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/22345/1 diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index f7b23ae..3f2cf85 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -407,8 +407,11 @@ log.debug(Started serving super vdsm object) -threading.Thread(target=sourceRouteThread.subscribeToInotifyLoop(), - name='sourceRoute').start() +_sourceRouteThread = threading.Thread( +target=sourceRouteThread.subscribeToInotifyLoop(), +name='sourceRoute') +_sourceRouteThread.daemon = True +_sourceRouteThread.start() # Python bug of thread.join() will block signal # http://bugs.python.org/issue1167930 -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6061/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6164/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Nir Soffer has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Nir Soffer has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: -Verified Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Assaf Muller has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Dan Kenigsberg has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Antoni Segura Puimedon has posted comments on this change. Change subject: sourcerouting: make thread daemonic .. Patch Set 1: Verified+1 Verified doing: localhost vdsm (9c35a65) # ip r 10.34.60.0/22 dev eth0 proto kernel scope link src 10.34.61.70 169.254.0.0/16 dev eth0 scope link metric 1004 default via 10.34.63.254 dev eth0 localhost vdsm (9c35a65) # ip rule 0: from all lookup local 32766: from all lookup main 32767: from all lookup default localhost vdsm (9c35a65) # vdsClient -s 0 addNetwork bridge=foo nics=eth2 bootproto=dhcp Done localhost vdsm (9c35a65) # ip rule 0: from all lookup local 32764: from all to 10.34.60.0/22 iif foo lookup 170015914 32765: from 10.34.60.0/22 lookup 170015914 32766: from all lookup main 32767: from all lookup default localhost vdsm (9c35a65) # ip route show table 32764 localhost vdsm (9c35a65) # ip route show table 170015914 10.34.60.0/22 via 10.34.60.170 dev foo default via 10.34.63.254 dev foo localhost vdsm (9c35a65) # service vdsmd stop Shutting down vdsm daemon: vdsm watchdog stop [ OK ] vdsm: Running run_final_hooks [ OK ] vdsm stop [ OK ] localhost vdsm (9c35a65) # service supervdsmd stop Shutting down supervdsm daemon: supervdsm watchdog stop[ OK ] supervdsm stop [ OK ] localhost vdsm (9c35a65) # -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourcerouting: make thread daemonic
Dan Kenigsberg has submitted this change and it was merged. Change subject: sourcerouting: make thread daemonic .. sourcerouting: make thread daemonic The Python interpreter waits for non daemonic threads. The sourceRouteThread shouldn't keep the process waiting. Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22345 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Assaf Muller amul...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/supervdsmServer 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Antoni Segura Puimedon: Verified Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45effe0d787c36564a1ae3eb45844c22ac2a2c36 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
