Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Nir Soffer has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Verified+1 I could not reproduce the problem described in the bug, but we believe that the original code is incorrect and that change is needed. Verifed by running the reconstruct master flow and upgrade storage domain version flow. -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: Remove invalid validation of stale meta data .. sp: Remove invalid validation of stale meta data When refreshing a storage pool, we used to validate the the metadata before refreshing the pool. This validation fail if the storage domain was just upgraded from old format where metadata was storaged on the medadata lv, to the new format keeping metadata in the lv tags. The validation is pefromed now after the refresh, ensuring that the metadata is correct after a successful refresh. Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Bug-Url: https://bugzilla.redhat.com/954169 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24568 Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ayal Baron: Looks good to me, but someone else must approve Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1293/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Allon Mureinik has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Reiterating myself: Nir, can you please verify so this can be merged? -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Allon Mureinik has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Nir, can you please verify so this can be merged? -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Allon Mureinik has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Federico Simoncelli has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Code-Review+2 This makes sense (until we'll be proven wrong on the field). -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Nir Soffer has uploaded a new change for review. Change subject: sp: Remove invalid validation of stale meta data .. sp: Remove invalid validation of stale meta data When refreshing a storage pool, we used to validate the the metadata before refreshing the pool. This validation fail if the storage domain was just upgraded from old format where metadata was storaged on the medadata lv, to the new format keeping metadata in the lv tags. The validation is pefromed now after the refresh, ensuring that the metadata is correct after a successful refresh. Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Bug-Url: https://bugzilla.redhat.com/954169 Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/24568/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index d6d0715..5720b17 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -872,8 +872,8 @@ pool = self.getPool(spUUID) try: -self.validateSdUUID(msdUUID) pool.refresh(msdUUID, masterVersion) +self.validateSdUUID(msdUUID) except: self._disconnectPool(pool, pool.id, False) raise -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7279/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6381/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7165/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6381/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7289/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Remove invalid validation of stale meta data
Ayal Baron has posted comments on this change. Change subject: sp: Remove invalid validation of stale meta data .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ab243a03f23b1155867f2eeec98b1481b5b72d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
