Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5815/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: Verified+1 Commit message change. -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Nir Soffer has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: move validatePoolSD in the StoragePool class .. sp: move validatePoolSD in the StoragePool class It's the StoragePool duty to validate if an operation cannot be accomplished because the storage domain is not part of the pool. For consistency with the other pool Vms API the sdUUID argument in the getVmsList method is now mandatory (it is set by the HSM public method). Change-Id: I75f0245ec5449d57431df7055be401d73975312b Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21787 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 16 insertions(+), 24 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Dan Kenigsberg has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 7: (1 comment) Minor optimization that can wait for a later patch. http://gerrit.ovirt.org/#/c/21787/7/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1011: Line 1012: dom = sdCache.produce(sdUUID) Line 1013: Line 1014: # Avoid detach domains if not owned by pool Line 1015: self.validatePoolSD(sdUUID) Shouldn't this be better done before the produce() call? Line 1016: self.validateAttachedDomain(dom) Line 1017: Line 1018: if sdUUID == self.masterDomain.sdUUID: Line 1019: raise se.CannotDetachMasterStorageDomain(sdUUID) -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: (1 comment) File vdsm/storage/hsm.py Line 1343: :type sdUUID: UUID Line 1344: :param options: ? Line 1345: Line 1346: pool = self.getPool(spUUID) Line 1347: if not sdUUID or sdUUID != sd.BLANK_UUID: mistake Line 1348: sdUUID = pool.masterDomain.sdUUID Line 1349: vars.task.getSharedLock(STORAGE, sdUUID) Line 1350: vms = pool.getVmsList(sdUUID) Line 1351: return dict(vmlist=vms) -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: Verified+1 I have been running with this for some time now. It also doesn't seem so risky. -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Nir Soffer has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (2 comments) Looks good please address the question about the api change. Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: Please add note about removing the optional sdUUID from getVmList and why it was removed. Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b File vdsm/storage/sp.py Line 1938 Line 1939 Line 1940 Line 1941 Line 1942 Do we use this option, getting the vm list from the master domain instead of some sdUUID? -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (2 comments) Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: It was just moved. Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b File vdsm/storage/sp.py Line 1938 Line 1939 Line 1940 Line 1941 Line 1942 No idea. But the behavior has been moved to hsm.py for consistency. -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Nir Soffer has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (1 comment) Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: So add note about this change? Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5746/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6552/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5947/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5152/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6040/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4952/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5843/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 3: (2 comments) File vdsm/storage/hsm.py Line 1343: :type sdUUID: UUID Line 1344: :param options: ? Line 1345: Line 1346: pool = self.getPool(spUUID) Line 1347: if not sdUUID or sdUUID != sd.BLANK_UUID: s/!=/==/ Line 1348: sdUUID = pool.masterDomain.sdUUID Line 1349: vars.task.getSharedLock(STORAGE, sdUUID) Line 1350: vms = pool.getVmsList(sdUUID) Line 1351: return dict(vmlist=vms) File vdsm/storage/sp.py Line 1054: dom = sdCache.produce(sdUUID) Line 1055: Line 1056: # Avoid detach domains if not owned by pool Line 1057: self.validatePoolSD(sdUUID) Line 1058: self.validateAttachedDomain(dom) validateAttachedDomain starts with a call to validatePoolSD... ? Line 1059: Line 1060: if sdUUID == self.masterDomain.sdUUID: Line 1061: raise se.CannotDetachMasterStorageDomain(sdUUID) Line 1062: -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has uploaded a new change for review. Change subject: sp: move validatePoolSD in the StoragePool class .. sp: move validatePoolSD in the StoragePool class It's the StoragePool duty to validate if an operation cannot be accomplished because the storage domain is not part of the pool. Change-Id: I75f0245ec5449d57431df7055be401d73975312b Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 16 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/21787/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 0836777..231ea72 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -665,7 +665,6 @@ size = math.ceil(size / 2 ** 20) pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) pool.extendVolume(sdUUID, volumeUUID, size, isShuttingDown) @public @@ -748,7 +747,6 @@ vars.task.getSharedLock(STORAGE, sdUUID) # We need to let the domain to extend itself pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) dmDevs = tuple(os.path.join(devicemapper.DMPATH_PREFIX, guid) for guid in guids) pool.extendSD(sdUUID, dmDevs, force) @@ -797,7 +795,6 @@ vars.task.getExclusiveLock(STORAGE, spUUID) vars.task.getExclusiveLock(STORAGE, sdUUID) pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) pool.detachSD(sdUUID) @public @@ -1188,7 +1185,6 @@ vars.task.getExclusiveLock(STORAGE, spUUID) vars.task.getExclusiveLock(STORAGE, sdUUID) pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) pool.deactivateSD(sdUUID, msdUUID, masterVersion) @public @@ -1252,7 +1248,6 @@ vars.task.getSharedLock(STORAGE, sdUUID) pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) pool.setVolumeDescription(sdUUID, imgUUID, volUUID, description) @public @@ -1276,7 +1271,6 @@ vars.task.getSharedLock(STORAGE, sdUUID) pool = self.getPool(spUUID) -pool.validatePoolSD(sdUUID) pool.setVolumeLegality(sdUUID, imgUUID, volUUID, legality) @public @@ -1301,9 +1295,7 @@ vars.task.getSharedLock(STORAGE, spUUID) pool = self.getPool(spUUID) -if sdUUID and sdUUID != sd.BLANK_UUID: -pool.validatePoolSD(sdUUID) -else: +if not sdUUID or sdUUID == sd.BLANK_UUID: sdUUID = pool.masterDomain.sdUUID vmUUIDs = [vmDesc['vm'] for vmDesc in vmList] @@ -1329,9 +1321,7 @@ vars.task.getSharedLock(STORAGE, spUUID) pool = self.getPool(spUUID) -if sdUUID and sdUUID != sd.BLANK_UUID: -pool.validatePoolSD(sdUUID) -else: +if not sdUUID or sdUUID == sd.BLANK_UUID: sdUUID = pool.masterDomain.sdUUID vars.task.getExclusiveLock(STORAGE, %s_%s % (vmUUID, sdUUID)) pool.removeVM(vmUUID=vmUUID, sdUUID=sdUUID) @@ -1351,9 +1341,7 @@ :param options: ? pool = self.getPool(spUUID) -if sdUUID and sdUUID != sd.BLANK_UUID: -pool.validatePoolSD(sdUUID) -else: +if not sdUUID or sdUUID != sd.BLANK_UUID: sdUUID = pool.masterDomain.sdUUID vars.task.getSharedLock(STORAGE, sdUUID) vms = pool.getVmsList(sdUUID) @@ -1379,7 +1367,6 @@ pool = self.getPool(spUUID) if sdUUID and sdUUID != sd.BLANK_UUID: -pool.validatePoolSD(sdUUID) # Only backup domains are allowed in this path self.validateBackupDom(sdUUID) else: @@ -2688,7 +2675,6 @@ vars.task.getSharedLock(STORAGE, sdUUID) pool = self.getPool(dom.getPools()[0]) -pool.validatePoolSD(sdUUID) pool.setSDDescription(dom, description) @public diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 37dcec8..11d8d00 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1062,6 +1062,7 @@ dom = sdCache.produce(sdUUID) # Avoid detach domains if not owned by pool +self.validatePoolSD(sdUUID) self.validateAttachedDomain(dom) if sdUUID == self.masterDomain.sdUUID: @@ -1148,6 +1149,7 @@ :param masterVersion: new master storage domain version +self.validatePoolSD(sdUUID) self.log.info(sdUUID=%s spUUID=%s newMsdUUID=%s, sdUUID, self.spUUID, newMsdUUID) domList = self.getDomains() @@ -1328,6 +1330,7 @@ If sdUUID is None, the update is on the pool, and therefore the master domain will be updated. +self.validatePoolSD(sdUUID) self.log.info(spUUID=%s sdUUID=%s,
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5816/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
