Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-20 Thread Federico Simoncelli 
Federico Simoncelli has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 3: Verified+1

Verified: createStoragePool, several attach/detachStorageDomain, 
destroyStoragePool, reconstructMaster and masterMigrate.

-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-20 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: sp: receive domains map in connectStoragePool
..


sp: receive domains map in connectStoragePool

This patch adds the support for the StoragePoolMemoryBackend and
the required support in the HSM class to instantiate it and to
live upgrade from older backends.

The connectStroagePool API has been updated to receive the extra
domainsMap dictionary that triggers the use of the new backend.

Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21427
Reviewed-by: Ayal Baron aba...@redhat.com
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/spbackends.py
M vdsm_api/vdsmapi-schema.json
5 files changed, 151 insertions(+), 17 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Federico Simoncelli: Verified



-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-18 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-17 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5945/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6838/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6733/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_storage_functional_tests/21/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-15 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 2:

(4 comments)

http://gerrit.ovirt.org/#/c/21427/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1006: 
Line 1007: if domainsMap is None:
Line 1008: if not isinstance(pool.getBackend(),
Line 1009:   spbackends.StoragePoolMetaBackend):
Line 1010: raise se.StoragePoolConnected('Cannot downgrade pool 
backend')
1. why is this hsm logic and not pool logic?
2. shouldn't the backend say whether it requires domainsMap or not?
e.g.

if domainsMap is None and pool.getBackend.requiresDomainsMap()
   raise...
else if domainsMap and not pool.getBackend.requiresDomainsMap():
   upgrade

pool.refresh()
Line 1011: else:
Line 1012: if isinstance(pool.getBackend(), 
spbackends.StoragePoolNew):
Line 1013: pool.getBackend().setDomainsMap(domainsMap)
Line 1014: else:


Line 1054: 
Line 1055: pool = sp.StoragePool(spUUID, self.domainMonitor, 
self.taskMng)
Line 1056: 
Line 1057: if domainsMap is None:
Line 1058: 
pool.setBackend(spbackends.StoragePoolMetaBackend(pool))
why is this not in pool __init__?
Line 1059: else:
Line 1060: pool.setBackend(
Line 1061: spbackends.StoragePoolNew(pool, masterVersion, 
domainsMap))
Line 1062: 


http://gerrit.ovirt.org/#/c/21427/2/vdsm/storage/spbackends.py
File vdsm/storage/spbackends.py:

Line 326: futureMaster.releaseClusterLock()
Line 327: 
Line 328: 
Line 329: @secured
Line 330: class StoragePoolNew(object):
StoragePoolMemoryBackend ?
And rename StoragePoolMetaBackend to StoragePoolDiskBackend ?
Line 331: 
Line 332: __slots__ = ('pool', 'masterVersion', 'domainsMap')
Line 333: 
Line 334: log = logging.getLogger('Storage.StoragePoolNew')


Line 332: __slots__ = ('pool', 'masterVersion', 'domainsMap')
Line 333: 
Line 334: log = logging.getLogger('Storage.StoragePoolNew')
Line 335: 
Line 336: def __init__(self, pool, masterVersion, domainsMap):
what is the APi that a backend needs to implement?
e.g. is reconstructMaster required, and if so, why isn't it here?
Line 337: self.pool = weakref.proxy(pool)
Line 338: self.masterVersion = masterVersion
Line 339: self.setDomainsMap(domainsMap)
Line 340: 


-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-09 Thread Federico Simoncelli 
Federico Simoncelli has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 2:

(2 comments)


Commit Message
Line 4: Commit: Federico Simoncelli fsimo...@redhat.com
Line 5: CommitDate: 2014-01-08 08:52:01 -0500
Line 6: 
Line 7: sp: receive domains map in connectStoragePool
Line 8: 
I know.
Line 9: Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d



File vdsm/storage/spbackends.py
Line 326: futureMaster.releaseClusterLock()
Line 327: 
Line 328: 
Line 329: @secured
Line 330: class StoragePoolNew(object):
Ah I forgot to come up with a better name for this. Please suggest.
Line 331: 
Line 332: __slots__ = ('pool', 'masterVersion', 'domainsMap')
Line 333: 
Line 334: log = logging.getLogger('Storage.StoragePoolNew')


-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: receive domains map in connectStoragePool

2014-01-08 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: sp: receive domains map in connectStoragePool
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6641/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5748/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6554/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches