Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: spec: Require newer qemu version for el7
..


spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
Reviewed-on: https://gerrit.ovirt.org/50435
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-by: Sandro Bonazzola 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 4:

* #1279052::Update tracker: OK
* Set MODIFIED::bug 1279052#1279052IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Verified+1

Verified on CentOS/EL.

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Code-Review+1

The new qemu-kvm-ev should be available on all supported repositories.

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3:

We still don't have this build for qemu-kvm-ev. Sandro is working on it, and 
Daniel should be able to verify once it's pushed to oVirt's repo.

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3:

Sandro?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Code-Review+2

Daniel, can you verify that vdsm can be install on rhel and centos with this 
patch?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

@Sandro - this looks like a pretty nasty bug in qemu. Any chance of getting 
qemu-kvm-rhev-2.3.0-31.el7_2.4 built for qemu-kvm-ev and available in our 
(oVirt's) repo?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: spec: Require newer qemu version for el7
..

spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

We don't require the package on CentOS, since it is not available yet.

Bug-Url: https://bugzilla.redhat.com/1279052

Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/50435/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index d7b6ae8..4ca82cb 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -234,9 +234,15 @@
 %endif
 
 %if 0%{?rhel}
+%if 0%{?centos}
+# TODO: Remove when qemu-kvm-rhev 2.3.0-31.el7_2.4 is available
 Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
 Requires: qemu-img-rhev >= 10:2.3.0-13.el7
 %else
+Requires: qemu-kvm-rhev >= 10:2.3.0-31.el7_2.4
+Requires: qemu-img-rhev >= 10:2.3.0-31.el7_2.4
+%endif # centos
+%else
 Requires: qemu-kvm >= 2:2.3.0
 Requires: qemu-img >= 2:2.3.0
 %endif # rhel


-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Code-Review-1

+1 for the concept
-1 for the implementation because as Allon pointed out in 
d60db71036d4c47b71fc519c2497ac4be7ba70e2
since oVirt projects provides -ev package, we don't need the split anymore. Or 
do we?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

@Allon - do we need the separation between RHEL and CentOS when bumping qemu 
version?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Code-Review-1

I agree with Francesco, we just merged https://gerrit.ovirt.org/49974, 
promising that:

Since qemu-kvm-ev-2.3 is now build by the oVirt project, there's no
reason to keep the cumbersome separation between RHEL and CentOS
requirements.

So why do we need to return the cumbersome separation?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

Fred, can you test this?

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Verified+1

[root@venus-vdsa ~]# rpm -qa | grep qemu
qemu-img-rhev-2.3.0-31.el7.x86_64
qemu-kvm-rhev-2.3.0-31.el7.x86_64
qemu-kvm-tools-rhev-2.3.0-31.el7_2.1.x86_64
ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch
qemu-kvm-common-rhev-2.3.0-31.el7.x86_64
libvirt-daemon-driver-qemu-1.2.17-13.el7.x86_64
[root@venus-vdsa ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.2 (Maipo)
[root@venus-vdsa ~]#

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

* #1271173::Update tracker: OK
* Set MODIFIED::bug 1271173#1271173OK

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Require newer qemu version for el7
..


spec: Require newer qemu version for el7

Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty map, which
may cause live merge to hang when merging large snapshots. QEMU 2.3.0-13
adds yield points, which prevents the aforementioned hanging.

We don't require the package on CentOS, since it is not available yet.

Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1271173
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/49009
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

* #1271173::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271173::OK, public bug
* Check Product::#1271173::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[frolland]

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49009

to review the following change.

Change subject: spec: Require newer qemu version for el7
..

spec: Require newer qemu version for el7

Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty map, which
may cause live merge to hang when merging large snapshots. QEMU 2.3.0-13
adds yield points, which prevents the aforementioned hanging.

We don't require the package on CentOS, since it is not available yet.

Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1271173
Signed-off-by: Fred Rolland 
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/49009/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index bcf3358..469ade0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -228,9 +228,15 @@
 %endif
 
 %if 0%{?rhel}
+%if 0%{?centos}
+# TODO: Remove when qemu-kvm-rhev 2.3.0-13 is available
 Requires: qemu-kvm-rhev >= 10:2.1.2-23.el7_1.2
 Requires: qemu-img-rhev >= 10:2.1.2-23.el7_1.2
 %else
+Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
+Requires: qemu-img-rhev >= 10:2.3.0-13.el7
+%endif # centos
+%else
 Requires: qemu-kvm >= 2:2.1.3-11
 Requires: qemu-img >= 2:2.1.3-11
 %endif # rhel


-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches