Change in vdsm[master]: spec: vdsm-hook-sriov on el6 should not require non-existing...

2013-08-01 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: spec: vdsm-hook-sriov on el6 should not require non-existing rpm
..


Patch Set 2: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/17554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dead Horse deadhorseconsult...@gmail.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: vdsm-hook-sriov on el6 should not require non-existing...

2013-08-01 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: vdsm-hook-sriov on el6 should not require non-existing rpm
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3669/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3585/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2778/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dead Horse deadhorseconsult...@gmail.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: vdsm-hook-sriov on el6 should not require non-existing...

2013-08-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: vdsm-hook-sriov on el6 should not require non-existing rpm
..


spec: vdsm-hook-sriov on el6 should not require non-existing rpm

As reported by a dead horse, el6 does not carry
libvirt-daemon-driver-nodedev so the said hook should not require this
subrpm. Since it the rpm hook is meaningful only when vdsm is installed,
and el6's vdsm requires al libvirt, we need no special requirement
there.

Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/17554
Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com
Reviewed-by: Dead Horse deadhorseconsult...@gmail.com
Tested-by: Dead Horse deadhorseconsult...@gmail.com
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dead Horse: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dead Horse deadhorseconsult...@gmail.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: vdsm-hook-sriov on el6 should not require non-existing...

2013-08-01 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: spec: vdsm-hook-sriov on el6 should not require non-existing rpm
..


Patch Set 2: Looks good to me, approved

Thanks, guys.

-- 
To view, visit http://gerrit.ovirt.org/17554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dead Horse deadhorseconsult...@gmail.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches