Change in vdsm[master]: stats: return domain lockspace status

2013-10-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: stats: return domain lockspace status
..


stats: return domain lockspace status

Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/20099
Reviewed-by: Ayal Baron aba...@redhat.com
Reviewed-by: Sergey Gotliv sgot...@redhat.com
Tested-by: Sandro Bonazzola sbona...@redhat.com
---
M vdsm/sampling.py
M vdsm/storage/hsm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Sandro Bonazzola: Verified
  Federico Simoncelli: Verified
  Sergey Gotliv: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-11 Thread sgotliv 
Sergey Gotliv has posted comments on this change.

Change subject: stats: return domain lockspace status
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-11 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: stats: return domain lockspace status
..


Patch Set 1: Verified+1

Verified with both:
 - http://gerrit.ovirt.org/19762
 - http://gerrit.ovirt.org/19867

rebased on master.

-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-10 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: stats: return domain lockspace status
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4917/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4032/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4842/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-10 Thread fsimonce 
Federico Simoncelli has posted comments on this change.

Change subject: stats: return domain lockspace status
..


Patch Set 1: Verified+1

The lockspace status is correctly reported (tested for domains version 3 and 0 
ISO/Export). I also verified the behavior blocking and restoring the connection.

-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-10 Thread fsimonce 
Federico Simoncelli has uploaded a new change for review.

Change subject: stats: return domain lockspace status
..

stats: return domain lockspace status

Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M vdsm/sampling.py
M vdsm/storage/hsm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/20099/1

diff --git a/vdsm/sampling.py b/vdsm/sampling.py
index dd446c4..0a0ab9c 100644
--- a/vdsm/sampling.py
+++ b/vdsm/sampling.py
@@ -518,11 +518,14 @@
 self._imagesStatus._refreshStorageDomains()
 now = time.time()
 for sd, d in self._imagesStatus.storageDomains.iteritems():
-stats['storageDomains'][sd] = {'code': d['code'],
-   'delay': d['delay'],
-   'lastCheck': d['lastCheck'],
-   'valid': d['valid'],
-   'version': d['version']}
+stats['storageDomains'][sd] = {
+'code': d['code'],
+'delay': d['delay'],
+'lastCheck': d['lastCheck'],
+'valid': d['valid'],
+'version': d['version'],
+'acquired': d['acquired'],
+}
 stats['elapsedTime'] = int(now - self.startTime)
 if len(self._samples)  2:
 return stats
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 5f14468..5783728 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3643,6 +3643,8 @@
 'delay': str(domStatus.readDelay),
 'valid': (domStatus.error is None),
 'version': domStatus.version,
+# domStatus.hasHostId can also be None
+'acquired': domStatus.hasHostId is True,
 },
 
 'disktotal': disktotal,
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index be53ada..ab5c464 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1449,12 +1449,16 @@
 #
 # @version:Indicates the Storage Domain version
 #
+# @acquired:   Indicates if the lockspace on the Storage Domain has been
+#  acquired and therefore if it's possible to run (sanlock)
+#  protected VMs
+#
 # Since: 4.10.0
 # XXX: Add an enum for return codes and their meanings
 ##
 {'type': 'StorageDomainVitals',
  'data': {'code': 'int', 'delay': 'float', 'lastCheck': 'float',
-  'valid': 'bool', 'version': 'int'}}
+  'valid': 'bool', 'version': 'int', 'acquired': 'bool'}}
 
 ##
 # @PathStats:


-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stats: return domain lockspace status

2013-10-10 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: stats: return domain lockspace status
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/20099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches