Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tc: Fix make rpm for filter tests.
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/636/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: tc: Fix make rpm for filter tests.
..


Patch Set 2: (1 inline comment)


File tests/Makefile.am
Line 50: 
Line 51: dist_noinst_DATA = \
Line 52:run_tests_local.sh \
Line 53:cpu_info.out \
Line 54:tc_filter_show.out \
was this intentional to have this file both on noinst and in vdsmtests?

I now notice that we have more of the same problem:

  glob_1c60971a-8647-44ac-ae33-6520887f8843.out

and other files are missing from vdsm-tests rpm.
Line 55:route_info.out \
Line 56:glob_1c60971a-8647-44ac-ae33-6520887f8843.out \
Line 57:lvs_3386c6f2-926f-42c4-839c-38287fac8998.out
Line 58: 


--
To view, visit http://gerrit.ovirt.org/7442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: tc: Fix make rpm for filter tests.
..


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/7442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: tc: Fix make rpm for filter tests.
..


Patch Set 3: Looks good to me, approved

Thanks!

--
To view, visit http://gerrit.ovirt.org/7442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tc: Fix make rpm for filter tests.

2012-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: tc: Fix make rpm for filter tests.
..


tc: Fix make rpm for filter tests.

Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M tests/Makefile.am
M tests/tcTests.py
M vdsm.spec.in
3 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb3cee09f16202f4e69728b5aaf36e54f39e8d82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches