Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/614/ : FAILURE -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 3: Fails; I would prefer that you didn't submit this (1 inline comment) On running tcTests, this patch breaks them. File vdsm/tc.py Line 34: Exception.__init__(self, self.errCode, self.message, self.command) Line 35: Line 36: def setPortMirroring(network, target): Line 37: qdisc_replace_ingress(network) Line 38: add_filter(network, target, ':') Shouldn't this patch change this line's method as well? Line 39: qdisc_replace_parent(network) Line 40: devid = qdisc_get_devid(network) Line 41: add_filter(network, target, devid) Line 42: set_promisc(network, True) -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/628/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Dan Kenigsberg has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Dan Kenigsberg has submitted this change and it was merged. Change subject: tc: rename qdisc_replace_prio() .. tc: rename qdisc_replace_prio() This funciton replaces a PRIO qdisc. Let us call it accordingly Change-Id: If9628244a144ece23b793e260e077dcee9698eba Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M tests/tcTests.py M vdsm/tc.py 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/597/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 2: Looks good to me, but someone else must approve It is more appropriate indeed. -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: rename qdisc_replace_prio()
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/499/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
