Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM

2017-07-27 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: testrunner: mock vdsm.common.constants.P_VDSM
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM

2017-07-27 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/79911 )

Change subject: testrunner: mock vdsm.common.constants.P_VDSM
..


testrunner: mock vdsm.common.constants.P_VDSM

As long as we keep vdsm.constants as proxy to vdsm.common.constants, we
need to keep them align also when mocked.

Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Signed-off-by: Dan Kenigsberg 
---
M tests/testrunner.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM

2017-07-27 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: testrunner: mock vdsm.common.constants.P_VDSM
..

testrunner: mock vdsm.common.constants.P_VDSM

As long as we keep vdsm.constants as proxy to vdsm.common.constants, we
need to keep them align also when mocked.

Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Signed-off-by: Dan Kenigsberg 
---
M tests/testrunner.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/79911/1

diff --git a/tests/testrunner.py b/tests/testrunner.py
index e4dab3b..7586158 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -49,6 +49,7 @@
   "instead of installed ones.\n")
 if findRemove(sys.argv, "--local-modules"):
 from vdsm import constants
-constants.P_VDSM = "../vdsm/"
+from vdsm.common import common_constants
+common_constants.P_VDSM = constants.P_VDSM = "../vdsm/"
 
 testlib.run()


-- 
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org