Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has submitted this change and it was merged. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. tests: Share FakeScheduler and use in TestCopyDataDIV The FakeScheduler class in jobsTests.py is also needed by TestCopyDataDIV. Introduce a new fakelib.py module for sharing fakes of top-level vdsm lib objects. The copy_data job now relies on the jobs module being properly initialized with a Scheduler (for autodelete). Add setUp and tearDown methods to the tests to properly manage this using the newly available FakeScheduler. Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/64228 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Tested-by: Nir Soffer --- M tests/Makefile.am A tests/fakelib.py M tests/jobsTests.py M tests/storage_sdm_copy_data_test.py 4 files changed, 42 insertions(+), 11 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
gerrit-hooks has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: Verified+1 Tests pass, looks verified. -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
gerrit-hooks has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
gerrit-hooks has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
