Change in vdsm[master]: tests: Test both ssl and m2c

[nsoffer]

Nir Soffer has restored this change.

Change subject: tests: Test both ssl and m2c
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Test both ssl and m2c

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Test both ssl and m2c

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: tests: Test both ssl and m2c
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Test both ssl and m2c

[nsoffer]

Nir Soffer has restored this change.

Change subject: tests: Test both ssl and m2c
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: tests: Test both ssl and m2c
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 3: Verified+1

Verified locally by running the tests with and without m2crypto available on 
the system.

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py
File tests/stompTests.py:

Line 59:for impl in ['ssl', 'm2c']
Line 60:for size in [1, 1024, 4096, 16384]])
Line 61: def test_echo(self, size, impl):
Line 62: data = dummyTextGenerator(size)
Line 63: sslctx = integration.get_context(impl)
> Done
It is ok to set sslctx to None than ssl dispatcher is not accessed by the 
server code.
Line 64: with MonkeyPatchScope([(protocoldetector, 
'SSLHandshakeDispatcher',
Line 65: integration.get_dispatcher(impl))]):
Line 66: with constructAcceptor(self.log, sslctx,
Line 67:_SampleBridge()) as acceptor:


-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/48823/2/tests/integration/__init__.py
File tests/integration/__init__.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from . import m2chelper, sslhelper
> Can you import m2chelper if M2Crypto is not installed (e.g. on debian)?
Good, point will fix it.
Line 21: from vdsm import m2cutils, sslutils
Line 22: 
Line 23: 
Line 24: def get_context(impl):


https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py
File tests/stompTests.py:

Line 55: @expandPermutations
Line 56: class StompTests(TestCaseBase):
Line 57: 
Line 58: @permutations([[size, impl]
Line 59:for impl in ['ssl', 'm2c']
> Use [None, 'ssl', 'm2c']
will add None as well.
Line 60:for size in [1, 1024, 4096, 16384]])
Line 61: def test_echo(self, size, impl):
Line 62: data = dummyTextGenerator(size)
Line 63: sslctx = integration.get_context(impl)


Line 59:for impl in ['ssl', 'm2c']
Line 60:for size in [1, 1024, 4096, 16384]])
Line 61: def test_echo(self, size, impl):
Line 62: data = dummyTextGenerator(size)
Line 63: sslctx = integration.get_context(impl)
> And:
Done
Line 64: with MonkeyPatchScope([(protocoldetector, 
'SSLHandshakeDispatcher',
Line 65: integration.get_dispatcher(impl))]):
Line 66: with constructAcceptor(self.log, sslctx,
Line 67:_SampleBridge()) as acceptor:


-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

(1 comment)

Much nicer! but we need also to test no ssl.

https://gerrit.ovirt.org/#/c/48823/2/tests/integration/__init__.py
File tests/integration/__init__.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from . import m2chelper, sslhelper
Can you import m2chelper if M2Crypto is not installed (e.g. on debian)?
Line 21: from vdsm import m2cutils, sslutils
Line 22: 
Line 23: 
Line 24: def get_context(impl):


-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py
File tests/stompTests.py:

Line 55: @expandPermutations
Line 56: class StompTests(TestCaseBase):
Line 57: 
Line 58: @permutations([[size, impl]
Line 59:for impl in ['ssl', 'm2c']
Use [None, 'ssl', 'm2c']
Line 60:for size in [1, 1024, 4096, 16384]])
Line 61: def test_echo(self, size, impl):
Line 62: data = dummyTextGenerator(size)
Line 63: sslctx = integration.get_context(impl)


Line 59:for impl in ['ssl', 'm2c']
Line 60:for size in [1, 1024, 4096, 16384]])
Line 61: def test_echo(self, size, impl):
Line 62: data = dummyTextGenerator(size)
Line 63: sslctx = integration.get_context(impl)
And:

sslctx = integration.get_context(impl) if impl else None
dispatcher = integration.get_dispatcher(impl) if impl else None
Line 64: with MonkeyPatchScope([(protocoldetector, 
'SSLHandshakeDispatcher',
Line 65: integration.get_dispatcher(impl))]):
Line 66: with constructAcceptor(self.log, sslctx,
Line 67:_SampleBridge()) as acceptor:


-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2: Code-Review-1

still integration tests need fixing but stompTests are running OK.

-1 for visibility

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test both ssl and m2c

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
..


Patch Set 2:

Interesting my pyflakes did not complain about it. Will fix the build as well.

-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches