Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 3: Verified+1

Verified with 'make check'.  New function isn't being called yet.

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: tests: add FakeSanlock.init_resource
..


tests: add FakeSanlock.init_resource

init_resource is called by VolumeMetadata.newVolumeLease.  When unit
testing we use a mocked sanlock which does not yet have this method.
Add a stub function that does nothing to allow tests to work.

Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/49542
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/testrunner.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 3: Continuous-Integration+1

CI not need for this change.

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-01 Thread alitke 
Adam Litke has uploaded a new change for review.

Change subject: tests: add FakeSanlock.init_resource
..

tests: add FakeSanlock.init_resource

Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Signed-off-by: Adam Litke 
---
M tests/testrunner.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/49542/1

diff --git a/tests/testrunner.py b/tests/testrunner.py
index 7e68aaa..b37902e 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -52,6 +52,9 @@
 HOST_FAIL = 4
 HOST_DEAD = 5
 
+def init_resource(self, sdUUID, volUUID, lockDisk):
+pass
+
 
 sys.modules.update({'sanlock': FakeSanlock()})
 


-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-01 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: add FakeSanlock.init_resource
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ec7d516dc77e318a1c2d4c10bf49ccfdc5098b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches