Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Francesco Romani has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 5: Verified+1 Code-Review+1 looks good to me and it is also a step in the good direction. Tested the following: * tests OK * virtTests OK * running VDSM machine got up OK * running VDM machine suspended and resumed OK -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. vdsm: Replaced all too generic except: handlers in vm.py Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/17740 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Tested-by: Francesco Romani from...@redhat.com --- M vdsm/vm.py 1 file changed, 36 insertions(+), 36 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6605/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6518/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 3: Code-Review+2 Toni, I recall no reason to catch baseExceptions. After this patch, the exceptions are still too generic... But let us take this as a first step. -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 3: Vinzenz, pleasw verify that migration still flies. -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3930/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2868/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3676/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2869/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 2: Code-Review+1 Owners of the methods should make sure that we do not need to catch baseExceptions, and comment otherwise. -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
