Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Joey Boggs has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, approved Thanks, Joey Douglas. -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. vdsm-upgrade: use python scripts from ovirtnode Replace /usr/libexec/ovirt-config-boot call from deployUtil._logExec to the newer python scripts from ovirtnode. Tested: * Installed ovirt-node 2.5.0-2.0 (upgrading to: 2.5.1-1.0) * mkdir /data/updates * Copied 2.5 image to /data/updates/ovirt-node-image.iso * mount -o loop /data/updates/ovirt-node-image.iso /live * Update in /etc/vdsm-reg/vdsm-reg.conf upgrade_mount_point=/live * service vdsm-reg restart * /usr/share/vdsm-reg/vdsm-upgrade * reboot Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm_reg/vdsm-reg.conf.in M vdsm_reg/vdsm-upgrade 2 files changed, 9 insertions(+), 17 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Joey Boggs: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/598/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) File vdsm_reg/vdsm-reg.conf.in Line 14: #The registrtion uri Line 15: vdc_reg_uri=/OvirtEngineWeb/register Line 16: #Upgrade settings Line 17: upgrade_iso_file=@VDSMUPGRADEDIR@/ovirt-node-image.iso Line 18: upgrade_mount_point=/live is this change intentional? it is undocumented. Line 19: # registration ticket -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Joey Boggs has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 4: (1 inline comment) File vdsm_reg/vdsm-reg.conf.in Line 14: #The registrtion uri Line 15: vdc_reg_uri=/OvirtEngineWeb/register Line 16: #Upgrade settings Line 17: upgrade_iso_file=@VDSMUPGRADEDIR@/ovirt-node-image.iso Line 18: upgrade_mount_point=/live Yes, The Install module expects the iso to be mounted at /live. Line 19: # registration ticket -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 3: (2 inline comments) I need to execute new tests, ASAP I will update here. File vdsm_reg/vdsm-upgrade Line 15: import logging.config Line 16: from time import strftime Line 17: from config import config Line 18: import deployUtil Line 19: from ovirtnode.install import * Sure, new patch will fix that. Line 20: Line 21: VDSM_REG_CONF_FILE = '/etc/vdsm-reg/vdsm-reg.conf' Line 22: VDSM_CONF_FILE = '/etc/vdsm/vdsm.conf' Line 23: log_filename = '/var/log/vdsm-reg/vds_bootstrap_upgrade.'+strftime(%Y%m%d_%H%M%S)+'.log' Line 88: def doUpgrade(config): Line 89: fReturn = True Line 90: Line 91: install = Install() Line 92: if install.ovirt_boot_setup(): looking the code, I see it's inside a try. Line 93: msg = BSTRAP component='doUpgrade' status='OK' message='Upgrade Succeeded. Rebooting'/ Line 94: print (msg) Line 95: logging.debug(msg) Line 96: else: -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments) File vdsm_reg/vdsm-upgrade Line 15: import logging.config Line 16: from time import strftime Line 17: from config import config Line 18: import deployUtil Line 19: from ovirtnode.install import * in many cultures, `import *` is considered rude. could you import only what you need? Line 20: Line 21: VDSM_REG_CONF_FILE = '/etc/vdsm-reg/vdsm-reg.conf' Line 22: VDSM_CONF_FILE = '/etc/vdsm/vdsm.conf' Line 23: log_filename = '/var/log/vdsm-reg/vds_bootstrap_upgrade.'+strftime(%Y%m%d_%H%M%S)+'.log' Line 88: def doUpgrade(config): Line 89: fReturn = True Line 90: Line 91: install = Install() Line 92: if install.ovirt_boot_setup(): please make sure that exceptions are captured and logged by caller of doUpgrade() Line 93: msg = BSTRAP component='doUpgrade' status='OK' message='Upgrade Succeeded. Rebooting'/ Line 94: print (msg) Line 95: logging.debug(msg) Line 96: else: -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: (2 inline comments) File vdsm_reg/vdsm-upgrade Line 96 In fact, looks like /live is static in some parts of node code. I would keep getting the value from config file because in the future we maybe want to change this path. Line 96: if os.path.exists(/usr/libexec/ovirt-config-boot): ok, thanks! -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 2: Hi Joey, I have few questions about testing this change, I will need your help. Thanks! -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. vdsm-upgrade: use python scripts from ovirtnode Replace /usr/libexec/ovirt-config-boot call from deployUtil._logExec to the newer python scripts from ovirtnode. Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm_reg/vdsm-upgrade 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/7074/1 -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/336/ -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/336/ : ABORTED -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/337/ -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/337/ : ABORTED -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/338/ -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/338/ : ABORTED -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/339/ -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/339/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode
Joey Boggs has posted comments on this change. Change subject: vdsm-upgrade: use python scripts from ovirtnode .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) File vdsm_reg/vdsm-upgrade Line 96: if os.path.exists(/usr/libexec/ovirt-config-boot): ovirt-config-boot will eventually disappear after this patch is done, take this line out above Line 96 is strMountPoint a random directory? install.ovirt_boot_setup() will assume the new image is always at /live. If there's a reason to not always expect that directory we will need to adjust in ovirt node -- To view, visit http://gerrit.ovirt.org/7074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
