Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: vm: Remove unneeded fallback to blockRebase
..


vm: Remove unneeded fallback to blockRebase

If blockCopy was not supported, we fallback to blockRebase. This was
required when we supported libvirt < 1.2.9, but now we require 1.2.17
and we can remove this legacy code.

See https://libvirt.org/hvsupport.html for more info.

Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/64111
Reviewed-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Freddy Rolland 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 20 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Code-Review+2

looks good to me.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Verified+1

Tested on rhel 7.3 beta.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 1: Code-Review+1

Seems pretty straight forward, and it doesn't seem like you've left anything 
over.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: vm: Remove unneeded fallback to blockRebase
..

vm: Remove unneeded fallback to blockRebase

If blockCopy was not supported, we fallback to blockRebase. This was
required when we supported libvirt < 1.2.9, but now we require 1.2.17
and we can remove this legacy code.

Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Signed-off-by: Nir Soffer 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/64111/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c936987..7e33227 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3537,26 +3537,7 @@
 flags = (libvirt.VIR_DOMAIN_BLOCK_COPY_SHALLOW |
  libvirt.VIR_DOMAIN_BLOCK_COPY_REUSE_EXT)
 
-# TODO: Remove fallback when using libvirt >= 1.2.9.
-try:
-self._dom.blockCopy(drive.name, destxml, flags=flags)
-except libvirt.libvirtError as e:
-if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
-raise
-
-self.log.warning("blockCopy not supported, using blockRebase")
-
-base = drive.diskReplicate["path"]
-self.log.debug("Replicating drive %s to %s", drive.name, base)
-
-flags = (libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY |
- libvirt.VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT |
- libvirt.VIR_DOMAIN_BLOCK_REBASE_SHALLOW)
-
-if drive.diskReplicate["diskType"] == DISK_TYPE.BLOCK:
-flags |= libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY_DEV
-
-self._dom.blockRebase(drive.name, base, flags=flags)
+self._dom.blockCopy(drive.name, destxml, flags=flags)
 
 def _setDiskReplica(self, drive, replica):
 """


-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org