Change in vdsm[master]: vm: add the transient disk support
Ayal Baron has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Dan Kenigsberg has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 12: (1 comment) File vdsm/vm.py Line 412: class DRIVE_SHARED_TYPE: Line 413: NONE = none Line 414: EXCLUSIVE = exclusive Line 415: SHARED = shared Line 416: TRANSIENT = transient I find this as a bad API, but if Ayal insists, let's take it. Line 417: Line 418: @classmethod Line 419: def getAllValues(cls): Line 420: # TODO: use introspection -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4913/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4028/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4838/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 13: Verified+1 The only part affected by the rebase is the service restart. I re-verified both the transient dir creation and cleanup. -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: add the transient disk support .. vm: add the transient disk support A transient disk is a temporary qcow layer based on a (usually internal) volume that is attached to a VM in read-write mode. All changes stored in the transient disk will be lost as soon as the disk is hot-unplugged or when the VM exits. Its primary use is to access in read-write mode a snapshot (read-only volume). Libvirt doesn't support transient disks yet, hence this patch includes also all the required parts to fill that gap. Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Signed-off-by: Deepak C Shetty deepa...@linux.vnet.ibm.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/18326 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/vdsmd_init_common.sh.in M lib/vdsm/config.py.in M lib/vdsm/define.py M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/transient.py M tests/vmTests.py M vdsm.spec.in M vdsm/vm.py 8 files changed, 194 insertions(+), 18 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Dan Kenigsberg has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 11:
(9 comments)
File lib/vdsm/config.py.in
Line 157:
Line 158: ('libvirt_env_variable_log_outputs', '',
Line 159: 'Specify the output to track libvirt calls'),
Line 160:
Line 161: ('transient_disks_repository', '@VDSMLIBDIR@/transient',
It's not only about size, it's also the fact that /var/run might be in-memory
(tmpfs) and it's not the correct place for data files (in fact also libvirt
uses /var/lib/libvirt for data, e.g. images, networks, etc.).
Line 162: 'Local path to the transient disks repository.'),
Line 163: ]),
Line 164:
Line 165: # Section: [ksm]
File lib/vdsm/tool/transient.py
Line 27: from vdsm.utils import execCmd, CommandPath
Line 28:
Line 29:
Line 30: SELINUX_VIRT_IMAGE_LABEL = system_u:object_r:virt_image_t:s0
Line 31: TRANSIENT_DISKS_REPO = config.get('vars', 'transient_disks_repository')
Some appliances (ovirt-node?) might prefer to have it somewhere else. We
already need the logic for the cleanup, creating it is just a small nit. Making
this configurable was also a request coming from the previous review.
Line 32:
Line 33: _fuser = CommandPath(
Line 34: fuser,
Line 35: /sbin/fuser, # Fedora, EL6
Line 32:
Line 33: _fuser = CommandPath(
Line 34: fuser,
Line 35: /sbin/fuser, # Fedora, EL6
Line 36: )
Already answered (with more considerations) on patch set 7.
Line 37:
Line 38:
Line 39: @expose(setup-transient-repository)
Line 40: def setup_transient_repository(*args):
Line 50: raise
Line 51:
Line 52: os.chown(TRANSIENT_DISKS_REPO, vdsm_uid, vdsm_gid)
Line 53: os.chmod(TRANSIENT_DISKS_REPO, 0750)
Line 54: selinux.chcon(TRANSIENT_DISKS_REPO, SELINUX_VIRT_IMAGE_LABEL)
No it doesn't explode, I am not changing a sebool, I am changing the file
context. Yes a restorecon would un-do the change. We'll need to file a request
for that but for now this is good enough.
Line 55:
Line 56:
Line 57: @expose(cleanup-transient-repository)
Line 58: def cleanup_transient_repository(*args):
Line 61: (NOTE: it is recommended to NOT execute this command when the vdsm
Line 62: daemon is running)
Line 63:
Line 64: transient_images = set((os.path.join(TRANSIENT_DISKS_REPO, x)
Line 65:for x in os.listdir(TRANSIENT_DISKS_REPO)))
Done
Line 66:
Line 67: if len(transient_images) == 0:
Line 68: return # Nothing to do
Line 69:
File vdsm/vm.py
Line 412: class DRIVE_SHARED_TYPE:
Line 413: NONE = none
Line 414: EXCLUSIVE = exclusive
Line 415: SHARED = shared
Line 416: TRANSIENT = transient
Exclusive (locking) is for a volume on a shared storage. Transient is obviously
also exclusive as it's on the local machine storage (no real need for locking).
Line 417:
Line 418: @classmethod
Line 419: def getAllValues(cls):
Line 420: # TODO: use introspection
Line 3298: params=customProps)
Line 3299: return {'status': doneCode, 'vmList': self.status()}
Line 3300:
Line 3301: def _createTransientDisk(self, drive):
Line 3302: if drive.get('shared', None) != DRIVE_SHARED_TYPE.TRANSIENT:
I prefer not to spread this check in multiple places.
Line 3303: return
Line 3304:
Line 3305: # FIXME: This should be replaced in future the support for
transient
Line 3306: # disk in libvirt (BZ#832194)
Line 3327: drive['path'] = transientPath
Line 3328: drive['format'] = 'cow'
Line 3329:
Line 3330: def _removeTransientDisk(self, drive):
Line 3331: if getattr(drive, 'transient', False):
leftover to be fixed
Line 3332: os.unlink(drive.path)
Line :
Line 3334: def hotplugDisk(self, params):
Line 3335: if self.isMigrating():
Line 3390: diskParams = params.get('drive', {})
Line 3391: diskParams['path'] = self.cif.prepareVolumePath(diskParams)
Line 3392:
Line 3393: try:
Line 3394: drive = self._findDriveByUUIDs(diskParams)
it's related to this patch since now we can't use a path to identify a
(transient) disk.
Line 3395: except LookupError:
Line 3396: self.log.error(Hotunplug disk failed - Disk not found:
%s,
Line 3397:diskParams)
Line 3398: return {'status': {
--
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4883/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_install_rpm_sanity_gerrit/151/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4807/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 11: Code-Review-1
(10 comments)
Commit Message
Line 4: Commit: Federico Simoncelli fsimo...@redhat.com
Line 5: CommitDate: 2013-10-05 18:04:31 -0400
Line 6:
Line 7: vm: add the transient disk support
Line 8:
What are transient disks? I am really not sure I understand.
Line 9: This patch adds support for transient disk for 'hotplug' and 'run vm'
Line 10: flows. Libvirt currently doesn't yet support transient disks, hence
Line 11: this patch fills the gap until the time libvirt starts supporting it.
Line 12:
File lib/vdsm/config.py.in
Line 157:
Line 158: ('libvirt_env_variable_log_outputs', '',
Line 159: 'Specify the output to track libvirt calls'),
Line 160:
Line 161: ('transient_disks_repository', '@VDSMLIBDIR@/transient',
Too bad /var/run/vdsm is too small.
Line 162: 'Local path to the transient disks repository.'),
Line 163: ]),
Line 164:
Line 165: # Section: [ksm]
File lib/vdsm/tool/transient.py
Line 27: from vdsm.utils import execCmd, CommandPath
Line 28:
Line 29:
Line 30: SELINUX_VIRT_IMAGE_LABEL = system_u:object_r:virt_image_t:s0
Line 31: TRANSIENT_DISKS_REPO = config.get('vars', 'transient_disks_repository')
do we really need to have this directory configurable? creating it on install
time could have been simpler.
Line 32:
Line 33: _fuser = CommandPath(
Line 34: fuser,
Line 35: /sbin/fuser, # Fedora, EL6
Line 32:
Line 33: _fuser = CommandPath(
Line 34: fuser,
Line 35: /sbin/fuser, # Fedora, EL6
Line 36: )
using vdsm/storage/fuser.py is not easy (it requires moving that module) but
would have been better for the project as a whole.
Line 37:
Line 38:
Line 39: @expose(setup-transient-repository)
Line 40: def setup_transient_repository(*args):
Line 50: raise
Line 51:
Line 52: os.chown(TRANSIENT_DISKS_REPO, vdsm_uid, vdsm_gid)
Line 53: os.chmod(TRANSIENT_DISKS_REPO, 0750)
Line 54: selinux.chcon(TRANSIENT_DISKS_REPO, SELINUX_VIRT_IMAGE_LABEL)
doen't this explode if selinux is disabled?
besides, shouldn't we require a proper selinux-policy change for this?
otherwise someone doing restorecon would un-do this. change.
Line 55:
Line 56:
Line 57: @expose(cleanup-transient-repository)
Line 58: def cleanup_transient_repository(*args):
Line 61: (NOTE: it is recommended to NOT execute this command when the vdsm
Line 62: daemon is running)
Line 63:
Line 64: transient_images = set((os.path.join(TRANSIENT_DISKS_REPO, x)
Line 65:for x in os.listdir(TRANSIENT_DISKS_REPO)))
nit: doesn't glob() do the right thing cleaner?
Line 66:
Line 67: if len(transient_images) == 0:
Line 68: return # Nothing to do
Line 69:
File vdsm/vm.py
Line 412: class DRIVE_SHARED_TYPE:
Line 413: NONE = none
Line 414: EXCLUSIVE = exclusive
Line 415: SHARED = shared
Line 416: TRANSIENT = transient
I'm missing something basic. Why is transient a DRIVE_SHARED_TYPE? I'd expect
transient drive to be all exclusive.
Line 417:
Line 418: @classmethod
Line 419: def getAllValues(cls):
Line 420: # TODO: use introspection
Line 3298: params=customProps)
Line 3299: return {'status': doneCode, 'vmList': self.status()}
Line 3300:
Line 3301: def _createTransientDisk(self, drive):
Line 3302: if drive.get('shared', None) != DRIVE_SHARED_TYPE.TRANSIENT:
style: I prefer to put this condition out of the function, over bailing out
silently if the argument is not what we need.
Line 3303: return
Line 3304:
Line 3305: # FIXME: This should be replaced in future the support for
transient
Line 3306: # disk in libvirt (BZ#832194)
Line 3327: drive['path'] = transientPath
Line 3328: drive['format'] = 'cow'
Line 3329:
Line 3330: def _removeTransientDisk(self, drive):
Line 3331: if getattr(drive, 'transient', False):
what is setting this attribute? or should you mean 'transientDisk'?
Line 3332: os.unlink(drive.path)
Line :
Line 3334: def hotplugDisk(self, params):
Line 3335: if self.isMigrating():
Line 3390: diskParams = params.get('drive', {})
Line 3391: diskParams['path'] = self.cif.prepareVolumePath(diskParams)
Line 3392:
Line 3393: try:
Line 3394: drive = self._findDriveByUUIDs(diskParams)
a nice cleanup, worthy of its own patch.
Line 3395: except LookupError:
Line 3396: self.log.error(Hotunplug disk failed - Disk not found:
%s,
Line 3397:
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 10: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4704/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3895/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3896/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 9: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4667/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3858/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File vdsm/vm.py Line 3318:volume %s, drive['volumeID'], exc_info=True) Line 3319: finally: Line 3320: os.close(transientHandle) Line 3321: Line 3322: drive['path'] = transientPath drive['format'] = 'cow' Line 3323: Line 3324: def _removeTransientDisk(self, drive): Line 3325: if getattr(drive, 'transient', False): Line 3326: os.unlink(drive.path) -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File lib/vdsm/tool/transient.py Line 70: # one access has been found, fuser returns zero. we can discard the Line 71: # return code. Line 72: open_transient_images = set(x.rsplit(:, 1)[0] for x in cmd_out) Line 73: Line 74: for image_path in transient_images - open_transient_images: absolute path vs relative path Line 75: # NOTE: This could cause a race with the creation of a virtual Line 76: # machine with a transient disk (if vdsm is running). Line 77: try: Line 78: os.unlink(image_path) -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 7: (7 comments) File lib/vdsm/tool/transient.py Line 29: SELINUX_VIRT_IMAGE_LABEL = system_u:object_r:virt_image_t:s0 Line 30: Line 31: _fuser = CommandPath( Line 32: fuser, Line 33: /sbin/fuser, # Fedora, EL6 I can try to unify them later. Given where the other one is defined (storage instead of utils) and the changes that I'd need, it's too risky. Line 34: ) Line 35: Line 36: Line 37: @expose(setup-transient-repository) File vdsm/vm.py Line 2492: with self._volPrepareLock: Line 2493: for drive in drives: Line 2494: try: Line 2495: self._removeTransientDisk(drive) Line 2496: except: Do you really want to risk another teardownVolumePath issue? Catching an OSError would be fiddling with the (current) internal implementation of _removeTransientDisk. Line 2497: self.log.error(Drive transient volume deletion failed Line 2498:for drive %s, drive, exc_info=True) Line 2499: try: Line 2500: self.cif.teardownVolumePath(drive) Line 2493: for drive in drives: Line 2494: try: Line 2495: self._removeTransientDisk(drive) Line 2496: except: Line 2497: self.log.error(Drive transient volume deletion failed Done Line 2498:for drive %s, drive, exc_info=True) Line 2499: try: Line 2500: self.cif.teardownVolumePath(drive) Line 2501: except: Line 3299: qemuImg.FORMAT.RAW Line 3300: ) Line 3301: Line 3302: transientHandle, transientPath = tempfile.mkstemp( Line 3303: dir=constants.P_VDSM_TRANSIENT, Done Line 3304: prefix=%s-%s. % (drive['domainID'], drive['volumeID'])) Line 3305: Line 3306: try: Line 3307: qemuImg.create(transientPath, format=qemuImg.FORMAT.QCOW2, Line 3303: dir=constants.P_VDSM_TRANSIENT, Line 3304: prefix=%s-%s. % (drive['domainID'], drive['volumeID'])) Line 3305: Line 3306: try: Line 3307: qemuImg.create(transientPath, format=qemuImg.FORMAT.QCOW2, Fully transient disk? I think we should just get rid of few validations and checks along the way. Line 3308:backing=drive['path'], backingFormat=driveFormat) Line 3309: os.fchmod(transientHandle, 0660) Line 3310: except: Line 3311: os.unlink(transientPath) # Closing after deletion is correct Line 3694: Line 3695: if vmDrive.hasVolumeLeases: Line 3696: return errCode['noimpl'] Line 3697: Line 3698: if vmDrive.transientDisk: leftover Line 3699: return errCode['transientErr'] Line 3700: Line 3701: vmDevName = vmDrive.name Line 3702: Line 3967: if srcDrive.hasVolumeLeases: Line 3968: return errCode['noimpl'] Line 3969: Line 3970: if srcDrive.transientDisk: Line 3971: return errCode['transientErr'] If I understand correctly what you're suggesting is to get disk replica to work with transient disks. To replicate the disk you need to access both source and destination from the same host (and on the contrary the transient layer is local). Line 3972: Line 3973: try: Line 3974: self._setDiskReplica(srcDrive, dstDisk) Line 3975: except: -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3810/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4619/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Liron Ar has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File lib/vdsm/tool/transient.py Line 63: daemon is running) Line 64: Line 65: transient_images = set(os.listdir(TRANSIENT_DISKS_REPO)) Line 66: Line 67: cmd_ret, cmd_out, cmd_err = execCmd([_fuser.cmd] + transient_images) Fede, this causes to an error..please take a look Traceback (most recent call last): File /usr/bin/vdsm-tool, line 143, in module sys.exit(main()) File /usr/bin/vdsm-tool, line 140, in main return tool_command[cmd][command](*args[1:]) File /usr/lib64/python2.6/site-packages/vdsm/tool/transient.py, line 67, in cleanup_transient_repository cmd_ret, cmd_out, cmd_err = execCmd([_fuser.cmd] + transient_images) TypeError: can only concatenate list (not set) to list vdsm: failed to execute prepare_transient_repository, error code 1 Line 68: # According to: fuser returns a non-zero return code if none of the Line 69: # specified files is accessed or in case of a fatal error. If at least Line 70: # one access has been found, fuser returns zero. we can discard the Line 71: # return code. -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File lib/vdsm/tool/transient.py Line 63: daemon is running) Line 64: Line 65: transient_images = set(os.listdir(TRANSIENT_DISKS_REPO)) Line 66: Line 67: cmd_ret, cmd_out, cmd_err = execCmd([_fuser.cmd] + transient_images) Yes I already addressed this locally. I thought it was on your build as well. Line 68: # According to: fuser returns a non-zero return code if none of the Line 69: # specified files is accessed or in case of a fatal error. If at least Line 70: # one access has been found, fuser returns zero. we can discard the Line 71: # return code. -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Ayal Baron has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Ayal Baron has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(10 comments)
File lib/vdsm/tool/transient.py
Line 29: SELINUX_VIRT_IMAGE_LABEL = system_u:object_r:virt_image_t:s0
Line 30:
Line 31: _fuser = CommandPath(
Line 32: fuser,
Line 33: /sbin/fuser, # Fedora, EL6
fuser is already defined elsewhere, why redefine here?
Line 34: )
Line 35:
Line 36:
Line 37: @expose(setup-transient-repository)
File vdsm/vm.py
Line 2492: with self._volPrepareLock:
Line 2493: for drive in drives:
Line 2494: try:
Line 2495: self._removeTransientDisk(drive)
Line 2496: except:
except OSError ?
Line 2497: self.log.error(Drive transient volume deletion
failed
Line 2498:for drive %s, drive,
exc_info=True)
Line 2499: try:
Line 2500: self.cif.teardownVolumePath(drive)
Line 2493: for drive in drives:
Line 2494: try:
Line 2495: self._removeTransientDisk(drive)
Line 2496: except:
Line 2497: self.log.error(Drive transient volume deletion
failed
this should be a warning, not error
Line 2498:for drive %s, drive,
exc_info=True)
Line 2499: try:
Line 2500: self.cif.teardownVolumePath(drive)
Line 2501: except:
Line 3299: qemuImg.FORMAT.RAW
Line 3300: )
Line 3301:
Line 3302: transientHandle, transientPath = tempfile.mkstemp(
Line 3303: dir=constants.P_VDSM_TRANSIENT,
this should probably be configurable in some way to allow the user to define an
area for temporary data (not necessarily in this patch).
Line 3304: prefix=%s-%s. % (drive['domainID'], drive['volumeID']))
Line 3305:
Line 3306: try:
Line 3307: qemuImg.create(transientPath,
format=qemuImg.FORMAT.QCOW2,
Line 3303: dir=constants.P_VDSM_TRANSIENT,
Line 3304: prefix=%s-%s. % (drive['domainID'], drive['volumeID']))
Line 3305:
Line 3306: try:
Line 3307: qemuImg.create(transientPath,
format=qemuImg.FORMAT.QCOW2,
What would it take to support 'createing' a transient disk on the fly without a
backing file? (doesn't have to be in this patch)
Line 3308:backing=drive['path'],
backingFormat=driveFormat)
Line 3309: os.fchmod(transientHandle, 0660)
Line 3310: except:
Line 3311: os.unlink(transientPath) # Closing after deletion is
correct
Line 3384: # We lookup the drive by UUIDs since the image path
could
Line 3385: # be transient.
Line 3386: drive = self._findDriveByUUIDs(diskParams)
Line 3387: else:
Line 3388: drive = self._findDriveByPath(diskParams['path'])
can't you lookup by guid to allow for transient lun hotunplug?
Line 3389: except LookupError:
Line 3390: self.log.error(Hotunplug disk failed - Disk not found:
%s,
Line 3391:diskParams)
Line 3392: return {'status': {
Line 3694:
Line 3695: if vmDrive.hasVolumeLeases:
Line 3696: return errCode['noimpl']
Line 3697:
Line 3698: if vmDrive.transientDisk:
how can vmDrive be transient if vm has no transient disks? (you checked on line
3670)
Line 3699: return errCode['transientErr']
Line 3700:
Line 3701: vmDevName = vmDrive.name
Line 3702:
Line 3866: mergeStatus['status'] = MERGESTATUS.NOT_STARTED
Line 3867:
Line 3868: if not mergeDrive or not hasattr(mergeDrive,
'volumeChain'):
Line 3869: mergeStatus['status'] = MERGESTATUS.DRIVE_NOT_FOUND
Line 3870: elif mergeDrive.hasVolumeLeases or
mergeDrive.transientDisk:
not related to patch: hasVolumeLeases is the correct test here after recent
changes?
Line 3871: mergeStatus['status'] =
MERGESTATUS.DRIVE_NOT_SUPPORTED
Line 3872: else:
Line 3873: for volume in mergeDrive.volumeChain:
Line 3874: # qemu-kvm looks up for the backing file path
looking at
Line 3967: if srcDrive.hasVolumeLeases:
Line 3968: return errCode['noimpl']
Line 3969:
Line 3970: if srcDrive.transientDisk:
Line 3971: return errCode['transientErr']
why prevent this? wouldn't this be a way to make data here permanent and be
able to migrate disk, etc? (it would probably require a new flow in engine, but
that is besides the point)
Line 3972:
Line 3973: try:
Line 3974:
Change in vdsm[master]: vm: add the transient disk support
Ayal Baron has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 7: (1 comment) File vdsm/vm.py Line 3866: mergeStatus['status'] = MERGESTATUS.NOT_STARTED Line 3867: Line 3868: if not mergeDrive or not hasattr(mergeDrive, 'volumeChain'): Line 3869: mergeStatus['status'] = MERGESTATUS.DRIVE_NOT_FOUND Line 3870: elif mergeDrive.hasVolumeLeases or mergeDrive.transientDisk: just looked at hasVolumeLeases, you can ignore this comment Line 3871: mergeStatus['status'] = MERGESTATUS.DRIVE_NOT_SUPPORTED Line 3872: else: Line 3873: for volume in mergeDrive.volumeChain: Line 3874: # qemu-kvm looks up for the backing file path looking at -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4588/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3703/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Line 3384: # We lookup the drive by UUIDs since the image path
could
Line 3385: # be transient.
Line 3386: drive = self._findDriveByUUIDs(diskParams)
Line 3387: else:
Line 3388: drive = self._findDriveByPath(diskParams['path'])
This doesn't mix well in case we want a transient LUN disk.
Line 3389: except LookupError:
Line 3390: self.log.error(Hotunplug disk failed - Disk not found:
%s,
Line 3391:diskParams)
Line 3392: return {'status': {
--
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 6: (2 comments) File vdsm/vm.py Line 1424: # To handle legacy and removable drives. Line 1425: return False Line 1426: Line 1427: def _customize(self): Line 1428: if self.transientDisk: Note to self: remember to check this. Line 1429: # Force the cache to be writethrough, which is qemu's default. Line 1430: # This is done to ensure that we don't ever use cache=none for Line 1431: # transient disks, since we create them in /var/run/vdsm which Line 1432: # may end up on tmpfs and don't support O_DIRECT, and qemu uses Line 3398: # We lookup the drive by UUIDs since the image path could be Line 3399: # transient. Line 3400: drive = self._findDriveByUUIDs(diskParams) Line 3401: else: Line 3402: drive = self._findDriveByPath(diskParams['path']) Catch LookupError and transform to errCode['hotunplugDisk']. Line 3403: Line 3404: if drive.hasVolumeLeases: Line 3405: return errCode['noimpl'] Line 3406: -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 4: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4376/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4295/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4378/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4297/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
