Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-12-10 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


vm_migrate_hook: skip interface handling for customized VMs

If VM has one of blacklisted 'custom' properties, we should skip
interface migration translation. Migration specifics must be handled
by external provider itself.

Based on https://gerrit.ovirt.org/#/c/63686/1

Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Signed-off-by: Petr Horáček 
---
M vdsm/virt/vm_migrate_hook.py
1 file changed, 30 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-12-07 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 6: Code-Review+2

I vouch for this: "custom" is always a dict. If Engine is evil and sends 
something else, I want to explode.

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-12-05 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/67455/4/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 220: 
Line 221: 
Line 222: def _protected_customized_interface(target_conf):
Line 223: custom_properties = target_conf.get('custom')
Line 224: if not custom_properties:
> 3 returns in a single func is a bit too much.
I personally like short-circuiting a function, it yes, with

 custom_properties = target_conf.get('custom', {})

we can avoid this first condition. The iteration would be of zero-length anyway.
Line 225: return False
Line 226: 
Line 227: for key, value in six.iteritems(custom_properties):
Line 228: if ((key,) in INTERFACE_CUSTOM_PROPERTY_BLACKLIST or


-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 2: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-11-30 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 2:

Please limit this to the approved list of custom properties.

We agreed to accept openstack, vmfex, macspoof

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs

2016-11-28 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vm_migrate_hook: skip interface handling for customized VMs
..


Patch Set 2: Code-Review+1

horrible, but that's the best we can do right now.

-- 
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org