Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks _getUnderlyingDriveInfo() is broken by design. It has no reliable means to match Engine-requested devices with libvirt-produced ones. As a heuristic, it uses the device's as matching key. However, before this patch, it failed to extract the path from the xml definition of gluster disks. Bug-Url: https://bugzilla.redhat.com/1007980 Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/19906 Reviewed-by: Vinzenz Feenstra Reviewed-by: Michal Skrivanek Reviewed-by: Martin Polednik Tested-by: Martin Polednik Reviewed-on: http://gerrit.ovirt.org/19949 --- M vdsm/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Dan Kenigsberg has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Michal Skrivanek has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Hello Vinzenz Feenstra, Michal Skrivanek, Martin Polednik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/19949 to review the following change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks _getUnderlyingDriveInfo() is broken by design. It has no reliable means to match Engine-requested devices with libvirt-produced ones. As a heuristic, it uses the device's as matching key. However, before this patch, it failed to extract the path from the xml definition of gluster disks. Bug-Url: https://bugzilla.redhat.com/1007980 Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/19906 Reviewed-by: Vinzenz Feenstra Reviewed-by: Michal Skrivanek Reviewed-by: Martin Polednik Tested-by: Martin Polednik --- M vdsm/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/19949/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 4333170..d73671b 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -4562,7 +4562,8 @@ sources = x.getElementsByTagName('source') if sources: devPath = (sources[0].getAttribute('file') or - sources[0].getAttribute('dev')) + sources[0].getAttribute('dev') or + sources[0].getAttribute('name')) else: devPath = '' -- To view, visit http://gerrit.ovirt.org/19949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches