Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/33641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has abandoned this change. Change subject: DONTMERGE: virt: log device changes .. Abandoned -- To view, visit https://gerrit.ovirt.org/33641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 3: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 1: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has uploaded a new change for review.
Change subject: DONTMERGE: virt: log device changes
..
DONTMERGE: virt: log device changes
DO NOT MERGE - DEBUG ONLY
log device changes to improve debuggability of VDSM.
This is an hack which adds unnecessary traffic in the logs!
Proper, streamlined change will be prepared in parallel.
Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/33641/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0f9e4ce..e845a50 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4810,9 +4810,13 @@
def _getUnderlyingVmInfo(self):
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
-getElementsByTagName('devices')[0]
-self._devXmlHash = str(hash(devxml.toxml()))
+getElementsByTagName('devices')[0].toxml()
+xmlHash = hash(devxml)
+if xmlHash != self._devXmlHash:
+self.log.debug('VM device changed:\n%s', devxml)
+
+self._devXmlHash = xmlHash
return self._lastXMLDesc
def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/33641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 2: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
