Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Yaniv Bronhaim has submitted this change and it was merged. Change subject: multiapth: Disable hba rescanning by default .. multiapth: Disable hba rescanning by default Since commit 674337d8f9 we are scanning both iscsi bus and hbas when issuing multipath.rescan(). We did not find any bad effects when testing in our QE lab, but we have reports from customers that these rescans have bad effects on FC connections. This patch disables hba rescanning by default, so users can use this feature if works for them, until we investigate this issue and provide better solution. This should have been part of the original patch, since we cannot test all kinds of storage servers in the same setup and load used by all users. If hba rescanning cannot be used with certain storage server, it should be possible to disable this feature. Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Bug-Url: https://bugzilla.redhat.com/1152587 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34176 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34215 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/config.py.in M vdsm/storage/multipath.py 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
oVirt Jenkins CI Server has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/48/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/45/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/50/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/50/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Nir Soffer has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 1: Verified+1 Tested again on rhel 6.6 and 7. http://gerrit.ovirt.org/34245 will take some time to finish, and we need to get this backport into 3.4 as soon as possible. -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Nir Soffer has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 2: Version 2 fixes the commit hash that enabled issue_lip. The master version contains unrelated commit hash. -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Federico Simoncelli has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Yaniv Bronhaim has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Nir Soffer has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 1: If http://gerrit.ovirt.org/34245 works, it can replace this one. -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Hello Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34215
to review the following change.
Change subject: multiapth: Disable hba rescanning by default
..
multiapth: Disable hba rescanning by default
Since commit 85d46e4572 we are scanning both iscsi bus and hbas when
issuing multipath.rescan(). We did not find any bad effects when testing
in our QE lab, but we have reports from customers that these rescans have
bad effects on FC connections.
This patch disables hba rescanning by default, so users can use this
feature if works for them, until we investigate this issue and provide
better solution.
This should have been part of the original patch, since we cannot test
all kinds of storage servers in the same setup and load used by all
users. If hba rescanning cannot be used with certain storage server, it
should be possible to disable this feature.
Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb
Bug-Url: https://bugzilla.redhat.com/1152587
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/34176
Reviewed-by: Federico Simoncelli fsimo...@redhat.com
---
M lib/vdsm/config.py.in
M vdsm/storage/multipath.py
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/34215/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index ab330be..583ad77 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -266,6 +266,11 @@
('vol_size_sample_interval', '60',
'How often should the volume size be checked (seconds).'),
+('hba_rescan', 'false',
+'Enable hba scanning when rescanning multipath. Required to '
+'detect new or removed luns on FCP server. Disabled by default '
+'since it may be disruptive.'),
+
('scsi_rescan_minimal_timeout', '2',
'The minimum number of seconds to wait for scsi scan to return.'),
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index ba98866..68502ce 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -32,6 +32,7 @@
from vdsm import constants
from vdsm import utils
+from vdsm.config import config
import misc
import iscsi
import supervdsm
@@ -104,7 +105,9 @@
# First rescan iSCSI and FCP connections
iscsi.rescan()
-supervdsm.getProxy().hbaRescan()
+
+if config.getboolean('irs', 'hba_rescan'):
+supervdsm.getProxy().hbaRescan()
# Now let multipath daemon pick up new devices
misc.execCmd([constants.EXT_MULTIPATH], sudo=True)
--
To view, visit http://gerrit.ovirt.org/34215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multiapth: Disable hba rescanning by default
Dan Kenigsberg has posted comments on this change. Change subject: multiapth: Disable hba rescanning by default .. Patch Set 1: Code-Review+2 based on Federico's master aproval -- To view, visit http://gerrit.ovirt.org/34215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812308e54ec2a9eab1ca4115e0456b2dd3990cfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
