Change in vdsm[ovirt-3.5]: vm: state change missing return value

2014-11-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vm: state change missing return value
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vm: state change missing return value

2014-11-18 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: vm: state change missing return value
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vm: state change missing return value

2014-11-18 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm: state change missing return value
..


vm: state change missing return value

Return arguments where ignored in schema for pause and resume verbs.
We had to update command_info with following verbs to returned
'vmList' dictionary required by the engine.


Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Bug-Url: https://bugzilla.redhat.com/1163089
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
Reviewed-on: http://gerrit.ovirt.org/35150
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vm: state change missing return value

2014-11-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: state change missing return value
..


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/83/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/89/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/86/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/86/ : 
SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vm: state change missing return value

2014-11-14 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: vm: state change missing return value
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches