Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 4: * #64986::Update tracker: OK * #1321018::Update tracker: OK * #59725::Update tracker: OK * Set MODIFIED::bug 1321018#1321018OK -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Francesco Romani has submitted this change and it was merged. Change subject: Live Merge: Remove volume run link after live merge .. Live Merge: Remove volume run link after live merge When deleting a volume while the VM is running, volume teardown doesn't remove the volume run symbolic link: /run/vdsm/storage/sdUUID/volUUID. In patch Iec3b6a (Live Merge: teardown volume on HSM after live merge) we added volume teardown logic that, for block storage it deactivated the volume. In this patch we extend volume teardown logic to unlink volume run link. Note that this change isn't required for file storage as no symbolic links are created. Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Bug-Url: https://bugzilla.redhat.com/1321018 Signed-off-by: Ala HinoReviewed-on: https://gerrit.ovirt.org/59725 Reviewed-by: Nir Soffer Reviewed-by: Adam Litke Continuous-Integration: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/64986 Reviewed-by: Francesco Romani --- M vdsm/storage/blockSD.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve; Passed CI tests Francesco Romani: Looks good to me, approved Ala Hino: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Francesco Romani has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Allon Mureinik has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: @Francesco, based on Nir's comments on the CI, can we move forwards with this patch please? -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Continuous-Integration+1 Network tests failing again. We don't have any tests for this fix, so this failures are not relevant. -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Francesco Romani has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Code-Review+1 looks OK, but please get ACKs from storage devs. The bug is targeted 4.0.6, will merge once 4.0.5 is out. -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: Verified+1 Verified on master -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 3: * #1321018::Update tracker: OK * #59725::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::#1321018::OK, correct target milestone ovirt-4.0.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 2: * #1321018::Update tracker: OK * #59725::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::#1321018::OK, correct target milestone ovirt-4.0.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 1: * #1321018::Update tracker: OK * #59725::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::#1321018::OK, correct target milestone ovirt-4.0.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala HinoGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Live Merge: Remove volume run link after live merge
Hello Adam Litke, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64986 to review the following change. Change subject: Live Merge: Remove volume run link after live merge .. Live Merge: Remove volume run link after live merge When deleting a volume while the VM is running, volume teardown doesn't remove the volume run symbolic link: /run/vdsm/storage/sdUUID/volUUID. In patch Iec3b6a (Live Merge: teardown volume on HSM after live merge) we added volume teardown logic that, for block storage it deactivated the volume. In this patch we extend volume teardown logic to unlink volume run link. Note that this change isn't required for file storage as no symbolic links are created. Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Bug-Url: https://bugzilla.redhat.com/1321018 Signed-off-by: Ala HinoReviewed-on: https://gerrit.ovirt.org/59725 Reviewed-by: Nir Soffer Reviewed-by: Adam Litke Continuous-Integration: Nir Soffer --- M vdsm/storage/blockSD.py 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/64986/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 58d2507..f977150 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -813,6 +813,21 @@ def teardownVolume(self, imgUUID, volUUID): lvm.deactivateLVs(self.sdUUID, [volUUID]) +self.removeVolumeRunLink(imgUUID, volUUID) + +def removeVolumeRunLink(self, imgUUID, volUUID): +""" +Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID +""" +vol_run_link = os.path.join(constants.P_VDSM_STORAGE, +self.sdUUID, imgUUID, volUUID) +self.log.info("Unlinking volme runtime link: %r", vol_run_link) +try: +os.unlink(vol_run_link) +except OSError as e: +if e.error != errno.ENOENT: +raise +self.log.debug("Volume run link %r does not exist", vol_run_link) class BlockStorageDomain(sd.StorageDomain): -- To view, visit https://gerrit.ovirt.org/64986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org