Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-09-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 2:

* #1368115::Update tracker: OK
* Set MODIFIED::bug 1368115#1368115OK

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-09-04 Thread ybronhei 
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: certificates: remove config.read call
..


certificates: remove config.read call

config.read(file) loads a new configuration to 'config' based on the
file it reads. This call causes a bug and incosistency of vdsm 
configuration since it overrides the right configuration.
config should be built from files in pre configured paths (drop-in
dirs) with priority determined by configuration file names.


Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368115
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/62885
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/62941
---
M lib/vdsm/tool/configurators/certificates.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-09-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-09-03 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1:

ping?

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-08-30 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-08-29 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-08-29 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1:

* #1368115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368115::OK, public bug
* Check Product::#1368115::OK, Correct classification oVirt
* Check TM::#1368115::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

2016-08-29 Thread igoihman 
Hello Yaniv Bronhaim, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/62941

to review the following change.

Change subject: certificates: remove config.read call
..

certificates: remove config.read call

config.read(file) loads a new configuration to 'config' based on the
file it reads. This call causes a bug and incosistency of vdsm 
configuration since it overrides the right configuration.
config should be built from files in pre configured paths (drop-in
dirs) with priority determined by configuration file names.


Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368115
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/62885
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/tool/configurators/certificates.py
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/62941/1

diff --git a/lib/vdsm/tool/configurators/certificates.py 
b/lib/vdsm/tool/configurators/certificates.py
index e5b373a..bfdf75a 100644
--- a/lib/vdsm/tool/configurators/certificates.py
+++ b/lib/vdsm/tool/configurators/certificates.py
@@ -68,11 +68,5 @@
 
 
 def _certsExist():
-config.read(
-os.path.join(
-SYSCONF_PATH,
-'vdsm/vdsm.conf'
-)
-)
 return not config.getboolean('vars', 'ssl') or\
 os.path.isfile(CERT_FILE)


-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org