Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 2:

* #1358530::Update tracker: OK
* Set MODIFIED::bug 1358530#1358530OK

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: jsonvdscli: change hostname default
..


jsonvdscli: change hostname default

We want to mitigate dns lookups due to potential issues with
connectivity or dns servers.


Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Signed-off-by: Piotr Kliczewski 
Bug-Url: https://bugzilla.redhat.com/1358530
Reviewed-on: https://gerrit.ovirt.org/63308
Reviewed-by: Irit Goihman 
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Tested-by: Irit Goihman 
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/vdscli.py
M tests/vdsClientTests.py
3 files changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1:

Thanks

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: -Verified

* #1358530::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358530::OK, public bug
* Check Product::#1358530::OK, Correct classification oVirt
* Check TM::#1358530::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread oourfali 
Oved Ourfali has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Code-Review+2

please verify

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1:

Build failure not related to this patch

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Verified-1

* #1358530::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1358530::OK, public bug
* Check Product::#1358530::OK, Correct classification oVirt
* Check TM::#1358530::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

2016-09-05 Thread piotr . kliczewski 
Piotr Kliczewski has uploaded a new change for review.

Change subject: jsonvdscli: change hostname default
..

jsonvdscli: change hostname default

We want to mitigate dns lookups due to potential issues with
connectivity or dns servers.


Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Signed-off-by: Piotr Kliczewski 
Bug-Url: https://bugzilla.redhat.com/1358530
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/vdscli.py
M tests/vdsClientTests.py
3 files changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/63308/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index e4b455d..caffb9a 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -22,8 +22,6 @@
 
 from functools import partial
 from uuid import uuid4
-import socket
-
 
 import six
 from yajsonrpc import stompreactor
@@ -199,7 +197,7 @@
 useSSL=None,
 responseQueue=None):
 if host is None:
-host = socket.gethostname()
+host = 'localhost'
 if port is None:
 port = int(config.getint('addresses', 'management_port'))
 
diff --git a/lib/vdsm/vdscli.py b/lib/vdsm/vdscli.py
index d634a1c..22e7bc8 100644
--- a/lib/vdsm/vdscli.py
+++ b/lib/vdsm/vdscli.py
@@ -24,7 +24,6 @@
 import os
 import re
 from six.moves import xmlrpc_client as xmlrpclib
-import socket
 import sys
 import warnings
 from xml.parsers.expat import ExpatError
@@ -84,7 +83,7 @@
 PORT = config.getint('addresses', 'management_port')
 ADDRESS = config.get('addresses', 'management_ip')
 if ADDRESS == '::':
-ADDRESS = socket.gethostname()
+ADDRESS = 'localhost'
 except:
 pass
 
diff --git a/tests/vdsClientTests.py b/tests/vdsClientTests.py
index a7b6a82..0046281 100644
--- a/tests/vdsClientTests.py
+++ b/tests/vdsClientTests.py
@@ -548,8 +548,8 @@
 self._assertValidPort(port)
 
 def _assertValidAddress(self, addr):
-if addr != socket.gethostname():
-if addr.count('.'):
+if addr != 'localhost':
+if '.' in addr:
 if not _isIPv4Address(addr):
 raise AssertionError('invalid IPv4 address: %s',
  addr)


-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org