Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1379115#1379115IGNORE, not all related patches are 
closed, check 64408

-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-28 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


net: Use is_link_up instead of operstate in netfunctestlib

Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Signed-off-by: Edward Haas 
Bug-Url: https://bugzilla.redhat.com/1379115
Reviewed-on: https://gerrit.ovirt.org/63090
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/64395
---
M tests/network/netfunctestlib.py
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-26 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-26 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 1: Verified+1

Func tests passed

-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 1:

* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Product::#1379115::OK, Correct classification oVirt
* Check TM::#1379115::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-25 Thread edwardh 
Hello Petr Horáček, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64395

to review the following change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..

net: Use is_link_up instead of operstate in netfunctestlib

Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Signed-off-by: Edward Haas 
Bug-Url: https://bugzilla.redhat.com/1379115
Reviewed-on: https://gerrit.ovirt.org/63090
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
---
M tests/network/netfunctestlib.py
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/64395/1

diff --git a/tests/network/netfunctestlib.py b/tests/network/netfunctestlib.py
index ea8aa4a..c873634 100644
--- a/tests/network/netfunctestlib.py
+++ b/tests/network/netfunctestlib.py
@@ -31,7 +31,7 @@
 from vdsm.network import kernelconfig
 from vdsm.network.ip import dhclient
 from vdsm.network.ip.address import ipv6_supported
-from vdsm.network.netinfo.nics import operstate
+from vdsm.network.link.iface import is_oper_up
 
 from testlib import VdsmTestCase
 
@@ -328,8 +328,7 @@
 net, attrs, self.netinfo)
 if expected_links:
 for dev in expected_links:
-# Links are sometimes marked as UNKNOWN after turned UP.
-self.assertIn(operstate(dev).upper(), ('UP', 'UNKNOWN'))
+self.assertTrue(is_oper_up(dev), 'Dev {} is DOWN'.format(dev))
 
 def assertNameservers(self, nameservers):
 self.assertEqual(nameservers,


-- 
To view, visit https://gerrit.ovirt.org/64395
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Petr Horáček 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org