Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1379115#1379115IGNORE, not all related patches are 
closed, check 64413

-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-28 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: ifcfg - dhclient should always be stopped
..


net: ifcfg - dhclient should always be stopped

While running functional tests, it has been observed that dhclients are
still running on slave ifaces.

This patch is stopping any running dhclient per the configured iface.

Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Signed-off-by: Edward Haas 
Bug-Url: https://bugzilla.redhat.com/1379115
Reviewed-on: https://gerrit.ovirt.org/62832
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/64397
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-26 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-26 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1: Verified+1

Func tests passed

-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1:

* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Product::#1379115::OK, Correct classification oVirt
* Check TM::#1379115::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-25 Thread edwardh 
Hello Petr Horáček, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64397

to review the following change.

Change subject: net: ifcfg - dhclient should always be stopped
..

net: ifcfg - dhclient should always be stopped

While running functional tests, it has been observed that dhclients are
still running on slave ifaces.

This patch is stopping any running dhclient per the configured iface.

Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Signed-off-by: Edward Haas 
Bug-Url: https://bugzilla.redhat.com/1379115
Reviewed-on: https://gerrit.ovirt.org/62832
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/64397/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 1845f07..8cf07ef 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -530,11 +530,13 @@
 cfg += 'BOOTPROTO=none\n'
 elif ipv4.bootproto:
 cfg += 'BOOTPROTO=%s\n' % pipes.quote(ipv4.bootproto)
-if (ipv4.bootproto == 'dhcp' and
-os.path.exists(os.path.join(NET_PATH, name))):
-# Ask dhclient to stop any dhclient running for the device
-dhclient.kill(name)
-address.flush(name, family=4)
+
+# FIXME: Move this out, it is unrelated to a conf file creation.
+if os.path.exists(os.path.join(NET_PATH, name)):
+# Ask dhclient to stop any dhclient running for the device
+dhclient.kill(name)
+address.flush(name, family=4)
+
 if mtu:
 cfg += 'MTU=%d\n' % mtu
 if ipv4.defaultRoute is not None:


-- 
To view, visit https://gerrit.ovirt.org/64397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Petr Horáček 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org