Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net test: Rename link_test module to netlink_test
..


net test: Rename link_test module to netlink_test

Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Bug-Url: https://bugzilla.redhat.com/1379115
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/62442
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/64385
Reviewed-by: Petr Horáček 
---
M tests/Makefile.am
R tests/network/netlink_test.py
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1379115#1379115IGNORE, not all related patches are 
closed, check 64386

-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 1: Verified+1

Func tests passed

-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 1:

* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Product::#1379115::OK, Correct classification oVirt
* Check TM::#1379115::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

[edwardh]

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/64385

to review the following change.

Change subject: net test: Rename link_test module to netlink_test
..

net test: Rename link_test module to netlink_test

Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Bug-Url: https://bugzilla.redhat.com/1379115
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/62442
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
R tests/network/netlink_test.py
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/64385/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 8b881d8..3becc72 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -198,7 +198,7 @@
network/ip_test.py \
network/iproute2_test.py \
network/ipwrapper_test.py \
-   network/link_test.py \
+   network/netlink_test.py \
network/netinfo_test.py \
network/ovs_driver_test.py \
network/ovs_info_test.py \
diff --git a/tests/network/link_test.py b/tests/network/netlink_test.py
similarity index 100%
rename from tests/network/link_test.py
rename to tests/network/netlink_test.py


-- 
To view, visit https://gerrit.ovirt.org/64385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org