Change in vdsm[ovirt-4.0]: virt-net: attempt to unset port mirroring only if the VM was...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change.

Change subject: virt-net: attempt to unset port mirroring only if the VM was 
properly initialized
..


Abandoned

abandoning, unless urgently requested into 4.0

-- 
To view, visit https://gerrit.ovirt.org/72742
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Israel Pinto 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt-net: attempt to unset port mirroring only if the VM was...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: virt-net: attempt to unset port mirroring only if the VM was 
properly initialized
..

virt-net: attempt to unset port mirroring only if the VM was properly 
initialized

If qemu crashed before we read the libvirt-allocated device names, the
VM moves to Down state. However, when we are asked to destroy() the VM
object, we attempt to unset port mirroring on a vNIC that was never
properly initialized.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1419931
Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a
Signed-off-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/72742/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d69d364..078c6eb 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4119,7 +4119,7 @@
 # unsetting mirror network will clear both mirroring
 # (on the same network).
 for nic in self._devices[hwclass.NIC]:
-if hasattr(nic, 'portMirroring'):
+if hasattr(nic, 'portMirroring') and hasattr(nic, 'name'):
 for network in nic.portMirroring[:]:
 supervdsm.getProxy().unsetPortMirroring(network,
 nic.name)


-- 
To view, visit https://gerrit.ovirt.org/72742
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org