Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Modify Permissions for VDSM project
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/66573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7be095056102c0701f1c6017dbae53dcd0a17
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Shlomo Ben David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Modify Permissions for VDSM project
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/66573/4/project.config
File project.config:

PS4, Line 59: submit = group vdsm-master-maintainers
can we have an online review of this change? this seems to grant submit rights 
to all vdsm-master-maintainers, instead of only the vdsm-maintainers group.


-- 
To view, visit https://gerrit.ovirt.org/66573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7be095056102c0701f1c6017dbae53dcd0a17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Shlomo Ben David 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Modify Permissions for VDSM project
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/66573/4/groups
File groups:

Line 3
Line 4
Line 5
Line 6
Line 7
> The group name vdsm-master-submitters is related only for master branch (as
but what are the permissions of vdsm-maintainers?

submit *should* require special permissions, and I want only vdsm-maintainers 
to have it: 
https://gerrit-review.googlesource.com/Documentation/access-control.html#category_submit

Everybody is allowed to push new changes, and that's good 
https://gerrit-review.googlesource.com/Documentation/access-control.html#category_push


-- 
To view, visit https://gerrit.ovirt.org/66573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7be095056102c0701f1c6017dbae53dcd0a17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Shlomo Ben David 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Modify Permissions for VDSM project
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/66573/4/groups
File groups:

Line 3
Line 4
Line 5
Line 6
Line 7
why is this list kept? where is vdsm-master-submitters?


-- 
To view, visit https://gerrit.ovirt.org/66573
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7be095056102c0701f1c6017dbae53dcd0a17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Shlomo Ben David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org