Change in vdsm[master]: ssl: enable tlsv1.2 support

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ssl: enable tlsv1.2 support
..


Patch Set 32: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Remove unused repoPath argument

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: volume: Remove unused repoPath argument
..


Patch Set 1: Code-Review+2

simple enough

-- 
To view, visit https://gerrit.ovirt.org/78351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04899fe2a3f245f476279f0727673e3b67e87fb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: py3: use next() builtin instead of deprecated method
..


Patch Set 2:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: py3: use next() builtin instead of deprecated method
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/78346/2/vdsm_hooks/smbios/before_vm_start.py
File vdsm_hooks/smbios/before_vm_start.py:

PS2, Line 68: iterkeys
> It looks that there are few more. It looks like we need one more patch.
Yes, there's a lot more work. This patch is focused on the "next" method, 
nothing else.


-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ssl: disable sslv3 on centos7

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ssl: disable sslv3 on centos7
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78028
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58c2621a3a93f307dbd1b47596ea842e0adaff5c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ssl: disable sslv3 on centos7

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: ssl: disable sslv3 on centos7
..


ssl: disable sslv3 on centos7

During testing I noticed that sslv3 is still enabled on centos7 so we
need to disable it.


Bug-Url: https://bugzilla.redhat.com/1412552
Change-Id: I58c2621a3a93f307dbd1b47596ea842e0adaff5c
Signed-off-by: Piotr Kliczewski 
---
M lib/vdsm/sslutils.py
M tests/ssl_test.py
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78028
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58c2621a3a93f307dbd1b47596ea842e0adaff5c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ssl: enable tlsv1.2 support

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: ssl: enable tlsv1.2 support
..


ssl: enable tlsv1.2 support

We support all three tlsv1, tlsv1.1 and tlsv1.2 protocols or only
tlsv1.2. We provide a way to disable specific protocols.

It is not possible to use ssl.PROTOCOL_TLS because it is not available
for centos7.

Bug-Url: https://bugzilla.redhat.com/1412552
Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Signed-off-by: Piotr Kliczewski 
---
M lib/vdsm/config.py.in
M lib/vdsm/sslutils.py
M lib/yajsonrpc/stompreactor.py
M tests/integration/sslhelper.py
M tests/ssl_test.py
5 files changed, 132 insertions(+), 18 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm-tool: add collectd configurator

2017-06-21 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: add collectd configurator
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/78364/1/static/usr/share/vdsm/collectd.virt.conf
File static/usr/share/vdsm/collectd.virt.conf:

Line 12: Connection "qemu:///system"
Line 13: Instances 5
Line 14: ExtraStats "disk pcpu"
Line 15: 
Line 16
this is all? what about enabling the rest of what we need? host-deploy is 
planed to do so?


-- 
To view, visit https://gerrit.ovirt.org/78364
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac14bc996078d01b986210bd08c94fe93f69ac2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: make sure infra package is deleted on upgrade

2017-06-21 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: make sure infra package is deleted on upgrade
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/78357/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: According to spec guidelines, a package will be removed on update
Line 10: if it will have the following rule:
Line 11: 
Line 12: Obsoletes:  %{name} <= %{version}-%{release}
yes, but <=4.18 should be fine ... why isn't it? do we have builds in 4.19 with 
vdms-infra?
Line 13: 
Line 14: Change-Id: I8c975bffe713b716dfa9a8bc1bbee6d9a24fb144
Line 15: Signed-off-by: Irit Goihman 


https://gerrit.ovirt.org/#/c/78357/2/vdsm.spec.in
File vdsm.spec.in:

Line 119: Requires: safelease >= 1.0-7
Line 120: Requires: mom >= 0.5.8
Line 121: Requires(pre): shadow-utils
Line 122: 
Line 123: Obsoletes: %{name}-infra <= %{version}-%{release}
why would we have vdsm-infra in 4.19? isn't <=4.18 enough?
Line 124: 
Line 125: %if 0%{?with_openvswitch}
Line 126: Requires: openvswitch >= 2.0.0
Line 127: %endif


-- 
To view, visit https://gerrit.ovirt.org/78357
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c975bffe713b716dfa9a8bc1bbee6d9a24fb144
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm-tool: add collectd configurator

2017-06-21 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: add collectd configurator
..


Patch Set 1:

(5 comments)

https://gerrit.ovirt.org/#/c/78364/1//COMMIT_MSG
Commit Message:

Line 15: We can't do better than that.
Line 16: 
Line 17: vdsm-tool assumes that the virt plugin is not configured at all
Line 18: (otherwise see above). If the vdsm sampling is disabled, the
Line 19: tool will configure collectd to do the monitoring.
I think you should use the --force - if force is set then we overwrite current 
conf files and remove the old once (no fallback - maybe keep a backup for 
removal). if its without --force you can fail the configure with a request to 
add the configuration manually or use the force flag.. otherwise you can mess 
up not only our reports but also the old configurations the user had..
Line 20: 
Line 21: vdsm-tool will also check the other way around: if vdsm sampling
Line 22: is enabled, it will make sure that collectd is not monitoring the
Line 23: VMs.


https://gerrit.ovirt.org/#/c/78364/1/lib/vdsm/tool/configurators/collectd.py
File lib/vdsm/tool/configurators/collectd.py:

Line 35: from vdsm.common.cmdutils import CommandPath
Line 36: 
Line 37: from . import YES, NO
Line 38: 
Line 39: # TODO: use constants.py
why? its fine to keep it private here.. no other package should use those 
variables
Line 40: _COLLECTD_CONF_CUR = "/etc/collectd.d/virt.conf"
Line 41: _COLLECTD_CONF_VDSM = "/usr/share/vdsm/collectd.virt.conf"
Line 42: _COLLECTD_SERVICE = "collectd.service"
Line 43: 


Line 41: _COLLECTD_CONF_VDSM = "/usr/share/vdsm/collectd.virt.conf"
Line 42: _COLLECTD_SERVICE = "collectd.service"
Line 43: 
Line 44: 
Line 45: _SYSTEMCTL = CommandPath("systemctl", "/bin/systemctl", 
"/usr/bin/systemctl")
you can use the service module if we still have it
Line 46: 
Line 47: # Configuratior interface
Line 48: name = "collectd"
Line 49: services = []


Line 45: _SYSTEMCTL = CommandPath("systemctl", "/bin/systemctl", 
"/usr/bin/systemctl")
Line 46: 
Line 47: # Configuratior interface
Line 48: name = "collectd"
Line 49: services = []
services must be declared? I think by default its empty list
Line 50: 
Line 51: 
Line 52: class NotFound(Exception):
Line 53: """configuration file not found"""


Line 99: _log("collectd configured outside vdsm")
Line 100: return YES
Line 101: except NotFound:
Line 102: _log("collectd requires configuration")
Line 103: return NO
what about removeConf?
Line 104: 
Line 105: 
Line 106: def _collectd_configured():
Line 107: """


-- 
To view, visit https://gerrit.ovirt.org/78364
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac14bc996078d01b986210bd08c94fe93f69ac2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Require abrt-cli for vdsm sos plugin

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Require abrt-cli for vdsm sos plugin
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: python3: avoid decoding errors

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: tests: python3: avoid decoding errors
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78044
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5283854daf63ded0354d434e6e7d777a633664e3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: python3: avoid decoding errors

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: tests: python3: avoid decoding errors
..


Patch Set 11: Verified+1

test-only patch. CI+1 is enough

-- 
To view, visit https://gerrit.ovirt.org/78044
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5283854daf63ded0354d434e6e7d777a633664e3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: move storageServer to lib/vdsm/storage/server.py

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change.

Change subject: storage: move storageServer to lib/vdsm/storage/server.py
..


Abandoned

all of storage is moved by Piotr

-- 
To view, visit https://gerrit.ovirt.org/73116
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0fba9e9da91354a2e28fdf0ce754836ae61c7094
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: py3: use next() builtin instead of deprecated method
..


py3: use next() builtin instead of deprecated method

Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/network/tc/__init__.py
M lib/vdsm/osinfo.py
M tests/stompasyncdispatcher_test.py
M tests/storage_misc_test.py
M vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
M vdsm_hooks/smbios/before_vm_start.py
6 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Adam Litke: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: py3: use next() builtin instead of deprecated method
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: py3: use next() builtin instead of deprecated method
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: python3: avoid decoding errors

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: python3: avoid decoding errors
..


tests: python3: avoid decoding errors

We have one test which wants to feed libvirt with incorrect xml.
To make it work properly under python3, we need to read the data
as bytes (not as strings) and decode it to string when needed.

No intended changes in behaviour.

Change-Id: I5283854daf63ded0354d434e6e7d777a633664e3
Signed-off-by: Francesco Romani 
---
M tests/vmfakecon.py
1 file changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78044
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5283854daf63ded0354d434e6e7d777a633664e3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: use next() builtin instead of deprecated method

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: py3: use next() builtin instead of deprecated method
..


Patch Set 2:

http://jenkins.ovirt.org/job/ovirt-system-tests_manual/677/

-- 
To view, visit https://gerrit.ovirt.org/78346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d4dea51fc6e9ec21ea88c47cc18750cdfa9ac3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: validateDirAccess: move to sdperm

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has abandoned this change.

Change subject: storage: validateDirAccess: move to sdperm
..


Abandoned

all of storage is moved by Piotr

-- 
To view, visit https://gerrit.ovirt.org/73115
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I21ead1cb635f8224cb09f7319ffcb55eebe2a9e3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: fix v2v and its test

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: py3: fix v2v and its test
..

py3: fix v2v and its test

Change-Id: I1a7d26d8731ccd1e03687fa6ab772f165cb9f523
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/v2v.py
M tests/Makefile.am
M tests/v2v_test.py
M tests/v2v_testlib.py
4 files changed, 27 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/78414/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index eedcf6d..9d98886 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -74,7 +74,7 @@
 _XEN_SSH_PROTOCOL = 'xen+ssh'
 _VMWARE_PROTOCOL = 'vpx'
 _KVM_PROTOCOL = 'qemu'
-_SSH_AUTH_RE = '(SSH_AUTH_SOCK)=([^;]+).*;\nSSH_AGENT_PID=(\d+)'
+_SSH_AUTH_RE = b'(SSH_AUTH_SOCK)=([^;]+).*;\nSSH_AGENT_PID=(\d+)'
 _OVF_RESOURCE_CPU = 3
 _OVF_RESOURCE_MEMORY = 4
 _OVF_RESOURCE_NETWORK = 10
@@ -525,9 +525,9 @@
 fd = os.open(self._passwd_file, os.O_WRONLY | os.O_CREAT, 0o600)
 try:
 if self._password.value is None:
-os.write(fd, "")
+os.write(fd, b"")
 else:
-os.write(fd, self._password.value)
+os.write(fd, self._password.value.encode())
 finally:
 os.close(fd)
 try:
@@ -940,12 +940,12 @@
 
 
 class OutputParser(object):
-COPY_DISK_RE = re.compile(r'.*(Copying disk (\d+)/(\d+)).*')
-DISK_PROGRESS_RE = re.compile(r'\s+\((\d+).*')
+COPY_DISK_RE = re.compile(br'.*(Copying disk (\d+)/(\d+)).*')
+DISK_PROGRESS_RE = re.compile(br'\s+\((\d+).*')
 
 def parse(self, stream):
 for line in stream:
-if 'Copying disk' in line:
+if b'Copying disk' in line:
 description, current_disk, disk_count = self._parse_line(line)
 yield ImportProgress(int(current_disk), int(disk_count),
  description)
@@ -964,15 +964,15 @@
 return m.group(1), m.group(2), m.group(3)
 
 def _iter_progress(self, stream):
-chunk = ''
+chunk = b''
 while True:
 c = stream.read(1)
 if not c:
 raise OutputParserError('copy-disk stream closed unexpectedly')
 chunk += c
-if c == '\r':
+if c == b'\r':
 yield chunk
-chunk = ''
+chunk = b''
 
 def _parse_progress(self, chunk):
 m = self.DISK_PROGRESS_RE.match(chunk)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7fe8571..edb9975 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -242,7 +242,6 @@
storage_workarounds_test.py \
unicode_test.py \
utils_test.py \
-   v2v_test.py \
vmapi_test.py \
vmmigration_test.py \
vmoperations_test.py \
diff --git a/tests/v2v_test.py b/tests/v2v_test.py
index 2d44945..5f438de 100644
--- a/tests/v2v_test.py
+++ b/tests/v2v_test.py
@@ -18,7 +18,7 @@
 #
 
 from contextlib import contextmanager
-from io import StringIO
+import io
 import subprocess
 import tarfile
 import uuid
@@ -41,7 +41,7 @@
 from testlib import VdsmTestCase as TestCaseBase, recorded
 from monkeypatch import MonkeyPatch, MonkeyPatchScope
 
-import vmfakelib as fake
+import vmfakecon as fake
 
 
 FAKE_VIRT_V2V = CommandPath('fake-virt-v2v',
@@ -85,7 +85,7 @@
 
 
 def read_ovf(ovf_path):
-return """
+return u"""
 http://schemas.dmtf.org/ovf/envelope/1;
   xmlns:ovf="http://schemas.dmtf.org/ovf/envelope/1;
   xmlns:rasd="http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_Re\
@@ -129,7 +129,7 @@
 ovapath = os.path.join(base, 'testvm.ova')
 ovf = read_ovf('test')
 
-with open(ovfpath, 'w') as ovffile:
+with io.open(ovfpath, 'w') as ovffile:
 ovffile.write(ovf)
 yield ovapath
 
@@ -319,7 +319,7 @@
   u'[ 256.0] Finishing off')
 
 parser = v2v.OutputParser()
-events = list(parser.parse(StringIO(output)))
+events = list(parser.parse(io.StringIO(output)))
 self.assertEqual(events, [
 (v2v.ImportProgress(1, 2, 'Copying disk 1/2')),
 (v2v.DiskProgress(0)),
@@ -458,10 +458,10 @@
 rc, output, error = execCmd(cmd, raw=True)
 self.assertEqual(rc, 0)
 
-with open('fake-virt-v2v.out', 'r') as f:
+with io.open('fake-virt-v2v.out', 'rb') as f:
 self.assertEqual(output, f.read())
 
-with open('fake-virt-v2v.err', 'r') as f:
+with io.open('fake-virt-v2v.err', 'rb') as f:
 self.assertEqual(error, f.read())
 
 @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
@@ -486,25 +486,25 @@
  stdin=subprocess.PIPE,
  stdout=subprocess.PIPE)
 msg = "test\ntest"
-p.stdin.write(msg)
+

Change in vdsm[master]: net: dump bonding options on network-service start

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: dump bonding options on network-service start
..


Patch Set 14: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/78006/14//COMMIT_MSG
Commit Message:

Line 10: versions, so a scenario where the kernel is upgraded and incompatible
Line 11: default options are lingering will cause problems.
Line 12: 
Line 13: Instead of shipping with default options, dump bonding defaults on
Line 14: network-service start.
please update the commit message
Line 15: 
Line 16: Bug-Id: https://bugzilla.redhat.com/1458549
Line 17: Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698


-- 
To view, visit https://gerrit.ovirt.org/78006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net,static: Configure NM with slaves-order=name

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net,static: Configure NM with slaves-order=name
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net,static: Configure NM with slaves-order=name

2017-06-21 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net,static: Configure NM with slaves-order=name
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/78362/2//COMMIT_MSG
Commit Message:

Line 13: Note: This solution is available from NM version 1.8, part of RHEL 7.4
Line 14: and Fedora 26.
Line 15: 
Line 16: Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Line 17: Bug-Url: https://bugzilla.redhat.com/1443347
please use the BZ of the correct branch:

https://bugzilla.redhat.com/show_bug.cgi?id=1463218


-- 
To view, visit https://gerrit.ovirt.org/78362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Require abrt-cli for vdsm sos plugin

2017-06-21 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Require abrt-cli for vdsm sos plugin
..


Patch Set 1: Verified+1

jenkins fails not related

-- 
To view, visit https://gerrit.ovirt.org/78386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Require abrt-cli for vdsm sos plugin

2017-06-21 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Require abrt-cli for vdsm sos plugin
..

Require abrt-cli for vdsm sos plugin

vdsm sos plugin uses abrt-cli output. without requiring that, sos output
will print an error. reasonable to require that as part of vdsm.

Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=917062
Signed-off-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/78386/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 31123a3..7c76d3a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -110,6 +110,7 @@
 Requires: rpm-python
 Requires: nfs-utils
 Requires: libnl3
+Requires: abrt-cli
 Requires: abrt-addon-vmcore
 Requires: abrt-addon-ccpp
 Requires: abrt-addon-python


-- 
To view, visit https://gerrit.ovirt.org/78386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org