Change in vdsm[master]: janitorial: drop once-used P_VDSM_KEYS
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: janitorial: drop once-used P_VDSM_KEYS .. Patch Set 4: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/846/ -- To view, visit https://gerrit.ovirt.org/77468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588a94534d2813bc9ffdd1688364cea0e7516170 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to its sole user
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user .. Patch Set 1: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/846/ -- To view, visit https://gerrit.ovirt.org/79731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. Patch Set 1: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/846/ -- To view, visit https://gerrit.ovirt.org/79732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move vdsm.constants.UUID_GLOB_PATTERN to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79714 ) Change subject: move vdsm.constants.UUID_GLOB_PATTERN to storage.constants .. move vdsm.constants.UUID_GLOB_PATTERN to storage.constants UUID_GLOB_PATTERN is used only by storage, and should be defined there as well. Change-Id: If50684c256ff3e732ea1f058fe7b48b9becd3ac6 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/storage/constants.py M lib/vdsm/storage/fileSD.py M lib/vdsm/storage/sd.py M lib/vdsm/storage/sp.py 5 files changed, 7 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If50684c256ff3e732ea1f058fe7b48b9becd3ac6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: hook: checkimages: define GiB properly
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hook: checkimages: define GiB properly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_NODE_ID to its sole user
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79715 ) Change subject: move constants.P_VDSM_NODE_ID to its sole user .. move constants.P_VDSM_NODE_ID to its sole user Change-Id: Iae0a734fa9903d978e6e6ce1a03ce86cbc898e83 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/host/__init__.py 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae0a734fa9903d978e6e6ce1a03ce86cbc898e83 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: janitorial: drop once-used P_VDSM_KEYS
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77468 ) Change subject: janitorial: drop once-used P_VDSM_KEYS .. janitorial: drop once-used P_VDSM_KEYS PKI_DIR leads to basically the same place. Change-Id: I588a94534d2813bc9ffdd1688364cea0e7516170 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/tool/configurators/passwd.py 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/77468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I588a94534d2813bc9ffdd1688364cea0e7516170 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.EXT_BRCTL to its sole current user
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79717 ) Change subject: move constants.EXT_BRCTL to its sole current user .. move constants.EXT_BRCTL to its sole current user EXT_BRCTL is not going to move anytime soon from /usr/sbin/brctl. This patch defines this constant inside its sole current user, dummybr. Change-Id: Icaaf576d5d3456935fa848c04bd65517d09b37ed Signed-off-by: Dan Kenigsberg --- M configure.ac M lib/vdsm/constants.py.in M lib/vdsm/tool/dummybr.py 3 files changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified Edward Haas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaaf576d5d3456935fa848c04bd65517d09b37ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: hook: checkimages: define GiB properly
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79730 ) Change subject: hook: checkimages: define GiB properly .. hook: checkimages: define GiB properly The constant is called GIB, but the value was that of the plain decimal GB. Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927 Signed-off-by: Dan Kenigsberg --- M vdsm_hooks/checkimages/before_vm_start.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. move constants.P_VDSM_STORAGE to storage.constants Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/storage/blockSD.py M lib/vdsm/storage/constants.py M lib/vdsm/storage/fileSD.py M lib/vdsm/storage/sd.py 5 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/79741/1 diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index f851065..66c669b 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -63,7 +63,6 @@ P_VDSM_HOOKS = '@HOOKSDIR@/' # NOQA: E501 (potentially long line) P_VDSM_LIB = '@VDSMLIBDIR@/' # NOQA: E501 (potentially long line) P_VDSM_RUN = '@VDSMRUNDIR@/' # NOQA: E501 (potentially long line) -P_VDSM_STORAGE = os.path.join(P_VDSM_RUN, 'storage/') P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line) P_VDSM_LOG = '@VDSMLOGDIR@' # NOQA: E501 (potentially long line) diff --git a/lib/vdsm/storage/blockSD.py b/lib/vdsm/storage/blockSD.py index 90844c8..44d721d 100644 --- a/lib/vdsm/storage/blockSD.py +++ b/lib/vdsm/storage/blockSD.py @@ -901,7 +901,7 @@ """ Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID """ -vol_run_link = os.path.join(constants.P_VDSM_STORAGE, +vol_run_link = os.path.join(sc.P_VDSM_STORAGE, self.sdUUID, imgUUID, volUUID) self.log.info("Unlinking volme runtime link: %r", vol_run_link) try: @@ -1312,7 +1312,7 @@ srcImgPath: Dir where the image volumes are. """ -sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) +sdRunDir = os.path.join(sc.P_VDSM_STORAGE, self.sdUUID) imgRunDir = os.path.join(sdRunDir, imgUUID) fileUtils.createdir(imgRunDir) for volUUID in volUUIDs: diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py index 2fb929b..e282c2f 100644 --- a/lib/vdsm/storage/constants.py +++ b/lib/vdsm/storage/constants.py @@ -196,3 +196,5 @@ # accepts currently its all of the version but in the # future we might slice it (eg. tuple(DOMAIN_VERSION[1:])) SUPPORTED_DOMAIN_VERSIONS = DOMAIN_VERSIONS + +P_VDSM_STORAGE = os.path.join(constants.P_VDSM_RUN, 'storage/') diff --git a/lib/vdsm/storage/fileSD.py b/lib/vdsm/storage/fileSD.py index b9160d0..861b299 100644 --- a/lib/vdsm/storage/fileSD.py +++ b/lib/vdsm/storage/fileSD.py @@ -545,7 +545,7 @@ srcImgPath: Dir where the image volumes are. """ -sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) +sdRunDir = os.path.join(sc.P_VDSM_STORAGE, self.sdUUID) fileUtils.createdir(sdRunDir) imgRunDir = os.path.join(sdRunDir, imgUUID) self.log.debug("Creating symlink from %s to %s", srcImgPath, imgRunDir) diff --git a/lib/vdsm/storage/sd.py b/lib/vdsm/storage/sd.py index d66a1a2..5b9ece0 100644 --- a/lib/vdsm/storage/sd.py +++ b/lib/vdsm/storage/sd.py @@ -979,7 +979,7 @@ getLinkBCImagePath = getImageDir def getImageRundir(self, imgUUID): -return os.path.join(constants.P_VDSM_STORAGE, self.sdUUID, imgUUID) +return os.path.join(sc.P_VDSM_STORAGE, self.sdUUID, imgUUID) def getIsoDomainImagesDir(self): return self._manifest.getIsoDomainImagesDir() -- To view, visit https://gerrit.ovirt.org/79741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move constants.P_VDSM_CONF to vdsm.config .. move constants.P_VDSM_CONF to vdsm.config Change-Id: Ic0ba7de6aae8331a3587d82eadf16346437cafb6 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/config.py.in M lib/vdsm/constants.py.in M lib/vdsm/vdsmd.py 3 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/79742/1 diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in index d7b4cfc..06245a4 100644 --- a/lib/vdsm/config.py.in +++ b/lib/vdsm/config.py.in @@ -43,8 +43,8 @@ import textwrap import glob -_SYSCONFDIR = '@sysconfdir@' -_DROPPIN_BASES = ("/usr/lib/", "/run/", _SYSCONFDIR) +P_VDSM_CONF = '@sysconfdir@' +_DROPPIN_BASES = ("/usr/lib/", "/run/", P_VDSM_CONF) parameters = [ @@ -617,7 +617,7 @@ or users can overwrite the defaults, by placing a complete or partial configuration file into /etc or a drop-in directory. """ -default_conf = os.path.join(_SYSCONFDIR, name, name + '.conf') +default_conf = os.path.join(P_VDSM_CONF, name, name + '.conf') cfg.read(default_conf) dropins = [] diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 66c669b..72d4a67 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -63,7 +63,6 @@ P_VDSM_HOOKS = '@HOOKSDIR@/' # NOQA: E501 (potentially long line) P_VDSM_LIB = '@VDSMLIBDIR@/' # NOQA: E501 (potentially long line) P_VDSM_RUN = '@VDSMRUNDIR@/' # NOQA: E501 (potentially long line) -P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line) P_VDSM_LOG = '@VDSMLOGDIR@' # NOQA: E501 (potentially long line) diff --git a/lib/vdsm/vdsmd.py b/lib/vdsm/vdsmd.py index ee734bc..75049e1 100755 --- a/lib/vdsm/vdsmd.py +++ b/lib/vdsm/vdsmd.py @@ -50,7 +50,7 @@ from vdsm.virt import periodic -loggerConfFile = constants.P_VDSM_CONF + 'logger.conf' +loggerConfFile = os.path.join(config.P_VDSM_CONF, 'logger.conf') class FatalError(Exception): -- To view, visit https://gerrit.ovirt.org/79742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0ba7de6aae8331a3587d82eadf16346437cafb6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: ssl: handle handshake errors
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/79668/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2017-07-24 12:08:16 +0200 Line 6: Line 7: ssl: handle handshake errors Line 8: Line 9: We need to make sure to close socket when handshake fails. what happened otherwise? Line 10: Line 11: Line 12: Bug-url: https://bugzilla.redhat.com/1473295 Line 13: Change-Id: I99cfa35e608f429640455c35495be1783854e3da https://gerrit.ovirt.org/#/c/79668/4/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 250: self.want_read = True Line 251: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE: Line 252: self.want_write = True Line 253: else: Line 254: dispatcher.close() don't we need the above treatment ? Line 255: except socket.error: Line 256: dispatcher.close() Line 257: else: Line 258: self.want_read = self.want_write = True -- To view, visit https://gerrit.ovirt.org/79668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.1]: m2c: uses different protocol constant names
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: m2c: uses different protocol constant names .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79664/2//COMMIT_MSG Commit Message: Line 9: M2crypto uses the same name scheme as openssl which differs from ssl Line 10: module. SSL_OP_NO_TLSv1_1 is not available on some of m2c versions. Line 11: Line 12: Line 13: Label: ovirt-4.1-only > There is no need to write anything about m2c being removed from master. sounds reasonable to me to say why its ovirt-4.1 only.. but as you wish Line 14: Bug-Url: https://bugzilla.redhat.com/1473344 Line 15: Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5 -- To view, visit https://gerrit.ovirt.org/79664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Makefile: replace astrisks with equal signs
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: Makefile: replace astrisks with equal signs .. Makefile: replace astrisks with equal signs Tripple astrisks are used to mark failures in make and other utilities. Let us use '===' instead for comments. Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Signed-off-by: Dan Kenigsberg --- M tests/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/79750/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 464850f..734e80d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -304,16 +304,16 @@ @true check-net: - @echo '*** Running networking tests. ***' + @echo '=== Running networking tests. ===' @$(top_srcdir)/tests/run_tests_local.sh $(network_modules) check-virt: - @echo '*** Running virt tests. ***' + @echo '=== Running virt tests. ===' @$(top_srcdir)/tests/run_tests_local.sh $(virt_modules) check: - @echo '*** Running tests. To skip this step place NOSE_EXCLUDE=.* ***' - @echo '*** into your environment. Do not submit untested code!***' + @echo '=== Running tests. To skip this step place NOSE_EXCLUDE=.* ===' + @echo '=== into your environment. Do not submit untested code!===' $(top_srcdir)/tests/run_tests_local.sh $(run_modules) if [ "$(PYTHON3_SUPPORT)" == "1" ]; then \ all_modules=`mktemp`; \ -- To view, visit https://gerrit.ovirt.org/79750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sslutils: add info to SSLHandshake errors
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: sslutils: add info to SSLHandshake errors .. Patch Set 2: thanks Piotr, that was very kind of you. -- To view, visit https://gerrit.ovirt.org/76221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cb2d7e0c6c86ca12a34be13b07bc960e3ad313e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: sslutils: add info to SSLHandshake errors
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76221 ) Change subject: sslutils: add info to SSLHandshake errors .. sslutils: add info to SSLHandshake errors Include name of peer and its full certificate if they do not match, in order to understand which non-legitimate client attempts to connect. Change-Id: I0cb2d7e0c6c86ca12a34be13b07bc960e3ad313e Signed-off-by: Dan Kenigsberg --- M lib/vdsm/sslutils.py 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb2d7e0c6c86ca12a34be13b07bc960e3ad313e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Makefile: replace astrisks with equal signs
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: ci please build -- To view, visit https://gerrit.ovirt.org/79750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Makefile: replace astrisks with equal signs
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/854/ -- To view, visit https://gerrit.ovirt.org/79750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: RPC: Fix error messages in JsonRpcResponse
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79665 ) Change subject: RPC: Fix error messages in JsonRpcResponse .. RPC: Fix error messages in JsonRpcResponse JsonRpcResponse.error is now always an exception object derived from JsonRpcError. Previously it could also be a dictionary which caused problems. Change-Id: Ie9a4b318dfca66e8b50eb44fe9a24fb43ee32275 Signed-off-by: Andrej Krejcir --- M lib/vdsm/client.py M lib/vdsm/jsonrpcvdscli.py M lib/yajsonrpc/__init__.py M tests/integration/jsonRpcTests.py 4 files changed, 9 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/79665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9a4b318dfca66e8b50eb44fe9a24fb43ee32275 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: RPC: Refactor JSON RPC exceptions
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78660 ) Change subject: RPC: Refactor JSON RPC exceptions .. RPC: Refactor JSON RPC exceptions JsonRpcError class is now derived from ContextException and other derived exceptions use the context to provide more information. For example, new error message for JsonRpcMethodNotFoundError is: The method does not exist or is not available: {'method': 'some_missing_method'} Also added a new class JsonRpcServerError, that can have any code and message. Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958 Signed-off-by: Andrej Krejcir --- M lib/vdsm/common/exception.py M lib/vdsm/jsonrpcvdscli.py M lib/vdsm/rpc/Bridge.py M lib/yajsonrpc/__init__.py M tests/bridge_test.py M tests/integration/jsonRpcTests.py M tests/stomp_test.py M tests/vdsmapi_test.py 8 files changed, 97 insertions(+), 91 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/78660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Denis Chaplygin Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Phillip Bailey Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yanir Quinn Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: add IPAddressApi and its iproute implementation
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76153 ) Change subject: network: add IPAddressApi and its iproute implementation .. network: add IPAddressApi and its iproute implementation Change-Id: I8f90df4142aee11cf1cba1293fb89ebc7cace1ac Signed-off-by: Petr Horacek --- M automation/check-merged.packages.el7 M automation/check-merged.packages.fc24 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc24 M automation/check-patch.packages.fc25 M docker/Dockerfile.centos M docker/Dockerfile.fedora.25 M docker/Dockerfile.fedora.rawhide M lib/vdsm/network/ip/address/__init__.py A lib/vdsm/network/ip/address/iproute2.py M lib/vdsm/network/ipwrapper.py M tests/network/ip_address_test.py M vdsm.spec.in 13 files changed, 445 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Edward Haas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f90df4142aee11cf1cba1293fb89ebc7cace1ac Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horacek Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. Patch Set 4: ci please build -- To view, visit https://gerrit.ovirt.org/79741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_CONF to vdsm.config .. Patch Set 6: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/79742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0ba7de6aae8331a3587d82eadf16346437cafb6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_CONF to vdsm.config
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_CONF to vdsm.config .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/79742/6/lib/vdsm/vdsmd.py File lib/vdsm/vdsmd.py: Line 50: from vdsm.storage.dispatcher import Dispatcher Line 51: from vdsm.virt import periodic Line 52: Line 53: Line 54: loggerConfFile = os.path.join(vdsm.config.P_VDSM_CONF, 'logger.conf') former constant was /etc/vdsm, current is /etc Line 55: Line 56: Line 57: class FatalError(Exception): Line 58: """ Raised when vdsm fail to start """ -- To view, visit https://gerrit.ovirt.org/79742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0ba7de6aae8331a3587d82eadf16346437cafb6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants .. Patch Set 3: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system tests/job/ovirt-system-tests_manual/855 -- To view, visit https://gerrit.ovirt.org/79731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. Patch Set 3: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system tests/job/ovirt-system-tests_manual/855 -- To view, visit https://gerrit.ovirt.org/79732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: drop constants.EXT_PYTHON
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: drop constants.EXT_PYTHON .. Patch Set 5: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system tests/job/ovirt-system-tests_manual/855 -- To view, visit https://gerrit.ovirt.org/79733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826a89d4b63f0b4217173795638600a533a82f5c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move constants.P_VDSM_STORAGE to storage.constants .. Patch Set 4: Verified+1 OST is happy http://jenkins.ovirt.org/view/oVirt system tests/job/ovirt-system-tests_manual/855 -- To view, visit https://gerrit.ovirt.org/79741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Makefile: replace astrisks with equal signs
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Makefile: replace astrisks with equal signs .. Patch Set 3: Verified+1 passes CI -- To view, visit https://gerrit.ovirt.org/79750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Makefile: replace astrisks with equal signs
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79750 ) Change subject: Makefile: replace astrisks with equal signs .. Makefile: replace astrisks with equal signs Tripple astrisks are used to mark failures in make and other utilities. Let us use '===' instead for comments. Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Signed-off-by: Dan Kenigsberg --- M tests/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79732 ) Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants .. move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants DOMAIN_VERSIONS and SUPPORTED_DOMAIN_VERSIONS belong to storage subsystem. Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/API.py M lib/vdsm/constants.py.in M lib/vdsm/storage/constants.py M lib/vdsm/storage/hsm.py M lib/vdsm/storage/sd.py 5 files changed, 12 insertions(+), 13 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: drop constants.EXT_PYTHON
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79733 ) Change subject: drop constants.EXT_PYTHON .. drop constants.EXT_PYTHON commands_test and gluster.gfapi's ugly hack can use sys.executable. Change-Id: I826a89d4b63f0b4217173795638600a533a82f5c Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/gluster/gfapi.py M tests/commands_test.py 3 files changed, 5 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I826a89d4b63f0b4217173795638600a533a82f5c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79731 ) Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants .. move constants.SUPPORTED_BLOCKSIZE to storage.constants Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/storage/constants.py M lib/vdsm/storage/lvm.py 3 files changed, 5 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: move constants.P_VDSM_STORAGE to storage.constants
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79741 ) Change subject: move constants.P_VDSM_STORAGE to storage.constants .. move constants.P_VDSM_STORAGE to storage.constants Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Signed-off-by: Dan Kenigsberg --- M lib/vdsm/constants.py.in M lib/vdsm/storage/blockSD.py M lib/vdsm/storage/constants.py M lib/vdsm/storage/fileSD.py M lib/vdsm/storage/sd.py 5 files changed, 9 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/79741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf8cbe4a8c435d93e7683336d5334880de1a811 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org