Re: [VM] Trivial bugs in vm-8.2.0b
Uday, On Tuesday, 2013-07-23 00:36:57 +0100, you wrote: ... The code of `vm-dired-do-attach-files' uses a macro caled `dired-map-over-marks' defined in the Emacs library. There are possibly some problems with the macro. In GNU Emacs, it works fine for me. If you are able to test this function in XEmacs, please let me know if it works. Here's what I got: Loading vm-dired... vm-dired not supported in Emacs version 21.4 (patch 22) Instant Classic XEmacs Lucid Sincerely Rainer -- | Rainer M Woitok| Phone : (+49 60 93) 487 95 95 | | Kolpingstraße 3| Mobile: (+49 172) 813 6 831 | | D-63846 Laufach| Mail : rainer.woi...@gmail.com | | Germany| | --
Re: [VM] Trivial bugs in vm-8.2.0b
John, On Tuesday, 2013-07-23 11:11:13 -0400, John Stoffel wrote: ... Rainer --- vm-reply.el.~1~ 2011-12-28 00:19:28.0 +0200 Rainer +++ vm-reply.el 2013-07-21 19:11:19.95200 +0200 Rainer @@ -1643,6 +1643,7 @@ Rainer(add-hook 'vm-mail-send-hook 'vm-forget-composition-buffer nil t) Rainer(vm-update-ml-composition-buffer-count)) Rainer +;;;###autoload Rainer (defun vm-select-recipient-from-sender () RainerSelect a recipient's address from the current message's sender, if Rainer there is a current message. ... This patch is corrupt and makes no sense, What do you mean by that? I do frankly admit that I'm totally unaware of any unwanted consequences of this change, it definitely WAS a blind shot, but it worked. However, you need not only change vm-reply.el but you must also remove vm.elc from the lisp/ directory, so this file, too, will be compiled again when you run configure. ... So your patch made me interested to fix my vm-reply.el, but I don't see that hook or any of those matching lines in the code. The hooks are irrelevant, because these lines belong to the function be- ing defined ahead of vm-select-recipient-from-sender. Just search vm-reply.el for the string (defun vm-select-recipient-from-sender and then insert ;;;###autoload immediately before this line. Sincerely Rainer -- | Rainer M Woitok| Phone : (+49 60 93) 487 95 95 | | Kolpingstraße 3| Mobile: (+49 172) 813 6 831 | | D-63846 Laufach| Mail : rainer.woi...@gmail.com | | Germany| | --
Re: [VM] Trivial bugs in vm-8.2.0b
Uday, On Sunday, 2013-07-21 19:40:53 +0200, I myself wrote: ... after downloading and compiling vm-8.2.0b (which seems to date back to the end of 2012!) for XEmacs 21.4 There's one thing I forgot to mention: running ./configure ... pro- duced two warnings, and I just cannot tell whether they are trivial and to be ignored or are sort of important: xemacs -batch -no-autoloads -l ./vm-build.el -f batch-byte-compile vm-dired.el Compiling /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el... Loading dired-mule... While compiling vm-dired-do-attach-files in file /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el: ** evaluating (= nil 0): (wrong-type-argument number-char-or-marker-p nil) ** evaluating ( nil 0): (wrong-type-argument number-char-or-marker-p nil) Wrote /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.elc Done Sincerely Rainer -- | Rainer M Woitok| Phone : (+49 60 93) 487 95 95 | | Kolpingstraße 3| Mobile: (+49 172) 813 6 831 | | D-63846 Laufach| Mail : rainer.woi...@gmail.com | | Germany| | --
Re: [VM] Trivial bugs in vm-8.2.0b
Dr Rainer Woitok writes: xemacs -batch -no-autoloads -l ./vm-build.el -f batch-byte-compile vm-dired.el Compiling /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el... Loading dired-mule... While compiling vm-dired-do-attach-files in file /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el: ** evaluating (= nil 0): (wrong-type-argument number-char-or-marker-p nil) ** evaluating ( nil 0): (wrong-type-argument number-char-or-marker-p nil) Wrote /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.elc Done Thanks for reporting. They do look like warnings because the compilation got completed. The code of `vm-dired-do-attach-files' uses a macro caled `dired-map-over-marks' defined in the Emacs library. There are possibly some problems with the macro. In GNU Emacs, it works fine for me. If you are able to test this function in XEmacs, please let me know if it works. Cheers, Uday
