VIRUS with Bram as sender
I should take a little longer checking, but in view of the potential for damage I'm sending a preliminary opinion: A message has just been sent to the vim_multibyte list. Header includes: From: b...@moolenaar.net To: vim-multib...@vim.org Subject: Mail Transaction Failed Date: Thu, 18 Dec 2008 11:12:38 +0200 Body is: The message cannot be represented in 7-bit ASCII encoding and has been sent as a binary attachment. File attached: doc.zip Zip contains single file: doc.pif which is the 'I-Worm/Mytob.AP' virus (for Windows, obviously). Moral of story: - Anyone can send a mail and spoof the From address. - We may see a flurry of viruses sent to various lists. - Particularly Windows users should STOP AND THINK before opening attachments. John --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: 2html.vim support for dynamic folding
Tony Mechelynck, 18.12.2008: On 17/12/08 18:27, Markus Heidelberg wrote: [...] Without a foldcolumn, there is also no hint, whether some text belongs to an open fold or not. I think that's the decisive argument. Something prettier might be found though; maybe a squared plus or minus sign x229E; x229F; or circled x2295; x2296; (plus for a closed fold that can be opened; minus for an open fold that can be closed). This would look more similar to what is used in other software for stuff that can be folded in or out. Given that anything else in the HTML output (also the 'number' option) pretty much reflects the appearance of Vim's window, maybe the foldcolumn should also look the same as in Vim? When typing ^Vu and the codes above in terminal Vim, I always get these squares, i.e. the characters cannot be displayed, in vim -g it works. Is this a font issue? Also, Konqueror displays the squares, but Firefox and Opera get it right. Markus --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: 2html.vim support for dynamic folding
On Thu, Dec 18, 2008 at 8:01 AM, Markus Heidelberg wrote: When typing ^Vu and the codes above in terminal Vim, I always get these squares, i.e. the characters cannot be displayed, in vim -g it works. Is this a font issue? Yes; your font just must be missing those glyphs. Also, Konqueror displays the squares, but Firefox and Opera get it right. Again, just the font being used. ~Matt --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: VIRUS with Bram as sender
On Thu, Dec 18, 2008 at 11:26 AM, John Beckett johnb.beck...@gmail.com wrote: I should take a little longer checking, but in view of the potential for damage I'm sending a preliminary opinion: A message has just been sent to the vim_multibyte list. Header includes: From: b...@moolenaar.net To: vim-multib...@vim.org Subject: Mail Transaction Failed Date: Thu, 18 Dec 2008 11:12:38 +0200 Body is: The message cannot be represented in 7-bit ASCII encoding and has been sent as a binary attachment. File attached: doc.zip Zip contains single file: doc.pif which is the 'I-Worm/Mytob.AP' virus (for Windows, obviously). Moral of story: - Anyone can send a mail and spoof the From address. - We may see a flurry of viruses sent to various lists. - Particularly Windows users should STOP AND THINK before opening attachments. John Bram's funny signatures is not in the email: it's not from him. Side note: windows users should compile their own binaries :) -- Christian -- http://detaolb.sourceforge.net/, a linux distribution for Qemu with Git inside ! --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: E685, SEGV - a:000 garbage collected too early?
Bram Moolenaar skribis:
Matt Wozniski wrote:
function! ReturnArgs(...)
return a:000
endfunction
Seems to work fine?
echo ReturnArgs(1, 2, 3)
SEGV
echo string(ReturnArgs(1, 2, 3))
function! MakeArgsDict(...)
return { 'args': a:000 }
endfunction
E685 Internal Error
echo MakeArgsDict(1, 2, 3)
SEGV
echo string(MakeArgsDict(1, 2, 3))
For it crashes a while after trying these things. Most likely the
reference count for a:000 is wrong. Never thought of someone returning
it...
[...]
I have made a patch to fix this. It's complicated stuff, I hope I
thought of everything that could possibly go wrong, including memory
leaks.
Dominique, can you try including the patch and running valgrind? And
check for memory leaks?
It looks good to me. Patch fixes the bug and I can't see any error
or leak with valgrind memory checker. I tried all test cases reported
by Matt Wozniski, as well as make test (all tests passed).
-- Dominique
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Re: fold-delete-marker SEGV fix
Lech Lorens skribis: Problem: The cursor position is not updated after deleting a fold based on markers. This results in an invalid memory reference in some scenarios. How to reproduce: In normal mode perform zRgg$zdaa while editing a file with the following contents: [[[ blah blah blah ]]] vim: fdm=marker fmr=[[[,]]] Fix: The attached patch seems to fix the problem. I can reproduce the bug that you describe with vim-7.2.69. Although it does not crash for me, just after typing 'zd' in 'zRgg$zdaa' valgrind reports the following error: ==15028== Invalid read of size 1 ==15028==at 0x813F67B: utf_head_off (mbyte.c:2498) ==15028==by 0x813FDF5: mb_adjustpos (mbyte.c:2791) ==15028==by 0x813FDA2: mb_adjust_cursor (mbyte.c:2771) ==15028==by 0x81439CB: normal_cmd (normal.c:1339) ==15028==by 0x8106A71: main_loop (main.c:1180) ==15028==by 0x81065BE: main (main.c:939) ==15028== Address 0x677bc71 is 1 bytes after a block of size 4,096 alloc'd ==15028==at 0x4025D2E: malloc (vg_replace_malloc.c:207) ==15028==by 0x8133F88: lalloc (misc2.c:859) ==15028==by 0x8133EA4: alloc (misc2.c:758) ==15028==by 0x8113D37: mf_alloc_bhdr (memfile.c:973) ==15028==by 0x8113357: mf_new (memfile.c:395) ==15028==by 0x8119235: ml_new_data (memline.c:3164) ==15028==by 0x811484B: ml_open (memline.c:373) ==15028==by 0x8073C80: open_buffer (buffer.c:85) ==15028==by 0x810863B: create_windows (main.c:2483) ==15028==by 0x8106351: main (main.c:798) I confirm that your patch fixes it. -- Dominique --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: E685, SEGV - a:000 garbage collected too early?
Dominique Pelle wrote:
Bram Moolenaar skribis:
Matt Wozniski wrote:
function! ReturnArgs(...)
return a:000
endfunction
Seems to work fine?
echo ReturnArgs(1, 2, 3)
SEGV
echo string(ReturnArgs(1, 2, 3))
function! MakeArgsDict(...)
return { 'args': a:000 }
endfunction
E685 Internal Error
echo MakeArgsDict(1, 2, 3)
SEGV
echo string(MakeArgsDict(1, 2, 3))
For it crashes a while after trying these things. Most likely the
reference count for a:000 is wrong. Never thought of someone returning
it...
[...]
I have made a patch to fix this. It's complicated stuff, I hope I
thought of everything that could possibly go wrong, including memory
leaks.
Dominique, can you try including the patch and running valgrind? And
check for memory leaks?
It looks good to me. Patch fixes the bug and I can't see any error
or leak with valgrind memory checker. I tried all test cases reported
by Matt Wozniski, as well as make test (all tests passed).
Thanks for checking this. I'll have last look at it and send it out
soon.
--
ARTHUR: No, hang on! Just answer the five questions ...
GALAHAD: Three questions ...
ARTHUR: Three questions ... And we shall watch ... and pray.
Monty Python and the Holy Grail PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Re: fold-delete-marker SEGV fix
Lech Lorens wrote: Problem: The cursor position is not updated after deleting a fold based on markers. This results in an invalid memory reference in some scenarios. How to reproduce: In normal mode perform zRgg$zdaa while editing a file with the following contents: [[[ blah blah blah ]]] vim: fdm=marker fmr=[[[,]]] Fix: The attached patch seems to fix the problem. Thanks! I'll put it at the top of my todo list. -- Q: Why does /dev/null accept only integers? A: You can't sink a float. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: VIRUS with Bram as sender
On 18/12/08 11:26, John Beckett wrote: I should take a little longer checking, but in view of the potential for damage I'm sending a preliminary opinion: A message has just been sent to the vim_multibyte list. Header includes: From: b...@moolenaar.net To: vim-multib...@vim.org Subject: Mail Transaction Failed Date: Thu, 18 Dec 2008 11:12:38 +0200 Body is: The message cannot be represented in 7-bit ASCII encoding and has been sent as a binary attachment. File attached: doc.zip Zip contains single file: doc.pif which is the 'I-Worm/Mytob.AP' virus (for Windows, obviously). Moral of story: - Anyone can send a mail and spoof the From address. - We may see a flurry of viruses sent to various lists. - Particularly Windows users should STOP AND THINK before opening attachments. John Note that unlike Bram's usual mailings, this one has a naked email address as the from-line. I moved it aside to a Spam - or not? mailbox folder without opening. The fact that I'm on Linux makes me immune to some common viruses, but the first step in protection against malware is to avoid opening just any unusual mail. This applies to all platforms whatsoever. Best regards, Tony. -- Our vision is to speed up time, eventually eliminating it. -- Alex Schure --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: VIRUS with Bram as sender
On 18/12/08 17:22, Christian MICHON wrote: [...] Bram's funny signatures is not in the email: it's not from him. Right. Side note: windows users should compile their own binaries :) Not necessarily: Steve Hall's Vim distributions https://sourceforge.net/project/showfiles.php?group_id=43866package_id=39721 are a reliable source of Vim executables for Windows. It is of course /possible/ to compile one's own binaries (I've even written a couple of HowTo pages on the subject). Best regards, Tony. -- All of the true things I am about to tell you are shameless lies. -- The Book of Bokonon / Kurt Vonnegut Jr. --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: 2html.vim support for dynamic folding
On 18/12/08 14:01, Markus Heidelberg wrote: Tony Mechelynck, 18.12.2008: On 17/12/08 18:27, Markus Heidelberg wrote: [...] Without a foldcolumn, there is also no hint, whether some text belongs to an open fold or not. I think that's the decisive argument. Something prettier might be found though; maybe a squared plus or minus signx229E;x229F; or circled x2295;x2296; (plus for a closed fold that can be opened; minus for an open fold that can be closed). This would look more similar to what is used in other software for stuff that can be folded in or out. Given that anything else in the HTML output (also the 'number' option) pretty much reflects the appearance of Vim's window, maybe the foldcolumn should also look the same as in Vim? When typing ^Vu and the codes above in terminal Vim, I always get these squares, i.e. the characters cannot be displayed, in vim -g it works. Is this a font issue? I think so, yes. I'm using gvim with GTK2 GUI so glyphs not found in my 'guifont' (Bitstream Vera Sans Mono 8) are borrowed from other installed fonts. In Console Vim you're dependent on the terminal for the font, and a non-Unicode terminal can't display the above special characters anyway. Also, Konqueror displays the squares, but Firefox and Opera get it right. That proves you've got at least one font with the appropriate glyphs. I don't know about Opera, but Firefox (like my gvim) uses GTK2, Pango, and the like (as shown in about:buildconfig ) so it will borrow glyphs the same way. KDE programs (like Konqueror), OTOH, use Qt to interface with the screen, and I don't know how /that/ works. You might try to compare the font settings of your various browsers. Here too, I see the correct glyphs in SeaMonkey 2.0a3pre (based on the same Gecko rendering engine as Firefox 3.1b3pre), but not in Konqueror 3.5.10. Markus Best regards, Tony. -- Futility Factor: No experiment is ever a complete failure - it can always serve as a negative example. --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: fold-delete-marker SEGV fix
On Thu, 18 Dec 2008 20:45:02 +0100, Dominique Pelle wrote: I can reproduce the bug that you describe with vim-7.2.69. On Windows 98, gVim 7.2.69 crashes: GVIM a causé une défaillance de page dans le module GVIM.EXE à 0167:0051b586. I confirm that your patch fixes it. Yes. -- Patrick Texier --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: 2html.vim support for dynamic folding
Ben Fritz, 18.12.2008: On Dec 18, 7:01 am, Markus Heidelberg markus.heidelb...@web.de wrote: Given that anything else in the HTML output (also the 'number' option) pretty much reflects the appearance of Vim's window, maybe the foldcolumn should also look the same as in Vim? That's what I was thinking. However, it would certainly be easier to code (and potentially to interact with) if the foldcolumn width would just grow to accommodate the highest fold level. What do people think...should 'foldcolumn' be used for the width of the fold column, complete with a duplication of Vim's foldcolumn text, or should it just grow as needed? I didn't yet consider this case for the appearance reflection, but the color and characters used. It should grow. We need to have every fold level on the fold column, else we can't solve the problem of unknown open folds. Maybe foldcolumn=foldlevel+1 to have one space between the column and the text. When typing ^Vu and the codes above in terminal Vim, I always get these squares, i.e. the characters cannot be displayed, in vim -g it works. Is this a font issue? Also, Konqueror displays the squares, but Firefox and Opera get it right. I think we should try to create a page that doesn't depend on the font being used (beyond the fact that it should be fixed-width, of course). Yes, I also think so. Using '+' '-' '|' will work everywhere. Markus --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
