Re: Adding to quickfix list issue

2016-04-18 Fir de Conversatie Ramel Eshed
On Monday, April 18, 2016 at 9:39:15 AM UTC+3, Bram Moolenaar wrote:
> Yegappan Lakshmanan wrote:
> 
> > On Sun, Apr 17, 2016 at 11:38 AM, Yegappan Lakshmanan
> >  wrote:
> > > Hi,
> > >
> > > On Sun, Apr 17, 2016 at 3:35 AM, Ramel Eshed  wrote:
> > >> On Sunday, April 17, 2016 at 3:12:55 AM UTC+3, yega...@gmail.com wrote:
> > >>> Hi,
> > >>>
> > >>> On Sat, Apr 16, 2016 at 3:43 PM, Yegappan Lakshmanan
> > >>>  wrote:
> > >>> > Hi,
> > >>> >
> > >>> > On Sat, Apr 16, 2016 at 12:52 PM, Ramel Eshed  wro=
> > te:
> > >>> >> Adding an item to the current quickfix list causes a jump to the fir=
> > st item rather than keeping the current context:
> > >>> >>
> > >>> >> Download the attached file;
> > >>> >> vim -u NONE -N
> > >>> >> :source qf_test.vim
> > >>> >>
> > >>> >> -After adding 2 items, :cn, adding one more item and another :cn we =
> > are in (2 of 3) instead of (3 of 3).
> > >>> >>
> > >>> >
> > >>> > The setqflist() function resets the index of the quickfix list so tha=
> > t it
> > >>> > points to the first entry (even if entries are appended to the list).
> > >>> >
> > >>> > Due to a bug in the set_errorlist() function, the index is set to 1 i=
> > nstead
> > >>> > of zero. That is why, you saw 2 of 3 instead of 1 of 3.
> > >>> >
> > >>>
> > >>> The quickfix index is 1 based and not zero based. The current code corr=
> > ectly
> > >>> sets the index to 1. So there is no bug in the current code.
> > >>>
> > >>> The documentation for the setqflist() function needs to be updated to
> > >>> state that it will reset to the first valid entry.
> > >>>
> > >>> - Yegappan
> > >>
> > >> Is there any reason to reset the pointer each time? I think that it is
> > >> more reasonable to leave the pointer as it when adding to the list so
> > >> it=E2=80=99d be possible to work with the list and adding new items to i=
> > t when
> > >> they=E2=80=99re available without losing the context.
> > >>
> > >
> > > Agreed. I will send out a patch later today for this.
> > 
> > A patch with tests is attached.
> 
> Thanks!
> 
> -- 
> I'd like to meet the man who invented sex and see what he's working on now.
> 
>  /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
> ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
> \\\  an exciting new programming language -- http://www.Zimbu.org///
>  \\\help me help AIDS victims -- http://ICCF-Holland.org///

Thanks for the patch, it solved the issues I had.

I wrote a simple async grep plugin and I'm able to update the quickfix list on 
the fly now, but I ran into some performance issues which are probably caused 
by the internal quickfix implementation. I'll try to elaborate more on this 
tomorrow.

Ramel

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Asynchronous screen update

2016-04-18 Fir de Conversatie Ramel Eshed
On Monday, April 18, 2016 at 8:35:18 PM UTC+3, Bram Moolenaar wrote:
> Ramel Eshed wrote:
> 
> > On Sunday, April 17, 2016 at 11:33:50 AM UTC+3, Bram Moolenaar wrote:
> > > Ramel Eshed wrote:
> > > 
> > > > When using “out_io”: “buffer” in the job options there are some issues
> > > > with the screen rendering. The first one is when I try to edit the
> > > > command line while the job’s buffer is being updated; As long as there
> > > > is room in the job’s window the only problem is that I don’t see the
> > > > cursor in the command-line. When Vim starts scrolling the job’s window
> > > > the entire content of the command-line disappears with every screen
> > > > update.
> > > 
> > > So we need to skip the display update if the screen is scrolled.
> > > And put the cursor in the command line.
> > > 
> > > > - Another issue which is easier to notice on GVim is the toggling of
> > > > the cursor between the job’s buffer and the current buffer. I’m not
> > > > familiar with the implementation, but I guess that in order to update
> > > > the job’s buffer Vim needs to actually move to that buffer. I remember
> > > > a discussion about adding a proper setbufline() function. I think that
> > > > it might be very useful, especially now when combined with the new
> > > > async features.
> > > > 
> > > > To reproduce:
> > > > Save the attached file in your home directory.
> > > > 
> > > > vim –u NONE -N
> > > > :new
> > > > :let job = job_start(['/bin/tcsh', '-c', '~/async_test.csh'], 
> > > > {'out_io': 'buffer', 'out_buf':1})
> > > > 
> > > > Now try to type in the command line.
> > > > Do the same with GVim to see the cursor toggling issue.
> > > > 
> > > > I'm using Vim 7.4.1747 on RHEL 5.5.
> > > 
> > > What do you mean with "cursor toggling issue"?
> >
> > It looks like the cursor is in some sort of superposition –In my example
> > there are 2 windows; The upper window is the one I'm working in and the
> > bottom window is being updated with the job’s output constantly. The cursor
> > keeps jumping between the two windows so it’s hard to keep working like 
> > that.
> > When running Vim inside a terminal this isn’t very noticeable, so it almost
> > looks like the cursor stays in the upper buffer, which I think should be the
> > correct behavior. Now, the feeling is not so "asynchronous", because the
> > job's buffer updates interfere with the normal work in the other window.
> 
> Can you check if patch 7.4.1750 fixed this problem as well?
> 
> -- 
> You got to work at a mill?  Lucky!  I got sent back to work in the
> acid-mines for my daily crust of stale bread... which not even the
> birds would eat.
> 
>  /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
> ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
> \\\  an exciting new programming language -- http://www.Zimbu.org///
>  \\\help me help AIDS victims -- http://ICCF-Holland.org///

Hi Bram,

It looks great in the terminal now and it really gives you the "asynchronous" 
feel. The gui is also much better now, but the cursor blinking pace is 
irregular (sometimes it blinks rapidly or doesn't blink at all). It could be 
disturbing for long periods.

Thanks!
Ramel

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1751

2016-04-18 Fir de Conversatie Nikolay Aleksandrovich Pavlov
2016-04-18 21:25 GMT+03:00 Bram Moolenaar :
>
> Kazunobu wrote:
>
>> It looks src/testdir/test_tagjump.vim is missing in the GitHub repo.
>>
>> This is shown in the repo as patch 7.4.1751:
>> https://github.com/vim/vim/commit/def5abe0a2727041ecee69afdccfca405333bd24
>
> git add
> git add
> git add
> git add
> git add
> git add
> git add
> git add
> git add
>
> Keep forgetting that.

This is what CI service is for. Neovim master is never directly pushed
to, PR is created first and then it would not be merged until tests
pass unless there are good reasons to ignore failures (e.g. after
linter update new linter errors are ignored to be silenced when they
appear in master).

Vim has CI, but this is not very useful if CI runs tests after error
appears in master (and is sent as a patch) and not before.

>
> --
> Not too long ago, cut and paste was done with scissors and glue...
>
>  /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
> ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
> \\\  an exciting new programming language -- http://www.Zimbu.org///
>  \\\help me help AIDS victims -- http://ICCF-Holland.org///
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups 
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub vim scripts - duplicate of vim.org

2016-04-18 Fir de Conversatie Bram Moolenaar

> I notice all the vim script on vim.org seem to be duplicated under:
> https://github.com/vim-scripts
> 
> Is this something Vim has done, or is this an independent process?

AFAIK this is an automated script setup by someone.  Don't see a name
anywhere.

> The reason I ask, is there are lots of comments and pull requests against
> my plugins.  Given I do not own that account, all I can do is comment on
> the site, rather than accept pulls and close issues and so on.
> 
> I am relatively new to GitHub, is there a process other people follow that
> makes sense to deal with a community forming around this?

The person behind vim-scripts needs to set this up properly.
You can send a message to one of the addresses mentioned on the website.
Then you'' find out if there is still someone actually looking at this.

-- 
Q:  Why do ducks have flat feet?
A:  To stamp out forest fires.

Q:  Why do elephants have flat feet?
A:  To stamp out flaming ducks.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1751

2016-04-18 Fir de Conversatie Bram Moolenaar

Kazunobu wrote:

> It looks src/testdir/test_tagjump.vim is missing in the GitHub repo.
> 
> This is shown in the repo as patch 7.4.1751:
> https://github.com/vim/vim/commit/def5abe0a2727041ecee69afdccfca405333bd24

git add
git add
git add
git add
git add
git add
git add
git add
git add

Keep forgetting that.

-- 
Not too long ago, cut and paste was done with scissors and glue...

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub vim scripts - duplicate of vim.org

2016-04-18 Fir de Conversatie Christian Brabandt
Hi David!

On Mo, 18 Apr 2016, David Fishburn wrote:

> I notice all the vim script on vim.org seem to be duplicated under:
> https://github.com/vim-scripts
> 
> Is this something Vim has done, or is this an independent process?
> 
> The reason I ask, is there are lots of comments and pull requests against my
> plugins.  Given I do not own that account, all I can do is comment on the 
> site,
> rather than accept pulls and close issues and so on.
> 
> I am relatively new to GitHub, is there a process other people follow that
> makes sense to deal with a community forming around this?

I think this has been done, to provide easy access for plugin managers 
like vundle.

See also here:
http://vim-scripts.org/

Perhaps you can create an issue there and ask how to handle that 
situation the best?

Best,
Christian
-- 
Genieße Deinen Urlaub in vollen Zügen - fahre mit der Bahn.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub vim scripts - duplicate of vim.org

2016-04-18 Fir de Conversatie Nikolay Aleksandrovich Pavlov
2016-04-18 21:02 GMT+03:00 David Fishburn :
> I notice all the vim script on vim.org seem to be duplicated under:
> https://github.com/vim-scripts
>
> Is this something Vim has done, or is this an independent process?
>
> The reason I ask, is there are lots of comments and pull requests against my
> plugins.  Given I do not own that account, all I can do is comment on the
> site, rather than accept pulls and close issues and so on.
>
> I am relatively new to GitHub, is there a process other people follow that
> makes sense to deal with a community forming around this?

You need to be reachable by means described in plugin description
(i.e. github/bitbucket/…: something public, not something like email)
for this to stop and transfer there. vim-scripts is not official
(group which created this user does not contain Bram), but it is used
by a number of plugins.

>
> Thanks,
> David
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


GitHub vim scripts - duplicate of vim.org

2016-04-18 Fir de Conversatie David Fishburn
I notice all the vim script on vim.org seem to be duplicated under:
https://github.com/vim-scripts

Is this something Vim has done, or is this an independent process?

The reason I ask, is there are lots of comments and pull requests against
my plugins.  Given I do not own that account, all I can do is comment on
the site, rather than accept pulls and close issues and so on.

I am relatively new to GitHub, is there a process other people follow that
makes sense to deal with a community forming around this?

Thanks,
David

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1751

2016-04-18 Fir de Conversatie Kazunobu Kuriyama
Hi,

It looks src/testdir/test_tagjump.vim is missing in the GitHub repo.

This is shown in the repo as patch 7.4.1751:
https://github.com/vim/vim/commit/def5abe0a2727041ecee69afdccfca405333bd24

Regards,
Kazunobu

2016-04-19 2:47 GMT+09:00 Bram Moolenaar :

>
> Patch 7.4.1751
> Problem:Crash when 'tagstack' is off. (Dominique Pelle)
> Solution:   Fix it. (Hirohito Higashi)
> Files:  src/tag.c, src/testdir/test_alot.vim,
> src/testdir/test_tagjump.vim
>
>
> *** ../vim-7.4.1750/src/tag.c   2016-04-08 17:07:09.546160667 +0200
> --- src/tag.c   2016-04-18 19:42:47.832567910 +0200
> ***
> *** 200,205 
> --- 200,213 
>   {
> use_tagstack = FALSE;
> new_tag = TRUE;
> + #if defined(FEAT_WINDOWS) && defined(FEAT_QUICKFIX)
> +   if (g_do_tagpreview != 0)
> +   {
> +   vim_free(ptag_entry.tagname);
> +   if ((ptag_entry.tagname = vim_strsave(tag)) == NULL)
> +   goto end_do_tag;
> +   }
> + #endif
>   }
>   else
>   {
> *** ../vim-7.4.1750/src/testdir/test_alot.vim   2016-04-16
> 09:13:31.538407268 +0200
> --- src/testdir/test_alot.vim   2016-04-18 19:41:12.433551221 +0200
> ***
> *** 27,32 
> --- 27,33 
>   source test_statusline.vim
>   source test_syn_attr.vim
>   source test_tabline.vim
> + source test_tagjump.vim
>   source test_timers.vim
>   source test_undolevels.vim
>   source test_unlet.vim
> *** ../vim-7.4.1750/src/testdir/test_tagjump.vim2016-04-18
> 19:44:12.251697803 +0200
> --- src/testdir/test_tagjump.vim2016-04-18 19:41:12.437551179 +0200
> ***
> *** 0 
> --- 1,9 
> + " Tests for tagjump (tags and special searches)
> +
> + " SEGV occurs in older versions.  (At least 7.4.1748 or older)
> + func Test_ptag_with_notagstack()
> +   set notagstack
> +   call assert_fails('ptag does_not_exist_tag_name', 'E426')
> +   set tagstack
> + endfunc
> + " vim: sw=2 et
> *** ../vim-7.4.1750/src/version.c   2016-04-18 19:27:18.026188419 +0200
> --- src/version.c   2016-04-18 19:43:38.084049965 +0200
> ***
> *** 750,751 
> --- 750,753 
>   {   /* Add new patch number below this line */
> + /**/
> + 1751,
>   /**/
>
> --
> Luxury. We used to have to get out of the lake at three o'clock in the
> morning, clean the lake, eat a handful of hot gravel, go to work at the
> mill every day for tuppence a month, come home, and Dad would beat us
> around the head and neck with a broken bottle, if we were LUCKY!
>
>  /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net
>  \\\
> ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/
> \\\
> \\\  an exciting new programming language -- http://www.Zimbu.org
> ///
>  \\\help me help AIDS victims -- http://ICCF-Holland.org
> ///
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 7.4.1752

2016-04-18 Fir de Conversatie Bram Moolenaar

Patch 7.4.1752
Problem:When adding to the quickfix list the current position is reset.
Solution:   Do not reset the position when not needed. (Yegappan Lakshmanan)
Files:  src/quickfix.c, src/testdir/test_quickfix.vim


*** ../vim-7.4.1751/src/quickfix.c  2016-03-27 18:44:36.823626960 +0200
--- src/quickfix.c  2016-04-18 20:01:49.956798364 +0200
***
*** 126,132 
  static intis_qf_win(win_T *win, qf_info_T *qi);
  static win_T  *qf_find_win(qf_info_T *qi);
  static buf_T  *qf_find_buf(qf_info_T *qi);
! static void   qf_update_buffer(qf_info_T *qi);
  static void   qf_set_title_var(qf_info_T *qi);
  static void   qf_fill_buffer(qf_info_T *qi);
  #endif
--- 126,132 
  static intis_qf_win(win_T *win, qf_info_T *qi);
  static win_T  *qf_find_win(qf_info_T *qi);
  static buf_T  *qf_find_buf(qf_info_T *qi);
! static void   qf_update_buffer(qf_info_T *qi, int update_cursor);
  static void   qf_set_title_var(qf_info_T *qi);
  static void   qf_fill_buffer(qf_info_T *qi);
  #endif
***
*** 880,886 
  vim_free(fmtstr);
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi);
  #endif
  
  return retval;
--- 880,886 
  vim_free(fmtstr);
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi, TRUE);
  #endif
  
  return retval;
***
*** 2176,2182 
qi->qf_curlist + 1, qi->qf_listcount,
qi->qf_lists[qi->qf_curlist].qf_count);
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi);
  #endif
  }
  
--- 2176,2182 
qi->qf_curlist + 1, qi->qf_listcount,
qi->qf_lists[qi->qf_curlist].qf_count);
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi, TRUE);
  #endif
  }
  
***
*** 2606,2612 
   * Find the quickfix buffer.  If it exists, update the contents.
   */
  static void
! qf_update_buffer(qf_info_T *qi)
  {
  buf_T *buf;
  win_T *win;
--- 2606,2612 
   * Find the quickfix buffer.  If it exists, update the contents.
   */
  static void
! qf_update_buffer(qf_info_T *qi, int update_cursor)
  {
  buf_T *buf;
  win_T *win;
***
*** 2633,2639 
/* restore curwin/curbuf and a few other things */
aucmd_restbuf();
  
!   (void)qf_win_pos_update(qi, 0);
  }
  }
  
--- 2633,2640 
/* restore curwin/curbuf and a few other things */
aucmd_restbuf();
  
!   if (update_cursor)
!   (void)qf_win_pos_update(qi, 0);
  }
  }
  
***
*** 3675,3681 
  qi->qf_lists[qi->qf_curlist].qf_index = 1;
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi);
  #endif
  
  #ifdef FEAT_AUTOCMD
--- 3676,3682 
  qi->qf_lists[qi->qf_curlist].qf_index = 1;
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi, TRUE);
  #endif
  
  #ifdef FEAT_AUTOCMD
***
*** 4115,4126 
qi->qf_lists[qi->qf_curlist].qf_nonevalid = TRUE;
  else
qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
! qi->qf_lists[qi->qf_curlist].qf_ptr = 
qi->qf_lists[qi->qf_curlist].qf_start;
! if (qi->qf_lists[qi->qf_curlist].qf_count > 0)
!   qi->qf_lists[qi->qf_curlist].qf_index = 1;
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi);
  #endif
  
  return retval;
--- 4116,4131 
qi->qf_lists[qi->qf_curlist].qf_nonevalid = TRUE;
  else
qi->qf_lists[qi->qf_curlist].qf_nonevalid = FALSE;
! if (action != 'a') {
!   qi->qf_lists[qi->qf_curlist].qf_ptr =
!   qi->qf_lists[qi->qf_curlist].qf_start;
!   if (qi->qf_lists[qi->qf_curlist].qf_count > 0)
!   qi->qf_lists[qi->qf_curlist].qf_index = 1;
! }
  
  #ifdef FEAT_WINDOWS
! /* Don't update the cursor in quickfix window when appending entries */
! qf_update_buffer(qi, (action != 'a'));
  #endif
  
  return retval;
***
*** 4427,4433 
free_string_option(save_cpo);
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi);
  #endif
  
  #ifdef FEAT_AUTOCMD
--- 4432,4438 
free_string_option(save_cpo);
  
  #ifdef FEAT_WINDOWS
! qf_update_buffer(qi, TRUE);
  #endif
  
  #ifdef FEAT_AUTOCMD
*** ../vim-7.4.1751/src/testdir/test_quickfix.vim   2016-03-27 
18:44:36.827626918 +0200
--- src/testdir/test_quickfix.vim   2016-04-18 20:01:04.313268630 +0200
***
*** 697,699 
--- 697,747 
" this must not crash Vim
cgetexpr [$x]
  endfunc
+ 
+ " Tests for the setqflist() and setloclist() functions
+ function SetXlistTests(cchar, bnum)
+   if a:cchar == 'c'
+ let Xsetlist = function('setqflist')
+ let Xgetlist = function('getqflist')
+ let Xnext = 'cnext'
+   else
+ let Xsetlist = function('setloclist', [0])
+ let Xgetlist = function('getloclist', [0])
+ let Xnext = 'lnext'
+   endif
+ 
+   call Xsetlist([{'bufnr': a:bnum, 'lnum': 1},
+ \  {'bufnr': a:bnum, 'lnum': 2}])
+   let l = Xgetlist()
+   call assert_equal(2, len(l))
+   call assert_equal(2, l[1].lnum)
+ 
+   exe 

Patch 7.4.1751

2016-04-18 Fir de Conversatie Bram Moolenaar

Patch 7.4.1751
Problem:Crash when 'tagstack' is off. (Dominique Pelle)
Solution:   Fix it. (Hirohito Higashi)
Files:  src/tag.c, src/testdir/test_alot.vim, src/testdir/test_tagjump.vim


*** ../vim-7.4.1750/src/tag.c   2016-04-08 17:07:09.546160667 +0200
--- src/tag.c   2016-04-18 19:42:47.832567910 +0200
***
*** 200,205 
--- 200,213 
  {
use_tagstack = FALSE;
new_tag = TRUE;
+ #if defined(FEAT_WINDOWS) && defined(FEAT_QUICKFIX)
+   if (g_do_tagpreview != 0)
+   {
+   vim_free(ptag_entry.tagname);
+   if ((ptag_entry.tagname = vim_strsave(tag)) == NULL)
+   goto end_do_tag;
+   }
+ #endif
  }
  else
  {
*** ../vim-7.4.1750/src/testdir/test_alot.vim   2016-04-16 09:13:31.538407268 
+0200
--- src/testdir/test_alot.vim   2016-04-18 19:41:12.433551221 +0200
***
*** 27,32 
--- 27,33 
  source test_statusline.vim
  source test_syn_attr.vim
  source test_tabline.vim
+ source test_tagjump.vim
  source test_timers.vim
  source test_undolevels.vim
  source test_unlet.vim
*** ../vim-7.4.1750/src/testdir/test_tagjump.vim2016-04-18 
19:44:12.251697803 +0200
--- src/testdir/test_tagjump.vim2016-04-18 19:41:12.437551179 +0200
***
*** 0 
--- 1,9 
+ " Tests for tagjump (tags and special searches)
+ 
+ " SEGV occurs in older versions.  (At least 7.4.1748 or older)
+ func Test_ptag_with_notagstack()
+   set notagstack
+   call assert_fails('ptag does_not_exist_tag_name', 'E426')
+   set tagstack
+ endfunc
+ " vim: sw=2 et
*** ../vim-7.4.1750/src/version.c   2016-04-18 19:27:18.026188419 +0200
--- src/version.c   2016-04-18 19:43:38.084049965 +0200
***
*** 750,751 
--- 750,753 
  {   /* Add new patch number below this line */
+ /**/
+ 1751,
  /**/

-- 
Luxury. We used to have to get out of the lake at three o'clock in the 
morning, clean the lake, eat a handful of hot gravel, go to work at the 
mill every day for tuppence a month, come home, and Dad would beat us 
around the head and neck with a broken bottle, if we were LUCKY!

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [vim/vim] sh syntax hightlight breaks on "${VAR/FOO/\\[}" (#759)

2016-04-18 Fir de Conversatie Gary Johnson
On 2016-04-18, Charles Campbell wrote:
> Alexander Meshcheryakov wrote:
> > "${VAR/FOO/\\[}"
> >
> > is a bashism to substitute |'FOO'| in |$VAR| with |'\['|
> > vim fails to notice trailing double quote and the of a script becomes
> > highlighted as doublequoted. Demo script to check highlighting:
> >
> > #!/bin/bash
> > VAR1=FOOBAR
> > VAR2="${VAR1/FOO/\\[}"
> > echo "$VAR2"
> Please try sh.vim v148-ASTRO-ONLY from
> http://www.drchip.org/astronaut/vim/index.html#SYNTAX_SH .

In the following line,

set -o ignoreeof# Don't let Ctrl-D exit the shell.

the "#" and the text following it is not recognized as a comment.
Instead, it is being recognized and highlighted as part of the set
command as follows.

set shSet
-o  shSetOption
ignoreeof   shSetList
# Don   shSetList
# ' shQuote
t let Ctrl-D exit the shell.shSingleQuote

This issue has been around for a while.  I was just reminded of it
when I tried out the latest syntax/sh.vim.

Regards,
Gary

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Asynchronous screen update

2016-04-18 Fir de Conversatie Bram Moolenaar

Ramel Eshed wrote:

> On Sunday, April 17, 2016 at 11:33:50 AM UTC+3, Bram Moolenaar wrote:
> > Ramel Eshed wrote:
> > 
> > > When using “out_io”: “buffer” in the job options there are some issues
> > > with the screen rendering. The first one is when I try to edit the
> > > command line while the job’s buffer is being updated; As long as there
> > > is room in the job’s window the only problem is that I don’t see the
> > > cursor in the command-line. When Vim starts scrolling the job’s window
> > > the entire content of the command-line disappears with every screen
> > > update.
> > 
> > So we need to skip the display update if the screen is scrolled.
> > And put the cursor in the command line.
> > 
> > > - Another issue which is easier to notice on GVim is the toggling of
> > > the cursor between the job’s buffer and the current buffer. I’m not
> > > familiar with the implementation, but I guess that in order to update
> > > the job’s buffer Vim needs to actually move to that buffer. I remember
> > > a discussion about adding a proper setbufline() function. I think that
> > > it might be very useful, especially now when combined with the new
> > > async features.
> > > 
> > > To reproduce:
> > > Save the attached file in your home directory.
> > > 
> > > vim –u NONE -N
> > > :new
> > > :let job = job_start(['/bin/tcsh', '-c', '~/async_test.csh'], {'out_io': 
> > > 'buffer', 'out_buf':1})
> > > 
> > > Now try to type in the command line.
> > > Do the same with GVim to see the cursor toggling issue.
> > > 
> > > I'm using Vim 7.4.1747 on RHEL 5.5.
> > 
> > What do you mean with "cursor toggling issue"?
>
> It looks like the cursor is in some sort of superposition –In my example
> there are 2 windows; The upper window is the one I'm working in and the
> bottom window is being updated with the job’s output constantly. The cursor
> keeps jumping between the two windows so it’s hard to keep working like that.
> When running Vim inside a terminal this isn’t very noticeable, so it almost
> looks like the cursor stays in the upper buffer, which I think should be the
> correct behavior. Now, the feeling is not so "asynchronous", because the
> job's buffer updates interfere with the normal work in the other window.

Can you check if patch 7.4.1750 fixed this problem as well?

-- 
You got to work at a mill?  Lucky!  I got sent back to work in the
acid-mines for my daily crust of stale bread... which not even the
birds would eat.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 7.4.1750

2016-04-18 Fir de Conversatie Bram Moolenaar

Patch 7.4.1750
Problem:When a buffer gets updated while in command line mode, the screen
may be messed up.
Solution:   Postpone the redraw when the screen is scrolled.
Files:  src/channel.c


*** ../vim-7.4.1749/src/channel.c   2016-04-14 12:46:33.608678731 +0200
--- src/channel.c   2016-04-18 19:24:36.775860968 +0200
***
*** 1431,1436 
--- 1431,1437 
  
  /*
   * Invoke the "callback" on channel "channel".
+  * This does not redraw but sets channel_need_redraw;
   */
  static void
  invoke_callback(channel_T *channel, char_u *callback, partial_T *partial,
***
*** 1445,1452 
  call_func(callback, (int)STRLEN(callback),
, 2, argv, 0L, 0L, , TRUE, partial, NULL);
  clear_tv();
! 
! redraw_after_callback();
  }
  
  /*
--- 1446,1452 
  call_func(callback, (int)STRLEN(callback),
, 2, argv, 0L, 0L, , TRUE, partial, NULL);
  clear_tv();
! channel_need_redraw = TRUE;
  }
  
  /*
***
*** 2009,2014 
--- 2009,2018 
  }
  }
  
+ /*
+  * Invoke the callback at "cbhead".
+  * Does not redraw but sets channel_need_redraw.
+  */
  static void
  invoke_one_time_callback(
channel_T   *channel,
***
*** 2099,2104 
--- 2103,2109 
  
  /*
   * Invoke a callback for "channel"/"part" if needed.
+  * This does not redraw but sets channel_need_redraw when redraw is needed.
   * Return TRUE when a message was handled, there might be another one.
   */
  static int
***
*** 3468,3480 
}
  }
  
! if (channel_need_redraw && must_redraw)
  {
channel_need_redraw = FALSE;
!   update_screen(0);
!   setcursor();
!   cursor_on();
!   out_flush();
  }
  
  return ret;
--- 3473,3482 
}
  }
  
! if (channel_need_redraw)
  {
channel_need_redraw = FALSE;
!   redraw_after_callback();
  }
  
  return ret;
*** ../vim-7.4.1749/src/version.c   2016-04-17 20:49:46.133819400 +0200
--- src/version.c   2016-04-18 19:26:14.238849996 +0200
***
*** 750,751 
--- 750,753 
  {   /* Add new patch number below this line */
+ /**/
+ 1750,
  /**/

-- 
You were lucky. We lived for three months in a brown paper bag in a 
septic tank. We used to have to get up at six o'clock in the morning, 
clean the bag, eat a crust of stale bread, go to work down mill for 
fourteen hours a day week in-week out. When we got home, our Dad
would thrash us to sleep with his belt!

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [vim/vim] sh syntax hightlight breaks on "${VAR/FOO/\\[}" (#759)

2016-04-18 Fir de Conversatie Charles Campbell
Alexander Meshcheryakov wrote:
> "${VAR/FOO/\\[}"
>
> is a bashism to substitute |'FOO'| in |$VAR| with |'\['|
> vim fails to notice trailing double quote and the of a script becomes
> highlighted as doublequoted. Demo script to check highlighting:
>
> #!/bin/bash
> VAR1=FOOBAR
> VAR2="${VAR1/FOO/\\[}"
> echo "$VAR2"
Please try sh.vim v148-ASTRO-ONLY from
http://www.drchip.org/astronaut/vim/index.html#SYNTAX_SH .

Thank you for the feedback,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: $VIMRUNTIME/syntax/vim.vim seems to be highlighted wrongly

2016-04-18 Fir de Conversatie tyru
2016/04/18 23:05 "Charles E Campbell" :
>
> tyru wrote:
> > Hi Vimmers and Dr.Chip,
> >
> > Some items seems to be highlighted wrongly in my vimrc.
> > Please see attached Vim script file, HTML(:TOhtml), screenshot.
> >
> > Vim script file: reproducible script
> > HTML: ":TOhtml"'s result
> > PNG: screen capture of HTML
> >
> You might want to try swapping the FocusGained event with the filename
> vimrc-guioptions.

oh, thanks.
You seem correct.
Maybe vimrc-guioptions's Error highlight is my fault.

>
> Regards,
> Chip Campbell
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
"vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: $VIMRUNTIME/syntax/vim.vim seems to be highlighted wrongly

2016-04-18 Fir de Conversatie Charles E Campbell
tyru wrote:
> Hi Vimmers and Dr.Chip,
>
> Some items seems to be highlighted wrongly in my vimrc.
> Please see attached Vim script file, HTML(:TOhtml), screenshot.
>
> Vim script file: reproducible script
> HTML: ":TOhtml"'s result
> PNG: screen capture of HTML
>
You might want to try swapping the FocusGained event with the filename
vimrc-guioptions.

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: gD broken in 7.4.1743

2016-04-18 Fir de Conversatie Marius Gedminas
On Fri, Apr 15, 2016 at 03:11:20PM -0700, Gary Johnson wrote:
> Is it expected or desired that gD is affected by 'ignorecase'?

Case-insensitive languages exist, so I suppose it makes sense for gd/gD
to pay attention to 'ignorecase'.

:help says gd/gD work the same as * (except for skipping comments), and
:help * says that it pays attention to 'ignorecase' (but not 'smartcase').

Regards,
Marius Gedminas
-- 
"Learning Perl" is actually a very well-written book for beginning
programmers.  The only thing wrong with it is it's about Perl...
-- Paul Rubin

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Digital signature


Re: [vim/vim] Patch 7.4.1744 undoes patch 7.4.1743 (#765)

2016-04-18 Fir de Conversatie Nikolay Aleksandrovich Pavlov
ConvertFromPyMapping also has no initial value. Why it does not warn there?

`ret` is always used initialized now.

2016-04-18 14:17 GMT+03:00 David Watson :

> In the function ConvertFromPySequence in src/if_py_both.h, ret has no
> initial value (which clang warns about).
>
> Fix change line 6080 of src/if_py_both.h from
>
> int ret;
>
> to
>
> int ret = 0;
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub
> 
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1353

2016-04-18 Fir de Conversatie Marslo Jiao
On Monday, 18 April 2016 02:58:49 UTC-7, Christian Brabandt  wrote:
> Hi Marslo!
> 
> On Mo, 18 Apr 2016, Marslo Jiao wrote:
> 
> > Sorry for bother you again.
> > I found the python plugin dosen't work somehow after I using the 
> > "CROSS_COMPILE=x86_64-w64-mingw32- ARCH=x86-6".
> > 
> > Here what I did:
> > - install python 2.7 64-bit installer
> > - Install python 3.5 64-bit installer
> > - Build command (for example: with gui): 
> > - Clean: $ make clean; make distclean; git clean -dfx *; git checkout 
> > -- *
> > - Build: $ make -B -f Make_cyg.mak CROSS_COMPILE=x86_64-w64-mingw32- 
> > ARCH=x86-64 PYTHON=/cygdrive/c/Marslo/MyProgramFiles/Python27 
> > DYNAMIC_PYTHON=yes PYTHON_VER=27 
> > PYTHON3=/cygdrive/c/Marslo/MyProgramFiles/Python35 DYNAMIC_PYTHON3=yes 
> > PYTHON3_VER=35 RUBY=/cygdrive/c/Marslo/MyProgramFiles/Ruby23-x64 
> > FEATURES=huge IME=yes GIME=yes MBYTE=yes CSCOPE=yes USERNAME=Marslo.Jiao 
> > USERDOMAIN=China GUI=yes
> > 
> > 
> > After built succeed, here what I got:
> > - build succeed
> > - :version (full version information has been attached)
> >   ...
> >   MS-Windows 64-bit GUI Version
> >   Included patches: 1-1749
> >   ...
> >   Hug version with GUI. Features included (+) or not (-):
> >   ... +python/dyn ...
> >   ... +python3/dyn ...
> >   ...
> >   Compilation: x86_64-w64-mingw32-gcc -Iproto -DWIN32 -DWINVER=0x0501 
> > -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_huge -DMS_WIN64 -DHAVE_GETTEXT 
> > -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_NETBEANS_INTG 
> > -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE 
> > -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall 
> > -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" 
> > -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL="python35.dll" 
> > -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 
> > -fomit-frame-pointer -freg-struct-return -s
> >   Linking: x86_64-w64-mingw32-gcc -Iproto -DWIN32 -DWINVER=0x0501 
> > -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_huge -DMS_WIN64 -DHAVE_GETTEXT 
> > -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_NETBEANS_INTG 
> > -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE 
> > -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall 
> > -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" 
> > -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL="python35.dll" 
> > -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 
> > -fomit-frame-pointer -freg-struct-return -s -mwindows -o gvim.exe 
> > -lkernel32 -luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lversion 
> > -lwsock32 -Lxpm/x64/lib -lXpm -lole32 -luuid
> > 
> > - :echo has('python')
> >   1
> > - :python print "abc"
> >   E887: Sorry, this command is disabled, the Python's site module could not 
> > be loaded
> 
> python 2.7.11 has a bug, that needs a workaround on Windows.
> https://github.com/vim/vim-win32-installer/blob/master/appveyor.bat#L89-L91
> 
> Best,
> Christian 
> -- 
> C: Ich möchte nicht länger "Junge" genannt werden. Ich finde den Ausdruck
>demütigend und sexistisch.
> H: Wie möchtest Du dann genannt werden?
> C: Genetisch bevorzugter Jugendlicher.
>   -- Bill Watterson (aus "Calvin and Hobbes")

Yes. I saw this issue just now. Thanks very much for your help!
I saw the discussion at here: http://t.cn/RqoQdG4, and the python issue report 
at: http://t.cn/RqoQJHv

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1353

2016-04-18 Fir de Conversatie Christian Brabandt
Hi Marslo!

On Mo, 18 Apr 2016, Marslo Jiao wrote:

> Sorry for bother you again.
> I found the python plugin dosen't work somehow after I using the 
> "CROSS_COMPILE=x86_64-w64-mingw32- ARCH=x86-6".
> 
> Here what I did:
> - install python 2.7 64-bit installer
> - Install python 3.5 64-bit installer
> - Build command (for example: with gui): 
> - Clean: $ make clean; make distclean; git clean -dfx *; git checkout -- *
> - Build: $ make -B -f Make_cyg.mak CROSS_COMPILE=x86_64-w64-mingw32- 
> ARCH=x86-64 PYTHON=/cygdrive/c/Marslo/MyProgramFiles/Python27 
> DYNAMIC_PYTHON=yes PYTHON_VER=27 
> PYTHON3=/cygdrive/c/Marslo/MyProgramFiles/Python35 DYNAMIC_PYTHON3=yes 
> PYTHON3_VER=35 RUBY=/cygdrive/c/Marslo/MyProgramFiles/Ruby23-x64 
> FEATURES=huge IME=yes GIME=yes MBYTE=yes CSCOPE=yes USERNAME=Marslo.Jiao 
> USERDOMAIN=China GUI=yes
> 
> 
> After built succeed, here what I got:
> - build succeed
> - :version (full version information has been attached)
>   ...
>   MS-Windows 64-bit GUI Version
>   Included patches: 1-1749
>   ...
>   Hug version with GUI. Features included (+) or not (-):
>   ... +python/dyn ...
>   ... +python3/dyn ...
>   ...
>   Compilation: x86_64-w64-mingw32-gcc -Iproto -DWIN32 -DWINVER=0x0501 
> -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_huge -DMS_WIN64 -DHAVE_GETTEXT 
> -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_NETBEANS_INTG 
> -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE 
> -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall 
> -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" 
> -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL="python35.dll" 
> -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 
> -fomit-frame-pointer -freg-struct-return -s
>   Linking: x86_64-w64-mingw32-gcc -Iproto -DWIN32 -DWINVER=0x0501 
> -D_WIN32_WINNT=0x0501 -DHAVE_PATHDEF -DFEAT_huge -DMS_WIN64 -DHAVE_GETTEXT 
> -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_CSCOPE -DFEAT_NETBEANS_INTG 
> -DFEAT_JOB_CHANNEL -DFEAT_GUI_W32 -DFEAT_CLIPBOARD -DFEAT_MBYTE 
> -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -pipe -march=x86-64 -Wall 
> -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL="python27.dll" 
> -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL="python35.dll" 
> -DFEAT_XPM_W32 -I xpm/x64/include -I xpm/x64/../include -O3 
> -fomit-frame-pointer -freg-struct-return -s -mwindows -o gvim.exe -lkernel32 
> -luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lversion -lwsock32 
> -Lxpm/x64/lib -lXpm -lole32 -luuid
> 
> - :echo has('python')
>   1
> - :python print "abc"
>   E887: Sorry, this command is disabled, the Python's site module could not 
> be loaded

python 2.7.11 has a bug, that needs a workaround on Windows.
https://github.com/vim/vim-win32-installer/blob/master/appveyor.bat#L89-L91

Best,
Christian 
-- 
C: Ich möchte nicht länger "Junge" genannt werden. Ich finde den Ausdruck
   demütigend und sexistisch.
H: Wie möchtest Du dann genannt werden?
C: Genetisch bevorzugter Jugendlicher.
-- Bill Watterson (aus "Calvin and Hobbes")

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 7.4.1353

2016-04-18 Fir de Conversatie Marslo Jiao
On Tuesday, 15 March 2016 21:01:51 UTC-7, Ken Takata  wrote:
> Hi,
> 
> 2016/3/16 Wed 3:16:20 UTC+9 Marslo Jiao wrote:
> > On Tuesday, 15 March 2016 10:49:07 UTC-7, Ken Takata  wrote:
> > > Hi,
> > > 
> > > 2016/3/16 Wed 2:35:06 UTC+9 Marslo Jiao wrote:
> > > > On Thursday, 18 February 2016 13:58:47 UTC-8, Bram Moolenaar  wrote:
> > > > > Patch 7.4.1353
> > > > > Problem:Test_connect_waittime is skipped for MS-Windows.
> > > > > Solution:   Add the test back, it works now.
> > > > > Files:  src/testdir/test_channel.vim
> > > > > 
> > > > > 
> > > > > *** ../vim-7.4.1352/src/testdir/test_channel.vim  2016-02-18 
> > > > > 22:23:21.173660406 +0100
> > > > > --- src/testdir/test_channel.vim  2016-02-18 22:55:42.037193693 
> > > > > +0100
> > > > > ***
> > > > > *** 268,277 
> > > > >   
> > > > >   " Test that trying to connect to a non-existing port fails quickly.
> > > > >   func Test_connect_waittime()
> > > > > -   if !has('unix')
> > > > > - " TODO: Make this work again for MS-Windows.
> > > > > - return
> > > > > -   endif
> > > > > call ch_log('Test_connect_waittime()')
> > > > > let start = reltime()
> > > > > let handle = ch_open('localhost:9876', s:chopt)
> > > > > --- 268,273 
> > > > > *** ../vim-7.4.1352/src/version.c 2016-02-18 22:25:37.468230944 
> > > > > +0100
> > > > > --- src/version.c 2016-02-18 22:57:51.127835583 +0100
> > > > > ***
> > > > > *** 749,750 
> > > > > --- 749,752 
> > > > >   {   /* Add new patch number below this line */
> > > > > + /**/
> > > > > + 1353,
> > > > >   /**/
> > > > > 
> > > > > -- 
> > > > > FATHER: One day, lad, all this will be yours ...
> > > > > PRINCE: What - the curtains?
> > > > >  "Monty Python and the Holy Grail" PYTHON (MONTY) 
> > > > > PICTURES LTD
> > > > > 
> > > > >  /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net 
> > > > >   \\\
> > > > > ///sponsor Vim, vote for features -- 
> > > > > http://www.Vim.org/sponsor/ \\\
> > > > > \\\  an exciting new programming language -- http://www.Zimbu.org 
> > > > >///
> > > > >  \\\help me help AIDS victims -- http://ICCF-Holland.org  
> > > > >   ///
> > > > 
> > > > Since 7.4.1306, vim.exe and gvim.exe cannot be built. Do you know why? 
> > > > and is this my environment error?
> > > > 
> > > > --
> > > > Here is my build command:
> > > >   > make -B -f Make_cyg.mak 
> > > > PYTHON=/cygdrive/c/Marslo/MyProgramFiles/Python27 DYNAMIC_PYTHON=yes 
> > > > PYTHON_VER=27 PYTHON3=/cygdrive/c/Marslo/MyProgramFiles/Python35 
> > > > DYNAMIC_PYTHON3=yes PYTHON3_VER=35 FEATURES=huge IME=yes GIME=yes 
> > > > MBYTE=yes CSCOPE=yes USERNAME=Marslo.Jiao USERDOMAIN=China GUI=yes
> > > >   > make -B -f Make_cyg.mak 
> > > > PYTHON=/cygdrive/c/Marslo/MyProgramFiles/Python27 DYNAMIC_PYTHON=yes 
> > > > PYTHON_VER=27 PYTHON3=/cygdrive/c/Marslo/MyProgramFiles/Python35 
> > > > DYNAMIC_PYTHON3=yes PYTHON3_VER=35 FEATURES=huge IME=yes GIME=yes 
> > > > MBYTE=yes CSCOPE=yes USERNAME=Marslo.Jiao USERDOMAIN=China GUI=no
> > > > 
> > > > ---
> > > > And this is the error log:
> > > > >>> for vim.exe: obji386/os_win32.o:os_win32.c:(.text+0x64df): 
> > > > >>> undefined reference to `AttachConsole'
> > > > collect2: error: ld returned 1 exit status
> > > > Make_cyg_ming.mak:806: recipe for target 'vim.exe' failed
> > > > make: *** [vim.exe] Error 1
> > > > 
> > > > >>> for gvim.exe: 
> > > > channel.c: In function ‘channel_open’:
> > > > channel.c:426:39: error: ‘EINPROGRESS’ undeclared (first use in this 
> > > > function)
> > > > channel.c:426:39: note: each undeclared identifier is reported only 
> > > > once for each function it appears in
> > > > Make_cyg_ming.mak:890: recipe for target 'gobji386/channel.o' failed
> > > > make: *** [gobji386/channel.o] Error 1
> > > 
> > > Does the error still occur after 7.4.1354?
> > > Some errors with old MinGW should have been fixed with 7.4.1354.
> > > Or I suggest you to use MinGW-w64. (Cygwin also has MinGW-w64 packages.)
> > > 
> > > Regards,
> > > Ken Takata
> > 
> > Okay.. I didn't find mingw-w64 in my cygwin setup.exe. I suppose it because 
> > of my cygwin is for 64bit (setup-x86_64.exe)?
> 
> You may find mingw64-i686-gcc-g++ (for 32-bit target) or 
> mingw64-x86_64-gcc-g++
> (for 64-bit target).
> 
> You need to set CROSS_COMPILE and ARCH variables properly when you use 
> MinGW-w64.
> Please see the lines 40-47 in src/Make_cyg.mak for detail.
> 
> E.g. (64-bit target):
>   make -f Make_cyg.mak CROSS_COMPILE=x86_64-w64-mingw32- ARCH=x86-64 ...
> 
> 
> BTW, I have built both 7.4.1354 and 7.4.1579 successfully with MinGW 4.7.3
> (the mingw-gcc-g++ package in Cygwin) with minimal setting:
> 
>   make -f Make_cyg.mak
> 
> Something might be wrong in your environment or setting...
> 
> 
> Regards,
> Ken Takata

Hi Ken,

Sorry for bother you again.
I found the python plugin dosen't work somehow after I using the 

Re: Adding to quickfix list issue

2016-04-18 Fir de Conversatie Bram Moolenaar

Yegappan Lakshmanan wrote:

> On Sun, Apr 17, 2016 at 11:38 AM, Yegappan Lakshmanan
>  wrote:
> > Hi,
> >
> > On Sun, Apr 17, 2016 at 3:35 AM, Ramel Eshed  wrote:
> >> On Sunday, April 17, 2016 at 3:12:55 AM UTC+3, yega...@gmail.com wrote:
> >>> Hi,
> >>>
> >>> On Sat, Apr 16, 2016 at 3:43 PM, Yegappan Lakshmanan
> >>>  wrote:
> >>> > Hi,
> >>> >
> >>> > On Sat, Apr 16, 2016 at 12:52 PM, Ramel Eshed  wro=
> te:
> >>> >> Adding an item to the current quickfix list causes a jump to the fir=
> st item rather than keeping the current context:
> >>> >>
> >>> >> Download the attached file;
> >>> >> vim -u NONE -N
> >>> >> :source qf_test.vim
> >>> >>
> >>> >> -After adding 2 items, :cn, adding one more item and another :cn we =
> are in (2 of 3) instead of (3 of 3).
> >>> >>
> >>> >
> >>> > The setqflist() function resets the index of the quickfix list so tha=
> t it
> >>> > points to the first entry (even if entries are appended to the list).
> >>> >
> >>> > Due to a bug in the set_errorlist() function, the index is set to 1 i=
> nstead
> >>> > of zero. That is why, you saw 2 of 3 instead of 1 of 3.
> >>> >
> >>>
> >>> The quickfix index is 1 based and not zero based. The current code corr=
> ectly
> >>> sets the index to 1. So there is no bug in the current code.
> >>>
> >>> The documentation for the setqflist() function needs to be updated to
> >>> state that it will reset to the first valid entry.
> >>>
> >>> - Yegappan
> >>
> >> Is there any reason to reset the pointer each time? I think that it is
> >> more reasonable to leave the pointer as it when adding to the list so
> >> it=E2=80=99d be possible to work with the list and adding new items to i=
> t when
> >> they=E2=80=99re available without losing the context.
> >>
> >
> > Agreed. I will send out a patch later today for this.
> 
> A patch with tests is attached.

Thanks!

-- 
I'd like to meet the man who invented sex and see what he's working on now.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.