Patch 8.1.2256

2019-11-04 Fir de Conversatie Bram Moolenaar


Patch 8.1.2256 (after 8.1.2255)
Problem:Test for ":term ++shell" fails on MS-Windows.
Solution:   Accept failure of "dir" executable.
Files:  src/testdir/test_terminal.vim


*** ../vim-8.1.2255/src/testdir/test_terminal.vim   2019-11-04 
23:18:31.431027128 +0100
--- src/testdir/test_terminal.vim   2019-11-04 23:34:48.447643158 +0100
***
*** 2227,2233 
elseif has('win32')
  " dir is a shell builtin command, should fail without a shell.
  term dir /b runtest.vim
! call WaitForAssert({-> assert_match('job failed', term_getline(bufnr(), 
1))})
  bwipe!
  
  term ++shell dir /b runtest.vim
--- 2227,2233 
elseif has('win32')
  " dir is a shell builtin command, should fail without a shell.
  term dir /b runtest.vim
! call WaitForAssert({-> assert_match('job failed\|cannot access .*: No 
such file or directory', term_getline(bufnr(), 1))})
  bwipe!
  
  term ++shell dir /b runtest.vim
*** ../vim-8.1.2255/src/version.c   2019-11-04 23:18:31.431027128 +0100
--- src/version.c   2019-11-04 23:36:08.315362324 +0100
***
*** 743,744 
--- 743,746 
  {   /* Add new patch number below this line */
+ /**/
+ 2256,
  /**/

-- 
What a wonderfully exciting cough!  Do you mind if I join you?
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911042236.xA4MawG5012880%40masaka.moolenaar.net.


Patch 8.1.2255

2019-11-04 Fir de Conversatie Bram Moolenaar


Patch 8.1.2255
Problem:":term ++shell" does not work on MS-Windows.
Solution:   Add MS-Windows support.
Files:  src/terminal.c, src/testdir/test_terminal.vim


*** ../vim-8.1.2254/src/terminal.c  2019-11-03 23:37:08.288934381 +0100
--- src/terminal.c  2019-11-03 23:44:31.294556861 +0100
***
*** 846,866 
term_start(NULL, argv, , eap->forceit ? TERM_START_FORCEIT : 0);
vim_free(tofree1);
vim_free(tofree2);
  #else
emsg(_("E279: Sorry, ++shell is not supported on this system"));
  #endif
  }
! else
! {
!   argvar[0].v_type = VAR_STRING;
!   argvar[0].vval.v_string = cmd;
!   argvar[1].v_type = VAR_UNKNOWN;
!   term_start(argvar, NULL, , eap->forceit ? TERM_START_FORCEIT : 0);
! }
! 
! vim_free(tofree);
  
  theend:
  vim_free(opt.jo_eof_chars);
  }
  
--- 846,876 
term_start(NULL, argv, , eap->forceit ? TERM_START_FORCEIT : 0);
vim_free(tofree1);
vim_free(tofree2);
+   goto theend;
  #else
+ # ifdef MSWIN
+   long_u  cmdlen = STRLEN(p_sh) + STRLEN(p_shcf) + STRLEN(cmd) + 10;
+   char_u  *newcmd;
+ 
+   newcmd = alloc(cmdlen);
+   if (newcmd == NULL)
+   goto theend;
+   tofree = newcmd;
+   vim_snprintf((char *)newcmd, cmdlen, "%s %s %s", p_sh, p_shcf, cmd);
+   cmd = newcmd;
+ # else
emsg(_("E279: Sorry, ++shell is not supported on this system"));
+   goto theend;
+ # endif
  #endif
  }
! argvar[0].v_type = VAR_STRING;
! argvar[0].vval.v_string = cmd;
! argvar[1].v_type = VAR_UNKNOWN;
! term_start(argvar, NULL, , eap->forceit ? TERM_START_FORCEIT : 0);
  
  theend:
+ vim_free(tofree);
  vim_free(opt.jo_eof_chars);
  }
  
*** ../vim-8.1.2254/src/testdir/test_terminal.vim   2019-11-03 
23:37:08.288934381 +0100
--- src/testdir/test_terminal.vim   2019-11-04 23:04:16.765676853 +0100
***
*** 2215,2229 
  endfunc
  
  func Test_terminal_shell_option()
!   CheckUnix
!   " exec is a shell builtin command, should fail without a shell.
!   term exec ls runtest.vim
!   call WaitForAssert({-> assert_match('job failed', term_getline(bufnr(), 
1))})
!   bwipe!
  
!   term ++shell exec ls runtest.vim
!   call WaitForAssert({-> assert_match('runtest.vim', term_getline(bufnr(), 
1))})
!   bwipe!
  endfunc
  
  func Test_terminal_setapi_and_call()
--- 2215,2239 
  endfunc
  
  func Test_terminal_shell_option()
!   if has('unix')
! " exec is a shell builtin command, should fail without a shell.
! term exec ls runtest.vim
! call WaitForAssert({-> assert_match('job failed', term_getline(bufnr(), 
1))})
! bwipe!
  
! term ++shell exec ls runtest.vim
! call WaitForAssert({-> assert_match('runtest.vim', term_getline(bufnr(), 
1))})
! bwipe!
!   elseif has('win32')
! " dir is a shell builtin command, should fail without a shell.
! term dir /b runtest.vim
! call WaitForAssert({-> assert_match('job failed', term_getline(bufnr(), 
1))})
! bwipe!
! 
! term ++shell dir /b runtest.vim
! call WaitForAssert({-> assert_match('runtest.vim', term_getline(bufnr(), 
1))})
! bwipe!
!   endif
  endfunc
  
  func Test_terminal_setapi_and_call()
*** ../vim-8.1.2254/src/version.c   2019-11-04 22:52:08.366798096 +0100
--- src/version.c   2019-11-04 23:04:36.745623833 +0100
***
*** 743,744 
--- 743,746 
  {   /* Add new patch number below this line */
+ /**/
+ 2255,
  /**/

-- 
'Well, here's something to occupy you and keep your mind off things.'
'It won't work, I have an exceptionally large mind.'
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911042218.xA4MIxmP007941%40masaka.moolenaar.net.


Patch 8.1.2254

2019-11-04 Fir de Conversatie Bram Moolenaar


Patch 8.1.2254
Problem:MS-Windows: mouse scroll wheel doesn't work in popup.
Solution:   Handle mouse wheel events separately. (closes #5138)
Files:  src/gui_w32.c, src/gui.c, src/proto/gui.pro


*** ../vim-8.1.2253/src/gui_w32.c   2019-10-23 21:43:13.368623922 +0200
--- src/gui_w32.c   2019-11-04 22:48:17.783480656 +0100
***
*** 4262,4267 
--- 4262,4293 
  if (mouse_scroll_lines == 0)
init_mouse_wheel();
  
+ #ifdef FEAT_TEXT_PROP
+ {
+   win_T *wp = gui_mouse_window(FIND_POPUP);
+ 
+   if (wp != NULL && popup_is_popup(wp))
+   {
+   cmdarg_T cap;
+   oparg_T oa;
+ 
+   // Mouse hovers over popup window, scroll it if possible.
+   mouse_row = wp->w_winrow;
+   mouse_col = wp->w_wincol;
+   vim_memset(, 0, sizeof(cap));
+   cap.arg = zDelta < 0 ? MSCR_UP : MSCR_DOWN;
+   cap.cmdchar = zDelta < 0 ? K_MOUSEUP : K_MOUSEDOWN;
+   clear_oparg();
+   cap.oap = 
+   nv_mousescroll();
+   update_screen(0);
+   setcursor();
+   out_flush();
+   return;
+   }
+ }
+ #endif
+ 
  mch_disable_flush();
  if (mouse_scroll_lines > 0
&& mouse_scroll_lines < (size > 2 ? size - 2 : 1))
*** ../vim-8.1.2253/src/gui.c   2019-10-18 20:53:30.697741631 +0200
--- src/gui.c   2019-11-04 22:31:23.439740964 +0100
***
*** 31,37 
  static void gui_update_horiz_scrollbar(int);
  static void gui_set_fg_color(char_u *name);
  static void gui_set_bg_color(char_u *name);
! static win_T *xy2win(int x, int y);
  
  #ifdef GUI_MAY_FORK
  static void gui_do_fork(void);
--- 31,37 
  static void gui_update_horiz_scrollbar(int);
  static void gui_set_fg_color(char_u *name);
  static void gui_set_bg_color(char_u *name);
! static win_T *xy2win(int x, int y, mouse_find_T popup);
  
  #ifdef GUI_MAY_FORK
  static void gui_do_fork(void);
***
*** 4852,4858 
  
  #ifdef FEAT_MOUSESHAPE
  /* Get window pointer, and update mouse shape as well. */
! wp = xy2win(x, y);
  #endif
  
  /* Only handle this when 'mousefocus' set and ... */
--- 4852,4858 
  
  #ifdef FEAT_MOUSESHAPE
  /* Get window pointer, and update mouse shape as well. */
! wp = xy2win(x, y, IGNORE_POPUP);
  #endif
  
  /* Only handle this when 'mousefocus' set and ... */
***
*** 4868,4874 
if (x < 0 || x > Columns * gui.char_width)
return;
  #ifndef FEAT_MOUSESHAPE
!   wp = xy2win(x, y);
  #endif
if (wp == curwin || wp == NULL)
return; /* still in the same old window, or none at all */
--- 4868,4874 
if (x < 0 || x > Columns * gui.char_width)
return;
  #ifndef FEAT_MOUSESHAPE
!   wp = xy2win(x, y, IGNORE_POPUP);
  #endif
if (wp == curwin || wp == NULL)
return; /* still in the same old window, or none at all */
***
*** 4930,4954 
  }
  
  /*
   * Called when mouse should be moved to window with focus.
   */
  void
  gui_mouse_correct(void)
  {
- int   x, y;
  win_T *wp = NULL;
  
  need_mouse_correct = FALSE;
  
! if (!(gui.in_use && p_mousef))
!   return;
! 
! gui_mch_getmouse(, );
! /* Don't move the mouse when it's left or right of the Vim window */
! if (x < 0 || x > Columns * gui.char_width)
!   return;
! if (y >= 0 && Y_2_ROW(y) >= tabline_height())
!   wp = xy2win(x, y);
  if (wp != curwin && wp != NULL)   /* If in other than current window */
  {
validate_cline_row();
--- 4930,4965 
  }
  
  /*
+  * Get the window where the mouse pointer is on.
+  * Returns NULL if not found.
+  */
+ win_T *
+ gui_mouse_window(mouse_find_T popup)
+ {
+ int   x, y;
+ 
+ if (!(gui.in_use && (p_mousef || popup == FIND_POPUP)))
+   return NULL;
+ gui_mch_getmouse(, );
+ 
+ // Only use the mouse when it's on the Vim window
+ if (x >= 0 && x <= Columns * gui.char_width
+   && y >= 0 && Y_2_ROW(y) >= tabline_height())
+   return xy2win(x, y, popup);
+ return NULL;
+ }
+ 
+ /*
   * Called when mouse should be moved to window with focus.
   */
  void
  gui_mouse_correct(void)
  {
  win_T *wp = NULL;
  
  need_mouse_correct = FALSE;
  
! wp = gui_mouse_window(IGNORE_POPUP);
  if (wp != curwin && wp != NULL)   /* If in other than current window */
  {
validate_cline_row();
***
*** 4963,4969 
   * As a side effect update the shape of the mouse pointer.
   */
  static win_T *
! xy2win(int x, int y)
  {
  int   row;
  int   col;
--- 4974,4980 
   * As a side effect update the shape of the mouse pointer.
   */
  static win_T *
! xy2win(int x, int y, mouse_find_T popup)
  {
  int   row;
  int   col;
***
*** 4973,4979 
  col = 

Patch 8.1.2253

2019-11-04 Fir de Conversatie Bram Moolenaar


Patch 8.1.2253
Problem:Using "which" to check for an executable is not reliable.
Solution:   Use "command -v" instead.  Also exit with error code when
generating tags has an error. (closes #5174)
Files:  runtime/doc/Makefile


*** ../vim-8.1.2252/runtime/doc/Makefile2019-11-03 21:46:16.425213135 
+0100
--- runtime/doc/Makefile2019-11-04 21:22:35.145308509 +0100
***
*** 323,331 
  # Use Vim to generate the tags file.  Can only be used when Vim has been
  # compiled and installed.  Supports multiple languages.
  vimtags: $(DOCS)
!   @if which $(VIMEXE) >/dev/null; then \
! $(VIMEXE) --clean -eX -u doctags.vim >/dev/null; \
! echo "help tags updated"; \
  else echo "vim executable $(VIMEXE) not found; help tags not 
updated"; fi
  
  # Use "doctags" to generate the tags file.  Only works for English!
--- 323,331 
  # Use Vim to generate the tags file.  Can only be used when Vim has been
  # compiled and installed.  Supports multiple languages.
  vimtags: $(DOCS)
!   @if command -v $(VIMEXE); then \
!   $(VIMEXE) --clean -eX -u doctags.vim >/dev/null && \
! echo "help tags updated"; \
  else echo "vim executable $(VIMEXE) not found; help tags not 
updated"; fi
  
  # Use "doctags" to generate the tags file.  Only works for English!
*** ../vim-8.1.2252/src/version.c   2019-11-04 20:36:46.128633933 +0100
--- src/version.c   2019-11-04 21:24:30.808840203 +0100
***
*** 743,744 
--- 743,746 
  {   /* Add new patch number below this line */
+ /**/
+ 2253,
  /**/

-- 
The technology involved in making anything invisible is so infinitely
complex that nine hundred and ninety-nine billion, nine hundred and
ninety-nine million, nine hundred and ninety-nine thousand, nine hundred
and ninety-nine times out of a trillion it is much simpler and more
effective just to take the thing away and do without it.
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911042025.xA4KPGoc021165%40masaka.moolenaar.net.


Patch 8.1.2252

2019-11-04 Fir de Conversatie Bram Moolenaar


Patch 8.1.2252
Problem:Compiler warning for int size.
Solution:   Add type cast. (Mike Williams)
Files:  src/filepath.c


*** ../vim-8.1.2251/src/filepath.c  2019-10-30 04:10:00.053774871 +0100
--- src/filepath.c  2019-11-04 20:35:18.017017223 +0100
***
*** 79,85 
  vim_free(wfname);
  vim_free(newbuf);
  
! *fnamelen = l == 0 ? l : STRLEN(*bufp);
  return OK;
  }
  
--- 79,85 
  vim_free(wfname);
  vim_free(newbuf);
  
! *fnamelen = l == 0 ? l : (int)STRLEN(*bufp);
  return OK;
  }
  
*** ../vim-8.1.2251/src/version.c   2019-11-03 23:37:08.288934381 +0100
--- src/version.c   2019-11-04 20:35:59.248837484 +0100
***
*** 743,744 
--- 743,746 
  {   /* Add new patch number below this line */
+ /**/
+ 2252,
  /**/

-- 
"Space is big.  Really big.  You just won't believe how vastly hugely mind-
bogglingly big it is.  I mean, you may think it's a long way down the
road to the chemist, but that's just peanuts to space."
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911041937.xA4JbFQ8012733%40masaka.moolenaar.net.


Re: Patch 8.1.2242

2019-11-04 Fir de Conversatie Bram Moolenaar


> 2019/11/4 Mon 20:37:24 UTC+9 James McCoy wrote:
> >
> > On Mon, Nov 4, 2019, 05:28 Bram Moolenaar  > > wrote:
> >
> >>
> >> > On Sun, Nov 03, 2019 at 09:20:20PM +0100, Bram Moolenaar wrote:
> >> > > 
> >> > > Christian wrote:
> >> > > 
> >> > > > On So, 03 Nov 2019, Bram Moolenaar wrote:
> >> > > > 
> >> > > > > Right, "make vimtags" doesn't work.  I'm not sure how widespread 
> >> "type"
> >> > > > > is, I think "which" should be safer.
> >> > > > 
> >> > > > type or command -v  is the command one should use nowadays. For a 
> >> really 
> >> > > > deep dive into what to use, I suggest this great article:
> >> > > > 
> >> > > > https://unix.stackexchange.com/a/85250/303213
> >> > > 
> >> > > Hmm, not that great.  It doesn't list what command is available in 
> >> which
> >> > > version of a shell.  It does mention that "which" is widely available,
> >> > > while "type" is not.
> >> > 
> >> > FWIW, "command -v ..." is specified in POSIX.  "type" is as well, but as
> >> > an XSI extension.
> >>
> >> In tcsh:
> >>
> >> $ command -v vim
> >> command: Command not found.
> >>
> >> Perfect error message :-).
> >
> > Tcsh isn't /bin/sh, so I'm not sure why that's relevant.  This is in the 
> > context of a Makefile, which uses /bin/sh.

I suppose any kind of csh wouldn't work.

> We already use "command -v" in src/po/Makefile.
> I think it can be also safely used in runtime/doc/Makefile.

I was wondering how widely supported "command -v" is.  Perhaps it's OK,
since that existing use hasn't triggered complaints.  It's in a bit of a
far corner of the build rules though.

-- 
Now it is such a bizarrely improbable coincidence that anything as
mind-bogglingly useful as the Babel fish could have evolved purely by chance
that some thinkers have chosen to see it as a final and clinching proof of the
NON-existence of God.
The argument goes something like this: 'I refuse to prove that I exist,' says
God, 'for proof denies faith, and without faith I am nothing.'
'But,' says Man, 'the Babel fish is a dead giveaway, isn't it?  It could not
have evolved by chance.  It proves you exist, and so therefore, by your own
arguments, you don't.  QED.'
'Oh dear,' says God, 'I hadn't thought of that,' and promptly vanishes in a
puff of logic.
'Oh, that was easy,' says Man, and for an encore goes on to prove that black
is white and gets himself killed on the next pedestrian crossing.
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911041748.xA4HmnDl024018%40masaka.moolenaar.net.


Re: Patch 8.1.2242

2019-11-04 Fir de Conversatie Christian Brabandt


On Mo, 04 Nov 2019, Ken Takata wrote:

> We already use "command -v" in src/po/Makefile.
> I think it can be also safely used in runtime/doc/Makefile.

And I think we even had a similar discussion back then ;)

Best,
Christian
-- 
Auf jede Frage eine Antwort wissen nur Dummköpfe.
-- John Ernst Steinbeck

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20191104121220.GQ24930%40256bit.org.


Re: Patch 8.1.2242

2019-11-04 Fir de Conversatie Ken Takata
Hi,

2019/11/4 Mon 20:37:24 UTC+9 James McCoy wrote:
>
> On Mon, Nov 4, 2019, 05:28 Bram Moolenaar  > wrote:
>
>>
>> > On Sun, Nov 03, 2019 at 09:20:20PM +0100, Bram Moolenaar wrote:
>> > > 
>> > > Christian wrote:
>> > > 
>> > > > On So, 03 Nov 2019, Bram Moolenaar wrote:
>> > > > 
>> > > > > Right, "make vimtags" doesn't work.  I'm not sure how widespread 
>> "type"
>> > > > > is, I think "which" should be safer.
>> > > > 
>> > > > type or command -v  is the command one should use nowadays. For a 
>> really 
>> > > > deep dive into what to use, I suggest this great article:
>> > > > 
>> > > > https://unix.stackexchange.com/a/85250/303213
>> > > 
>> > > Hmm, not that great.  It doesn't list what command is available in 
>> which
>> > > version of a shell.  It does mention that "which" is widely available,
>> > > while "type" is not.
>> > 
>> > FWIW, "command -v ..." is specified in POSIX.  "type" is as well, but as
>> > an XSI extension.
>>
>> In tcsh:
>>
>> $ command -v vim
>> command: Command not found.
>>
>> Perfect error message :-).
>>
>
> Tcsh isn't /bin/sh, so I'm not sure why that's relevant.  This is in the 
> context of a Makefile, which uses /bin/sh.
>
>>
We already use "command -v" in src/po/Makefile.
I think it can be also safely used in runtime/doc/Makefile.

Regards,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/950f3960-a640-4229-ba0d-3c08fa3b9e1b%40googlegroups.com.


Re: Patch 8.1.2242

2019-11-04 Fir de Conversatie James McCoy
On Mon, Nov 4, 2019, 05:28 Bram Moolenaar  wrote:

>
> > On Sun, Nov 03, 2019 at 09:20:20PM +0100, Bram Moolenaar wrote:
> > >
> > > Christian wrote:
> > >
> > > > On So, 03 Nov 2019, Bram Moolenaar wrote:
> > > >
> > > > > Right, "make vimtags" doesn't work.  I'm not sure how widespread
> "type"
> > > > > is, I think "which" should be safer.
> > > >
> > > > type or command -v  is the command one should use nowadays. For a
> really
> > > > deep dive into what to use, I suggest this great article:
> > > >
> > > > https://unix.stackexchange.com/a/85250/303213
> > >
> > > Hmm, not that great.  It doesn't list what command is available in
> which
> > > version of a shell.  It does mention that "which" is widely available,
> > > while "type" is not.
> >
> > FWIW, "command -v ..." is specified in POSIX.  "type" is as well, but as
> > an XSI extension.
>
> In tcsh:
>
> $ command -v vim
> command: Command not found.
>
> Perfect error message :-).
>

Tcsh isn't /bin/sh, so I'm not sure why that's relevant.  This is in the
context of a Makefile, which uses /bin/sh.

Cheers,
James

>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAFeRdpckxWXpYCr8Mf-9w31jt%2BsiuUfr_B76%2BmBCa%2BAmn7Zn1w%40mail.gmail.com.


Re: Patch 8.1.2242

2019-11-04 Fir de Conversatie Bram Moolenaar


> On Sun, Nov 03, 2019 at 09:20:20PM +0100, Bram Moolenaar wrote:
> > 
> > Christian wrote:
> > 
> > > On So, 03 Nov 2019, Bram Moolenaar wrote:
> > > 
> > > > Right, "make vimtags" doesn't work.  I'm not sure how widespread "type"
> > > > is, I think "which" should be safer.
> > > 
> > > type or command -v  is the command one should use nowadays. For a really 
> > > deep dive into what to use, I suggest this great article:
> > > 
> > > https://unix.stackexchange.com/a/85250/303213
> > 
> > Hmm, not that great.  It doesn't list what command is available in which
> > version of a shell.  It does mention that "which" is widely available,
> > while "type" is not.
> 
> FWIW, "command -v ..." is specified in POSIX.  "type" is as well, but as
> an XSI extension.

In tcsh:

$ command -v vim
command: Command not found.

Perfect error message :-).


-- 
In many of the more relaxed civilizations on the Outer Eastern Rim of the
Galaxy, "The Hitchhiker's Guide to the Galaxy" has already supplanted the
great "Encyclopedia Galactica" as the standard repository of all knowledge
and wisdom, for though it has many omissions and contains much that is
apocryphal, or at least wildly inaccurate, it scores over the older, more
pedestrian work in two important respects.
First, it is slightly cheaper; and second, it has the words "DON'T PANIC"
inscribed in large friendly letters on its cover.
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911041028.xA4ASnwr023902%40masaka.moolenaar.net.