Re: patch 9.0.0818 compilation failure

2022-11-02 Fir de Conversatie Ernie Rael

On 22/11/02 11:06 AM, Christian Brabandt wrote:

Am 2022-10-30 01:22, schrieb Ernie Rael:

On 22/10/29 3:36 PM, Ernie Rael wrote:
clang -c -I. -Iproto -DHAVE_CONFIG_H -g -O2 -Wall -Wextra -Wshadow 
-Wmissing-prototypes -Wpedantic -Wunreachable-code 
-Wno-cast-function-type -Wunused-result -Wno-deprecated-declarations 
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1    -o objects/bufwrite.o 
bufwrite.c
bufwrite.c:2055:31: error: member reference type 'struct bw_info' is 
not a pointer; did you mean to use '.'?

    (void)write_eintr(write_info->bw_fd, "\x1a", 1);
  ~~^~
-ernie


Oops, the primary github repo does not have the problem.

One of the mercurial repos has got the problem.
It's behind the main repo, looks like it part of the git mess up.

$ hg paths
default = https://hg.osdn.net/view/vim/vim
err@harmony:/ref/vim/src

$ hg glog -l3
@  changeset:   30967:6f305257ad43
|  tag: tip
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 10:45:08 2022 +0200
|  summary: patch 9.0.0818
|
o  changeset:   30966:3a01529f17f5
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 10:45:07 2022 +0200
|  summary: patch 9.0.0817
|
o  changeset:   30965:22264b648b5d
|  parent:  30960:6b03468f9cf7
~  user:    Bram Moolenaar 
   date:    Sat Oct 22 10:15:05 2022 +0200
   summary: patch 9.0.0815


github repo does not have the compiler error

$ hg paths
default = git+https://github.com/errael/vim.git
default:pushurl = git+ssh://g...@github.com:errael/vim.git
upstream = git+https://github.com/vim/vim.git


$ hg glog -r ::tip -l9
@  changeset:   17117:d6d3f7b70a6b
|  bookmark:    master
|  tag: default/master
|  tag: tip
|  user:    Bram Moolenaar 
|  date:    Sat Oct 29 21:53:08 2022 +0100
|  summary: patch 9.0.0820: memory leak with empty shell command
|
o  changeset:   17116:c5a7413ca4bd
|  user:    Bram Moolenaar 
|  date:    Sat Oct 29 20:01:52 2022 +0100
|  summary: patch 9.0.0819
|
o  changeset:   17115:cba601ed383b
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 20:47:54 2022 +0100
|  summary: Update runtime files
|
o  changeset:   17114:d2816c6d62dc
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 17:04:21 2022 +0100
|  summary: Add missing entry for the 'endoffile' option.
|
o  changeset:   17113:80f61fe31f8a
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 16:51:46 2022 +0100
|  summary: Fix wrong struct access for member.
|
o  changeset:   17112:94949daf2596
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 16:47:14 2022 +0100
|  summary: Revert unintended Makefile change
|
o  changeset:   17111:3fb8b4f8f870
|  user:    Bram Moolenaar 
|  date:    Sat Oct 22 12:23:12 2022 +0100
|  summary: patch 9.0.0818
|
o  changeset:   17110:cd8b13998150
|  parent:  17108:71103e98d925
|  user:    Bram Moolenaar 
|  date:    Sat Oct 22 11:25:19 2022 +0100
|  summary: patch 9.0.0817
|
o  changeset:   17108:71103e98d925
|  user:    Martin Tournoij 
~  date:    Sat Oct 22 09:02:56 2022 +0100
   summary: patch 9.0.0815



Hi,
I just updated the hg mirror. Is this fixed?


Greetings,

Looks good, thanks. Compiles OK and source diff consistent between pulls 
from github and https://hg.osdn.net/view/vim/vi.




Thanks,
Chris



--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/e2eab42c-632e-eae2-7c92-a680f05a42ce%40raelity.com.


Re: patch 9.0.0818 compilation failure

2022-11-02 Fir de Conversatie Christian Brabandt

Am 2022-10-30 01:22, schrieb Ernie Rael:

On 22/10/29 3:36 PM, Ernie Rael wrote:
clang -c -I. -Iproto -DHAVE_CONFIG_H -g -O2 -Wall -Wextra -Wshadow 
-Wmissing-prototypes -Wpedantic -Wunreachable-code 
-Wno-cast-function-type -Wunused-result -Wno-deprecated-declarations 
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1    -o objects/bufwrite.o 
bufwrite.c
bufwrite.c:2055:31: error: member reference type 'struct bw_info' is 
not a pointer; did you mean to use '.'?

    (void)write_eintr(write_info->bw_fd, "\x1a", 1);
  ~~^~
-ernie


Oops, the primary github repo does not have the problem.

One of the mercurial repos has got the problem.
It's behind the main repo, looks like it part of the git mess up.

$ hg paths
default = https://hg.osdn.net/view/vim/vim
err@harmony:/ref/vim/src

$ hg glog -l3
@  changeset:   30967:6f305257ad43
|  tag: tip
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 10:45:08 2022 +0200
|  summary: patch 9.0.0818
|
o  changeset:   30966:3a01529f17f5
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 10:45:07 2022 +0200
|  summary: patch 9.0.0817
|
o  changeset:   30965:22264b648b5d
|  parent:  30960:6b03468f9cf7
~  user:    Bram Moolenaar 
   date:    Sat Oct 22 10:15:05 2022 +0200
   summary: patch 9.0.0815


github repo does not have the compiler error

$ hg paths
default = git+https://github.com/errael/vim.git
default:pushurl = git+ssh://g...@github.com:errael/vim.git
upstream = git+https://github.com/vim/vim.git


$ hg glog -r ::tip -l9
@  changeset:   17117:d6d3f7b70a6b
|  bookmark:    master
|  tag: default/master
|  tag: tip
|  user:    Bram Moolenaar 
|  date:    Sat Oct 29 21:53:08 2022 +0100
|  summary: patch 9.0.0820: memory leak with empty shell command
|
o  changeset:   17116:c5a7413ca4bd
|  user:    Bram Moolenaar 
|  date:    Sat Oct 29 20:01:52 2022 +0100
|  summary: patch 9.0.0819
|
o  changeset:   17115:cba601ed383b
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 20:47:54 2022 +0100
|  summary: Update runtime files
|
o  changeset:   17114:d2816c6d62dc
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 17:04:21 2022 +0100
|  summary: Add missing entry for the 'endoffile' option.
|
o  changeset:   17113:80f61fe31f8a
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 16:51:46 2022 +0100
|  summary: Fix wrong struct access for member.
|
o  changeset:   17112:94949daf2596
|  user:    Bram Moolenaar 
|  date:    Fri Oct 28 16:47:14 2022 +0100
|  summary: Revert unintended Makefile change
|
o  changeset:   17111:3fb8b4f8f870
|  user:    Bram Moolenaar 
|  date:    Sat Oct 22 12:23:12 2022 +0100
|  summary: patch 9.0.0818
|
o  changeset:   17110:cd8b13998150
|  parent:  17108:71103e98d925
|  user:    Bram Moolenaar 
|  date:    Sat Oct 22 11:25:19 2022 +0100
|  summary: patch 9.0.0817
|
o  changeset:   17108:71103e98d925
|  user:    Martin Tournoij 
~  date:    Sat Oct 22 09:02:56 2022 +0100
   summary: patch 9.0.0815



Hi,
I just updated the hg mirror. Is this fixed?

Thanks,
Chris

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/fed1869e0822540245714507a9e1e7e2%40256bit.org.


Re: Health update

2022-11-02 Fir de Conversatie Tony Mechelynck
On Wed, Nov 2, 2022 at 1:00 PM Bram Moolenaar  wrote:
[...]
> OK.  Changing commits would be rewriting history, that sounds like
> something we don't want, even though it looks like some commits were not
> done right.  I tried creating diffs from the tagged commits, but those
> are a bit messy too.  I'll not try to fix more, unless someone can tell
> me the git commands that will make something better.  E.g. updating the
> description to say what the commit is really about.  But only if this
> won't have undesired side effects.
[...]
IIUC, the 40-nybble commit ID is computed from the parent's ID and
everything in the new commit including the description (but not the
tag(s) if any, which are added afterwards). This would mean that
changing a description would actually mean deleting a commit and
everything descended from it, then recreating all these deleted
commits with different contents (and in particular different IDs),
thus making the repository incompatible with any users' repositories
where any of the now deleted commits had been downloaded.

I agree with Christian: leave it as-is, it is not perfect (perfection
is not of this world) but we can live with it.

Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAJkCKXt9PVOQ4qgxxPfNw28dS%3DWdYVgwte5KfNWGAt7aMXFi-w%40mail.gmail.com.


Patch 9.0.0828

2022-11-02 Fir de Conversatie Bram Moolenaar


Patch 9.0.0828
Problem:Various typos.
Solution:   Correct typos. (closes #11432)
Files:  src/GvimExt/Make_ming.mak, src/INSTALLpc.txt, src/blob.c,
src/bufwrite.c, src/change.c, src/charset.c, src/config.h.in,
src/dict.c, src/drawline.c, src/errors.h, src/eval.c,
src/getchar.c, src/gui_gtk_x11.c, src/gui_w32.c, src/highlight.c,
src/message_test.c, src/os_macosx.m, src/os_win32.c,
src/proto/usercmd.pro, src/proto/vim9execute.pro, src/regexp.c,
src/register.c, src/screen.c, src/scriptfile.c, src/spell.c,
src/spell.h, src/spellfile.c, src/structs.h, src/tag.c,
src/term.c, src/terminal.c, src/textprop.c, src/typval.c,
src/usercmd.c src/userfunc.c, src/vim9cmds.c, src/vim9execute.c,
src/vim9expr.c, src/testdir/test_channel.vim,
src/testdir/test_channel_lsp.py, src/testdir/test_cmdmods.vim
src/testdir/test_expr.vim, src/testdir/test_fold.vim,
src/testdir/test_langmap.vim, src/testdir/test_map_functions.vim,
src/testdir/test_options.vim, src/testdir/test_popupwin.vim,
src/testdir/test_termcodes.vim, src/testdir/test_textprop.vim,
src/testdir/test_vim9_cmd.vim, src/testdir/test_vim9_script.vim,
src/testdir/test_vimscript.vim, src/testdir/test_visual.vim,
src/testdir/test_winbar.vim, src/testdir/test_window_cmd.vim


*** ../vim-9.0.0827/src/GvimExt/Make_ming.mak   2022-06-14 12:28:13.0 
+0100
--- src/GvimExt/Make_ming.mak   2022-11-02 12:40:40.634379093 +
***
*** 3,9 
  # To be used with MingW and Cygwin.
  #
  # Originally, the DLL base address was fixed: -Wl,--image-base=0x1C00
! # Now it is allocated dymanically by the linker by evaluating all DLLs
  # already loaded in memory. The binary image contains as well information
  # for automatic pseudo-rebasing, if needed by the system. ALV 2004-02-29
  
--- 3,9 
  # To be used with MingW and Cygwin.
  #
  # Originally, the DLL base address was fixed: -Wl,--image-base=0x1C00
! # Now it is allocated dynamically by the linker by evaluating all DLLs
  # already loaded in memory. The binary image contains as well information
  # for automatic pseudo-rebasing, if needed by the system. ALV 2004-02-29
  
*** ../vim-9.0.0827/src/INSTALLpc.txt   2022-10-16 19:45:24.558960645 +0100
--- src/INSTALLpc.txt   2022-11-02 12:40:40.634379093 +
***
*** 72,78 
  
  Visual Studio installed a batch file called vcvarsall.bat, which you must
  run to set up paths for nmake and MSVC.  We provide a batch file
! "msvc2015.bat" for this.  You may need to edit it if you didn't instal Visual
  Studio in the standard location.
  If you use VS2017 or later, you can use "msvc-latest.bat" (or "msvc2017.bat"
  and so on for the specific version).  You must specify the architecture (e.g.
--- 72,78 
  
  Visual Studio installed a batch file called vcvarsall.bat, which you must
  run to set up paths for nmake and MSVC.  We provide a batch file
! "msvc2015.bat" for this.  You may need to edit it if you didn't install Visual
  Studio in the standard location.
  If you use VS2017 or later, you can use "msvc-latest.bat" (or "msvc2017.bat"
  and so on for the specific version).  You must specify the architecture (e.g.
*** ../vim-9.0.0827/src/blob.c  2022-10-21 11:25:25.689652476 +0100
--- src/blob.c  2022-11-02 12:40:40.634379093 +
***
*** 716,722 
  }
  
  /*
!  * Implementaion of reduce() for Blob "argvars[0]" using the function "expr"
   * starting with the optional initial value "argvars[2]" and return the result
   * in "rettv".
   */
--- 716,722 
  }
  
  /*
!  * Implementation of reduce() for Blob "argvars[0]" using the function "expr"
   * starting with the optional initial value "argvars[2]" and return the result
   * in "rettv".
   */
*** ../vim-9.0.0827/src/bufwrite.c  2022-11-01 20:33:39.991400397 +
--- src/bufwrite.c  2022-11-02 12:45:17.346047264 +
***
*** 1475,1481 
{
if (buf_write_bytes(_info) == FAIL)
{
!   errmsg = (char_u 
*)_(e_canot_write_to_backup_file_add_bang_to_override);
break;
}
ui_breakcheck();
--- 1475,1481 
{
if (buf_write_bytes(_info) == FAIL)
{
!   errmsg = (char_u 
*)_(e_cant_write_to_backup_file_add_bang_to_override);
break;
}
ui_breakcheck();
*** ../vim-9.0.0827/src/change.c2022-10-29 19:54:03.849448379 +0100
--- src/change.c2022-11-02 12:40:40.634379093 +
***
*** 1378,1384 
   * "second_line_indent": indent 

Re: Health update

2022-11-02 Fir de Conversatie Bram Moolenaar


Christian wrote:

> Am 2022-10-30 19:14, schrieb Bram Moolenaar:
> > Update: I am waiting for test results.  Slowly doing more, walking
> > around a bit.  I managed to make CI green again, let's take that
> > as proof that my head is OK :-).  Older commits still need updates,
> > description and tags.  It will be good if someone can suggest the git
> > commands for that.
> 
> I think it is too late to fix anything in the actual commits. Just leave 
> it as it is,
> otherwise you may cause a lot of grief to users of the repo. I think we 
> can live with some missing descriptions
> and tags/commits without any contents. As mentioned, for a public 
> repository we cannot change the history (I have accidentally done that
> on the vim-airline repository for a few commits and received a lot of 
> complaints after that).

OK.  Changing commits would be rewriting history, that sounds like
something we don't want, even though it looks like some commits were not
done right.  I tried creating diffs from the tagged commits, but those
are a bit messy too.  I'll not try to fix more, unless someone can tell
me the git commands that will make something better.  E.g. updating the
description to say what the commit is really about.  But only if this
won't have undesired side effects.

> > Also thanks again for all the best wishes, it helps to keep my spirit
> > up!
> 
> I am late to the party, since I also was offline for more than week and 
> had to take care of my son.
> 
> But please: Take care of yourself first. That should be first priority. 
> After all, it's just some code. It can wait for some time :)

Vim is like a son to me :-).

> If there is anything I can help you with regards to the vim stuff, let 
> me know.
> 
> Also, I'd like to take the opportunity and donate something for Uganda 
> and encourage the community to do the same :)

Always good!

- Bram

-- 
hundred-and-one symptoms of being an internet addict:
6. You refuse to go to a vacation spot with no electricity and no phone lines.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///  \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20221102120020.867661C0739%40moolenaar.net.


Re: Health update

2022-11-02 Fir de Conversatie Christian Brabandt

[re-sending, because I used the wrong E-Mail account :(]

 Am 2022-10-30 19:14, schrieb Bram Moolenaar:

Update: I am waiting for test results.  Slowly doing more, walking
around a bit.  I managed to make CI green again, let's take that
as proof that my head is OK :-).  Older commits still need updates,
description and tags.  It will be good if someone can suggest the git
commands for that.



I think it is too late to fix anything in the actual commits. Just
leave it as it is,
otherwise you may cause a lot of grief to users of the repo. I think
we can live with some missing descriptions
and tags/commits without any contents. As mentioned, for a public
repository we cannot change the history (I have accidentally done that
on the vim-airline repository for a few commits and received a lot of
complaints after that).



Also thanks again for all the best wishes, it helps to keep my spirit
up!


I am late to the party, since I also was offline for more than week
and had to take care of my son.

But please: Take care of yourself first. That should be first
priority. After all, it's just some code. It can wait for some time :)

If there is anything I can help you with regards to the vim stuff, let 
me know.


Also, I'd like to take the opportunity and donate something for Uganda
and encourage the community to do the same :)

Best and please take care of yourself,
Chris

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/4e90db48c3dbf1ee73a5d3b82b097d8e%40256bit.org.


Re: Christian, is your Mercurial server down?

2022-11-02 Fir de Conversatie Tony Mechelynck
Awesome, thanks!

Tony.

On Wed, Nov 2, 2022 at 11:22 AM Christian Brabandt  wrote:
>
> Tony and list,
> I fixed the problem. The problem was, the script stopped working when
> git detected,
> that tag v9.0.0814 was re-defined. So I had to manualy update the tags.
>
> I think it should be good now. Please let me know, if you have any
> questions,
>
> Thanks,
> Chris
>
>
> Am 2022-10-31 16:29, schrieb Christian Brabandt:
> > Tony,
> > I am currently away from my pc, returning tomorrow. I can then check.
> > Sorry for the delay,
> >
> > Best
> > Chris
> >
> >> Am 31.10.2022 um 15:38 schrieb Tony Mechelynck
> >> :
> >>
> >> For some reason after I have downloaded patches up to 9.0.818 (which
> >> doesn't build) with the exception of patch 9.0.816 (which apparently
> >> is missing) your Mercurial server http://hg.256bit.org/vim has been
> >> telling me (for some days already) that there are "no changes found".
> >> However I see in the mailing list that even from his sickbed Bram has
> >> been publishing patches up to 9.0.822 so far. What's the matter?
> >>
> >> Best regards,
> >> Tony.
> >
> > --

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAJkCKXtrNcZxLoBGMZG0ZF56BCgn3NAEb-fw0_tWKv7TmPswXw%40mail.gmail.com.


Re: Christian, is your Mercurial server down?

2022-11-02 Fir de Conversatie Christian Brabandt

Tony and list,
I fixed the problem. The problem was, the script stopped working when 
git detected,

that tag v9.0.0814 was re-defined. So I had to manualy update the tags.

I think it should be good now. Please let me know, if you have any 
questions,


Thanks,
Chris


Am 2022-10-31 16:29, schrieb Christian Brabandt:

Tony,
I am currently away from my pc, returning tomorrow. I can then check.
Sorry for the delay,

Best
Chris

Am 31.10.2022 um 15:38 schrieb Tony Mechelynck 
:


For some reason after I have downloaded patches up to 9.0.818 (which
doesn't build) with the exception of patch 9.0.816 (which apparently
is missing) your Mercurial server http://hg.256bit.org/vim has been
telling me (for some days already) that there are "no changes found".
However I see in the mailing list that even from his sickbed Bram has
been publishing patches up to 9.0.822 so far. What's the matter?

Best regards,
Tony.


--


--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/eb9d1ac3ab94d6d08e96f413a5ffa704%40256bit.org.