Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-30 Fir de Conversatie h_east
Hi Kiichi and list,

2016-12-1(Thu) 12:03:09 UTC+9 Ozaki Kiichi:
> I updated test patch; modified some test-function names.
> 
> https://gist.github.com/ichizok/4d177e3bf8cc9d47d47243577c8d847b
> 
> @h_east:
> 
> > I think that file name and function names that can be used with the whole 
> > test script should be named accordingly.  Maybe we need a prefix?
> 
> Hmm. like 'test_opt_number.vim' and 'Test_number_xxx()' (or 
> 'Test_opt_number_xxx()' ?

Ah, I mentioned only for `view.vim` and the included functions.
I think that they are commonly used from other tests.
So, it would be better to add a prefix such as `Util`. :-)

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-30 Fir de Conversatie Ozaki Kiichi
I updated test patch; modified some test-function names.

https://gist.github.com/ichizok/4d177e3bf8cc9d47d47243577c8d847b

@h_east:

> I think that file name and function names that can be used with the whole 
> test script should be named accordingly.  Maybe we need a prefix?

Hmm. like 'test_opt_number.vim' and 'Test_number_xxx()' (or 
'Test_opt_number_xxx()' ?

Thank you.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-26 Fir de Conversatie h_east
Hi Kiichi,

2016-11-27(Sun) 0:09:20 UTC+9 Ozaki Kiichi:
> https://gist.github.com/ichizok/4d177e3bf8cc9d47d47243577c8d847b
>  
> * add test_number.vim
> * separate some functions from test_breakindent.vim and add view.vim

I think that file name and function names that can be used with the whole test 
script should be named accordingly.  Maybe we need a prefix?

Bram and Vim contributors>
How do you think?

> * change to easily visible expected values of tests in test_breakindent.vim
> 
> Thank you.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-26 Fir de Conversatie Ozaki Kiichi
https://gist.github.com/ichizok/4d177e3bf8cc9d47d47243577c8d847b
 
* add test_number.vim
* separate some functions from test_breakindent.vim and add view.vim
* change to easily visible expected values of tests in test_breakindent.vim

Thank you.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-24 Fir de Conversatie Ozaki Kiichi
Thank you for your confirmation.

> Could you write a test for that? Thanks.

All right, I will do it.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-21 Fir de Conversatie Christian Brabandt
Hi Ozaki!

On Mi, 03 Feb 2016, Ozaki Kiichi wrote:

> a) with 'breakindent' option

This has been fixed

> b) with 'number' option
> 
> test.vim:
> 
> set wrap
> 
> split
> resize 3
> vsplit
> vertical resize 25
> 
> normal! 76ia
> 

I can confirm your patch fixes the issue. 

Could you write a test for that? Thanks.


Best,
Christian
-- 
Wer nicht mit der Zeit geht, geht mit der Zeit!

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-11-19 Fir de Conversatie Ozaki Kiichi
Problem (a) is fixed by 
https://groups.google.com/forum/#!topic/vim_dev/gsCnTUrkCXc

Thank you.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Incorrect cursor position on a long wrapped-line

2016-03-28 Fir de Conversatie Ozaki Kiichi
Would you bear this issue in mind? ;-(

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[PATCH] Incorrect cursor position on a long wrapped-line

2016-02-03 Fir de Conversatie Ozaki Kiichi
Hi,

I report 2 issues that cause incorrect cursor position.


a) with 'breakindent' option

test.vim:

set wrap
set breakindent
set breakindentopt=shift:4

split
vsplit
resize 3
vertical resize 25

normal! 67ia


vim -Nu NONE -S test.vim

http://i.imgur.com/Hay4reZ.png

:startinsert!

http://i.imgur.com/EzzPnbp.png

cursor goes over end-of-line.

I propose to set blank (shift) at topline of window in case of continued-line.

http://i.imgur.com/F0bdRLI.png

patch:
https://gist.github.com/ichizok/40f92fa0dfc81685d504


b) with 'number' option

test.vim:

set wrap

split
resize 3
vsplit
vertical resize 25

normal! 76ia


vim -Nu NONE -S test.vim

http://i.imgur.com/3kI0Uw5.png

:set number

http://i.imgur.com/dIIJG41.png

cursor goes over end-of-line.

gg

http://i.imgur.com/jkvWmVx.png

line number is displayed as continued-line (prefix '--') in spite of 
start-of-line.

patch:
adjust w_skipcol
https://gist.github.com/ichizok/dfd1eeecb150e68bf3a1


Thank you.
- Ozaki Kiichi

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.