Re: Patch 8.0.1693
On Mi, 11 Apr 2018, Bram Moolenaar wrote: > I added the -i argument, but now coveralls shows no coverage at all Yeah, I saw that, not sure what is going on. I asked support about it. Best, Christian -- Ich habe mir nie meine Erziehung durch Schulbildung verderben lassen. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.0.1693
Christian wrote: > > > On Di, 10 Apr 2018, Bram Moolenaar wrote: > > > > > > > > > > > Patch 8.0.1693 > > > > Problem:Xxd is excluded from coverage statistics. > > > > Solution: Don't skip the xxd directory. (Christian Brabandt) > > > > Files: .travis.yml > > > > > > I think this is still not working correctly. > > > > > > >From https://api.travis-ci.org/v3/job/364771625/log.txt > > > Coverage: > > > File 'xxd.c' > > > Lines executed:58.03% of 355 > > > Creating 'xxd.c.gcov' > > > Cannot open source file xxd.c > > > > > > Codecov: > > > File 'xxd.c' > > > Lines executed:58.03% of 355 > > > Branches executed:76.17% of 428 > > > Taken at least once:50.23% of 428 > > > Calls executed:31.72% of 145 > > > Creating 'xxd.c.gcov' > > > Cannot open source file xxd.c > > > > > > Don't know why this is happening (but e.g. working for libvterm). > > > > The libvterm files are build from the main src directory, xxd is in > > src/xxd. Apparently it doesn't know about the xxd subdirectory. > > I see. In fact, codecov.io did collect the coverage statistics already: > https://codecov.io/gh/vim/vim/src/master/src/xxd/xxd.c > > > Is it possible to specify two build directories? > > > Kind of, so I think there is a workaround. Currently coveralls fails with > this error: > https://api.travis-ci.org/v3/job/364785069/log.txt > , > | Traceback (most recent call last): > | File "/home/travis/.local/bin/coveralls", line 11, in > | sys.exit(run()) > | File > "/home/travis/.local/lib/python2.7/site-packages/cpp_coveralls/__init__.py", > line 97, in run > | cov_report = coverage.collect(args) > | File > "/home/travis/.local/lib/python2.7/site-packages/cpp_coveralls/coverage.py", > line 447, in collect > | with io.open(source_file_path, mode='rb') as src_file: > | IOError: [Errno 2] No such file or directory: './src/xxd.c' > ` > > This is what is run currently (whithout the verbose and dry-run parameters): > ~/.local/bin/coveralls --verbose --dryrun -b ./src -x .xs -e ./src/if_perl.c > --encodings utf-8 latin-1 EUC-KR > and this produces: > , > | [...] > | File 'xxd.c' > | Lines executed:14.57% of 357 > | Creating 'xxd.c.gcov' > | Cannot open source file xxd.c > | > | Traceback (most recent call last): > | File "/home/chrisbra/.local/bin/coveralls", line 11, in > | sys.exit(run()) > | File > "/home/chrisbra/.local/lib/python2.7/site-packages/cpp_coveralls/__init__.py", > line 97, in run > | cov_report = coverage.collect(args) > | File > "/home/chrisbra/.local/lib/python2.7/site-packages/cpp_coveralls/coverage.py", > line 447, in collect > | with io.open(source_file_path, mode='rb') as src_file: > | IOError: [Errno 2] No such file or directory: './src/xxd.c' > ` > > >From my testing this seems to work adding the `-i ./src/xxd` parameter > > using the -i parameter you should be able to get rid of the crash, however it > still reports it cannot open xxd.c > ~/.local/bin/coveralls --verbose --dryrun -b ./src -i ./src/xxd -x .xs -e > ./src/if_perl.c --encodings utf-8 latin-1 EUC-KR I added the -i argument, but now coveralls shows no coverage at all > , > | File 'xxd.c' > | Lines executed:14.57% of 357 > | Creating 'xxd.c.gcov' > | Cannot open source file xxd.c > ` > > This might already work, if not, we might need to link src/xxd/xxd.c to > src/xxd.c Then I got rid of the "Cannot open source file" message. > > I also asked for advice on the cpp-coveralls github project, but there > doesn't seem to be very much activity, so I don't know if I will receive an > answer. -- hundred-and-one symptoms of being an internet addict: 161. You get up before the sun rises to check your e-mail, and you find yourself in the very same chair long after the sun has set. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.0.1693
On Di, 10 Apr 2018, Bram Moolenaar wrote: > > Christian wrote: > > > On Di, 10 Apr 2018, Bram Moolenaar wrote: > > > > > > > > Patch 8.0.1693 > > > Problem:Xxd is excluded from coverage statistics. > > > Solution: Don't skip the xxd directory. (Christian Brabandt) > > > Files: .travis.yml > > > > I think this is still not working correctly. > > > > >From https://api.travis-ci.org/v3/job/364771625/log.txt > > Coverage: > > File 'xxd.c' > > Lines executed:58.03% of 355 > > Creating 'xxd.c.gcov' > > Cannot open source file xxd.c > > > > Codecov: > > File 'xxd.c' > > Lines executed:58.03% of 355 > > Branches executed:76.17% of 428 > > Taken at least once:50.23% of 428 > > Calls executed:31.72% of 145 > > Creating 'xxd.c.gcov' > > Cannot open source file xxd.c > > > > Don't know why this is happening (but e.g. working for libvterm). > > The libvterm files are build from the main src directory, xxd is in > src/xxd. Apparently it doesn't know about the xxd subdirectory. I see. In fact, codecov.io did collect the coverage statistics already: https://codecov.io/gh/vim/vim/src/master/src/xxd/xxd.c > Is it possible to specify two build directories? Kind of, so I think there is a workaround. Currently coveralls fails with this error: https://api.travis-ci.org/v3/job/364785069/log.txt , | Traceback (most recent call last): | File "/home/travis/.local/bin/coveralls", line 11, in | sys.exit(run()) | File "/home/travis/.local/lib/python2.7/site-packages/cpp_coveralls/__init__.py", line 97, in run | cov_report = coverage.collect(args) | File "/home/travis/.local/lib/python2.7/site-packages/cpp_coveralls/coverage.py", line 447, in collect | with io.open(source_file_path, mode='rb') as src_file: | IOError: [Errno 2] No such file or directory: './src/xxd.c' ` This is what is run currently (whithout the verbose and dry-run parameters): ~/.local/bin/coveralls --verbose --dryrun -b ./src -x .xs -e ./src/if_perl.c --encodings utf-8 latin-1 EUC-KR and this produces: , | [...] | File 'xxd.c' | Lines executed:14.57% of 357 | Creating 'xxd.c.gcov' | Cannot open source file xxd.c | | Traceback (most recent call last): | File "/home/chrisbra/.local/bin/coveralls", line 11, in | sys.exit(run()) | File "/home/chrisbra/.local/lib/python2.7/site-packages/cpp_coveralls/__init__.py", line 97, in run | cov_report = coverage.collect(args) | File "/home/chrisbra/.local/lib/python2.7/site-packages/cpp_coveralls/coverage.py", line 447, in collect | with io.open(source_file_path, mode='rb') as src_file: | IOError: [Errno 2] No such file or directory: './src/xxd.c' ` >From my testing this seems to work adding the `-i ./src/xxd` parameter using the -i parameter you should be able to get rid of the crash, however it still reports it cannot open xxd.c ~/.local/bin/coveralls --verbose --dryrun -b ./src -i ./src/xxd -x .xs -e ./src/if_perl.c --encodings utf-8 latin-1 EUC-KR , | File 'xxd.c' | Lines executed:14.57% of 357 | Creating 'xxd.c.gcov' | Cannot open source file xxd.c ` This might already work, if not, we might need to link src/xxd/xxd.c to src/xxd.c Then I got rid of the "Cannot open source file" message. I also asked for advice on the cpp-coveralls github project, but there doesn't seem to be very much activity, so I don't know if I will receive an answer. Best, Christian -- Was ist der Unterschied zwischen einem Alkoholiker und Windows 95? Beide stürzten regelmäßig ab. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.0.1693
Christian wrote: > On Di, 10 Apr 2018, Bram Moolenaar wrote: > > > > > Patch 8.0.1693 > > Problem:Xxd is excluded from coverage statistics. > > Solution: Don't skip the xxd directory. (Christian Brabandt) > > Files: .travis.yml > > I think this is still not working correctly. > > >From https://api.travis-ci.org/v3/job/364771625/log.txt > Coverage: > File 'xxd.c' > Lines executed:58.03% of 355 > Creating 'xxd.c.gcov' > Cannot open source file xxd.c > > Codecov: > File 'xxd.c' > Lines executed:58.03% of 355 > Branches executed:76.17% of 428 > Taken at least once:50.23% of 428 > Calls executed:31.72% of 145 > Creating 'xxd.c.gcov' > Cannot open source file xxd.c > > Don't know why this is happening (but e.g. working for libvterm). The libvterm files are build from the main src directory, xxd is in src/xxd. Apparently it doesn't know about the xxd subdirectory. Is it possible to specify two build directories? -- hundred-and-one symptoms of being an internet addict: 159. You get excited whenever discussing your hard drive. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.0.1693
On Di, 10 Apr 2018, Bram Moolenaar wrote: > > Patch 8.0.1693 > Problem:Xxd is excluded from coverage statistics. > Solution: Don't skip the xxd directory. (Christian Brabandt) > Files: .travis.yml I think this is still not working correctly. >From https://api.travis-ci.org/v3/job/364771625/log.txt Coverage: File 'xxd.c' Lines executed:58.03% of 355 Creating 'xxd.c.gcov' Cannot open source file xxd.c Codecov: File 'xxd.c' Lines executed:58.03% of 355 Branches executed:76.17% of 428 Taken at least once:50.23% of 428 Calls executed:31.72% of 145 Creating 'xxd.c.gcov' Cannot open source file xxd.c Don't know why this is happening (but e.g. working for libvterm). Best, Christian -- Das Aufsehenerregende kann nur passieren, wenn der Alltag funktioniert. -- Hansgünther Heyme -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.0.1693
Patch 8.0.1693 Problem:Xxd is excluded from coverage statistics. Solution: Don't skip the xxd directory. (Christian Brabandt) Files: .travis.yml *** ../vim-8.0.1692/.travis.yml 2017-11-17 21:25:02.960971261 +0100 --- .travis.yml 2018-04-10 21:14:12.551794327 +0200 *** *** 108,114 - if [ -n "$err" ]; then exit 1; fi after_success: ! - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x .xs -e ${SRCDIR}/xxd -e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; fi - if [ "$COVERAGE" = "yes" ]; then cd $SRCDIR && bash <(curl -s https://codecov.io/bash) ; fi # vim:set sts=2 sw=2 tw=0 et: --- 108,114 - if [ -n "$err" ]; then exit 1; fi after_success: ! - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x .xs -e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; fi - if [ "$COVERAGE" = "yes" ]; then cd $SRCDIR && bash <(curl -s https://codecov.io/bash) ; fi # vim:set sts=2 sw=2 tw=0 et: *** ../vim-8.0.1692/src/version.c 2018-04-10 20:26:14.271224484 +0200 --- src/version.c 2018-04-10 21:15:44.475105407 +0200 *** *** 764,765 --- 764,767 { /* Add new patch number below this line */ + /**/ + 1693, /**/ -- hundred-and-one symptoms of being an internet addict: 155. You forget to eat because you're too busy surfing the net. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.