Re: Patch 9.0.0787
Thanks John, Yeah, I think I have it working now - making mouse scroll events work in windows terminal even without dll. But for some reason, it's still not recognising any mousscroll mappings (with or without the dll). I want to make sure it also does mappings properly before I submit a new patch. Anyway, I will make sure to check mingw64 toolchain, and gcc compilations, for these sorts of warnings in the future. Feel like its something that I should have done. Cheers, Chris. On Wednesday, 19 October 2022 at 07:51:02 UTC+11 Bram Moolenaar wrote: > > John Marriott wrote: > > > On 18-Oct-2022 23:34, Bram Moolenaar wrote: > > > Patch 9.0.0787 (after 9.0.0775) > > > Problem: MS-Windows: mouse scrolling in terminal misbehaves without > dll. > > > Solution: Add #ifdef as a temporary solution. (Christopher Plewright, > > > closes #11392) > > > Files: src/os_win32.c > > > > > > > > I know this was a temporary solution, but after this patch mingw64 (gcc > > 12.2.0) gives this warning in a non-gui build: > > > > gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 > > -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO > > -pipe -Wall -O3 -fomit-frame-pointer -freg-struct-return -fpie -fPIE > > os_win32.c -o objx86-64/os_win32.o os_win32.c:1257:1: warning: > > 'decode_mouse_wheel' defined but not used [-Wunused-function] > > 1257 | decode_mouse_wheel(MOUSE_EVENT_RECORD *pmer) > > | ^~ > > > > > > The attached patch tries to fix it. > > Thanks. It's a temporary solution, but I have no idea how long it takes > before we have it working again. > > -- > LETTERS TO THE EDITOR (The Times of London) > > Dear Sir, > > I am firmly opposed to the spread of microchips either to the home or > to the office. We have more than enough of them foisted upon us in > public places. They are a disgusting Americanism, and can only result > in the farmers being forced to grow smaller potatoes, which in turn > will cause massive unemployment in the already severely depressed > agricultural industry. > > Yours faithfully, > Capt. Quinton D'Arcy, J. P. > Sevenoaks > > /// Bram Moolenaar -- br...@moolenaar.net -- http://www.Moolenaar.net \\\ > /// \\\ > \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org /// > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/f7f85099-971d-46bd-abb8-d072ff2fbe15n%40googlegroups.com.
Re: Patch 9.0.0787
John Marriott wrote: > On 18-Oct-2022 23:34, Bram Moolenaar wrote: > > Patch 9.0.0787 (after 9.0.0775) > > Problem:MS-Windows: mouse scrolling in terminal misbehaves without dll. > > Solution: Add #ifdef as a temporary solution. (Christopher Plewright, > > closes #11392) > > Files: src/os_win32.c > > > > > I know this was a temporary solution, but after this patch mingw64 (gcc > 12.2.0) gives this warning in a non-gui build: > > gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 > -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO > -pipe -Wall -O3 -fomit-frame-pointer -freg-struct-return -fpie -fPIE > os_win32.c -o objx86-64/os_win32.o os_win32.c:1257:1: warning: > 'decode_mouse_wheel' defined but not used [-Wunused-function] > 1257 | decode_mouse_wheel(MOUSE_EVENT_RECORD *pmer) > | ^~ > > > The attached patch tries to fix it. Thanks. It's a temporary solution, but I have no idea how long it takes before we have it working again. -- LETTERS TO THE EDITOR (The Times of London) Dear Sir, I am firmly opposed to the spread of microchips either to the home or to the office. We have more than enough of them foisted upon us in public places. They are a disgusting Americanism, and can only result in the farmers being forced to grow smaller potatoes, which in turn will cause massive unemployment in the already severely depressed agricultural industry. Yours faithfully, Capt. Quinton D'Arcy, J. P. Sevenoaks /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20221018205049.648801C0EE2%40moolenaar.net.
Re: Patch 9.0.0787
On 18-Oct-2022 23:34, Bram Moolenaar wrote: Patch 9.0.0787 (after 9.0.0775) Problem:MS-Windows: mouse scrolling in terminal misbehaves without dll. Solution: Add #ifdef as a temporary solution. (Christopher Plewright, closes #11392) Files: src/os_win32.c I know this was a temporary solution, but after this patch mingw64 (gcc 12.2.0) gives this warning in a non-gui build: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe -Wall -O3 -fomit-frame-pointer -freg-struct-return -fpie -fPIE os_win32.c -o objx86-64/os_win32.o os_win32.c:1257:1: warning: 'decode_mouse_wheel' defined but not used [-Wunused-function] 1257 | decode_mouse_wheel(MOUSE_EVENT_RECORD *pmer) | ^~ The attached patch tries to fix it. Cheers John -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/8c9c415f-8e41-c7a0-6dbc-1a4821e9118e%40internode.on.net. --- os_win32.c.orig 2022-10-19 05:53:52.120873800 +1100 +++ os_win32.c 2022-10-19 06:00:33.470687000 +1100 @@ -1231,7 +1231,7 @@ } # endif - +#ifdef VIMDLL /* * Win32 console mouse scroll event handler. * Loosely based on the _OnMouseWheel() function in gui_w32.c @@ -1324,6 +1324,7 @@ return; } +#endif /* * Decode a MOUSE_EVENT. If it's a valid event, return MOUSE_LEFT,
Patch 9.0.0787
Patch 9.0.0787 (after 9.0.0775)
Problem:MS-Windows: mouse scrolling in terminal misbehaves without dll.
Solution: Add #ifdef as a temporary solution. (Christopher Plewright,
closes #11392)
Files: src/os_win32.c
*** ../vim-9.0.0786/src/os_win32.c 2022-10-16 19:45:24.558960645 +0100
--- src/os_win32.c 2022-10-18 13:32:49.424975101 +0100
***
*** 1397,1410
// unprocessed mouse click?
if (g_nMouseClick != -1)
return TRUE;
!
if (pmer->dwEventFlags == MOUSE_WHEELED
|| pmer->dwEventFlags == MOUSE_HWHEELED)
{
decode_mouse_wheel(pmer);
return TRUE; // we now should have a mouse scroll in g_nMouseClick
}
!
nButton = -1;
g_xMouse = pmer->dwMousePosition.X;
g_yMouse = pmer->dwMousePosition.Y;
--- 1397,1410
// unprocessed mouse click?
if (g_nMouseClick != -1)
return TRUE;
! #ifdef VIMDLL
if (pmer->dwEventFlags == MOUSE_WHEELED
|| pmer->dwEventFlags == MOUSE_HWHEELED)
{
decode_mouse_wheel(pmer);
return TRUE; // we now should have a mouse scroll in g_nMouseClick
}
! #endif
nButton = -1;
g_xMouse = pmer->dwMousePosition.X;
g_yMouse = pmer->dwMousePosition.Y;
*** ../vim-9.0.0786/src/version.c 2022-10-18 13:11:18.466896436 +0100
--- src/version.c 2022-10-18 13:31:00.853134212 +0100
***
*** 697,698
--- 697,700
{ /* Add new patch number below this line */
+ /**/
+ 787,
/**/
--
If you only have a hammer, you tend to see every problem as a nail.
If you only have MS-Windows, you tend to solve every problem by rebooting.
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/20221018123417.8DE1B1C0EE2%40moolenaar.net.
